All of lore.kernel.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: atish.patra@wdc.com, linux-kernel@vger.kernel.org,
	aou@eecs.berkeley.edu, dmitriy@oss-tech.org, anup@brainfault.org,
	johan@kernel.org, Christoph Hellwig <hch@infradead.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	schwab@suse.de, linux-riscv@lists.infradead.org,
	tglx@linutronix.de
Subject: Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id
Date: Mon, 29 Apr 2019 17:36:51 -0700 (PDT)	[thread overview]
Message-ID: <mhng-42e98065-6d8f-455c-97d9-0a2dfccc731a@palmer-si-x1e> (raw)
In-Reply-To: <20190424062100.GB3902@infradead.org>

On Tue, 23 Apr 2019 23:21:00 PDT (-0700), Christoph Hellwig wrote:
>>  }
>> +
>> +bool arch_match_cpu_phys_id(int cpu, u64 phys_id)
>> +{
>> +	return phys_id == cpuid_to_hartid_map(cpu);
>> +}
>>  /* Unsupported */
>
> Please keep an empty line after function bodys.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Oh, sorry, I missed this -- I just fixed up the patch and added your tag.

WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: aou@eecs.berkeley.edu, dmitriy@oss-tech.org, anup@brainfault.org,
	johan@kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	atish.patra@wdc.com, Paul Walmsley <paul.walmsley@sifive.com>,
	schwab@suse.de, linux-riscv@lists.infradead.org,
	tglx@linutronix.de
Subject: Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id
Date: Mon, 29 Apr 2019 17:36:51 -0700 (PDT)	[thread overview]
Message-ID: <mhng-42e98065-6d8f-455c-97d9-0a2dfccc731a@palmer-si-x1e> (raw)
In-Reply-To: <20190424062100.GB3902@infradead.org>

On Tue, 23 Apr 2019 23:21:00 PDT (-0700), Christoph Hellwig wrote:
>>  }
>> +
>> +bool arch_match_cpu_phys_id(int cpu, u64 phys_id)
>> +{
>> +	return phys_id == cpuid_to_hartid_map(cpu);
>> +}
>>  /* Unsupported */
>
> Please keep an empty line after function bodys.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Oh, sorry, I missed this -- I just fixed up the patch and added your tag.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2019-04-30  0:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  0:02 [PATCH v3 0/3] Miscellaneous kernel command line fixes Atish Patra
2019-04-24  0:02 ` Atish Patra
2019-04-24  0:02 ` [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id Atish Patra
2019-04-24  0:02   ` Atish Patra
2019-04-24  6:21   ` Christoph Hellwig
2019-04-24  6:21     ` Christoph Hellwig
2019-04-30  0:36     ` Palmer Dabbelt [this message]
2019-04-30  0:36       ` Palmer Dabbelt
2019-04-24  9:07   ` Sudeep Holla
2019-04-24  9:07     ` Sudeep Holla
2019-04-24 16:50     ` Atish Patra
2019-04-24 16:50       ` Atish Patra
2019-04-24  0:02 ` [PATCH v3 2/3] RISC-V: Implement nosmp commandline option Atish Patra
2019-04-24  0:02   ` Atish Patra
2019-04-24  6:21   ` Christoph Hellwig
2019-04-24  6:21     ` Christoph Hellwig
2019-04-29 23:50   ` Palmer Dabbelt
2019-04-29 23:50     ` Palmer Dabbelt
2019-04-24  0:02 ` [PATCH v3 3/3] RISC-V: Support nr_cpus command line option Atish Patra
2019-04-24  0:02   ` Atish Patra
2019-04-24  6:22   ` Christoph Hellwig
2019-04-24  6:22     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-42e98065-6d8f-455c-97d9-0a2dfccc731a@palmer-si-x1e \
    --to=palmer@sifive.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=dmitriy@oss-tech.org \
    --cc=hch@infradead.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=paul.walmsley@sifive.com \
    --cc=schwab@suse.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.