From: Palmer Dabbelt <palmer@dabbelt.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: apatel@ventanamicro.com, Paul Walmsley <paul.walmsley@sifive.com>,
atishp@atishpatra.org, heiko@sntech.de, anup@brainfault.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
mchitale@ventanamicro.com
Subject: Re: [PATCH v2 1/4] RISC-V: Fix ioremap_cache() and ioremap_wc() for systems with Svpbmt
Date: Thu, 06 Oct 2022 20:50:00 -0700 (PDT) [thread overview]
Message-ID: <mhng-96bfb7a5-6579-4ebc-9517-db2e62d2f82b@palmer-ri-x1c9> (raw)
In-Reply-To: <YzQ6pqykLhJVeD2p@infradead.org>
On Wed, 28 Sep 2022 05:14:30 PDT (-0700), Christoph Hellwig wrote:
> On Thu, Sep 22, 2022 at 09:35:56AM -0700, Palmer Dabbelt wrote:
>> Sorry I missed this, I thought it was just part of the rest of this patch
>> set. That said, I'm not actually sure this is a critical fix: sure it's a
>> performance problem, and if some driver is expecting ioremap_cache() to go
>> fast then possibly a pretty big one, but the only Svpmbt hardware that
>
> More importantly nothing should be using ioremap_cache at all. It is
> an API that has long been deprecated in favor of memremap.
There's a few uses of it, I just send along a patch to make it
arch-specific and make the users depend on it. That should let us stop
adding this to ports just to get the drivers building.
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: apatel@ventanamicro.com, Paul Walmsley <paul.walmsley@sifive.com>,
atishp@atishpatra.org, heiko@sntech.de, anup@brainfault.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
mchitale@ventanamicro.com
Subject: Re: [PATCH v2 1/4] RISC-V: Fix ioremap_cache() and ioremap_wc() for systems with Svpbmt
Date: Thu, 06 Oct 2022 20:50:00 -0700 (PDT) [thread overview]
Message-ID: <mhng-96bfb7a5-6579-4ebc-9517-db2e62d2f82b@palmer-ri-x1c9> (raw)
In-Reply-To: <YzQ6pqykLhJVeD2p@infradead.org>
On Wed, 28 Sep 2022 05:14:30 PDT (-0700), Christoph Hellwig wrote:
> On Thu, Sep 22, 2022 at 09:35:56AM -0700, Palmer Dabbelt wrote:
>> Sorry I missed this, I thought it was just part of the rest of this patch
>> set. That said, I'm not actually sure this is a critical fix: sure it's a
>> performance problem, and if some driver is expecting ioremap_cache() to go
>> fast then possibly a pretty big one, but the only Svpmbt hardware that
>
> More importantly nothing should be using ioremap_cache at all. It is
> an API that has long been deprecated in favor of memremap.
There's a few uses of it, I just send along a patch to make it
arch-specific and make the users depend on it. That should let us stop
adding this to ports just to get the drivers building.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-10-07 3:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 4:46 [PATCH v2 0/4] Add PMEM support for RISC-V Anup Patel
2022-08-30 4:46 ` Anup Patel
2022-08-30 4:46 ` [PATCH v2 1/4] RISC-V: Fix ioremap_cache() and ioremap_wc() for systems with Svpbmt Anup Patel
2022-08-30 4:46 ` Anup Patel
2022-09-01 15:25 ` Heiko Stübner
2022-09-01 15:25 ` Heiko Stübner
2022-09-01 16:07 ` Conor.Dooley
2022-09-01 16:07 ` Conor.Dooley
2022-09-09 8:10 ` Anup Patel
2022-09-09 8:10 ` Anup Patel
2022-09-16 2:24 ` Anup Patel
2022-09-16 2:24 ` Anup Patel
2022-09-22 16:35 ` Palmer Dabbelt
2022-09-22 16:35 ` Palmer Dabbelt
2022-09-23 10:35 ` Arnd Bergmann
2022-09-23 10:35 ` Arnd Bergmann
2022-09-23 10:45 ` Palmer Dabbelt
2022-09-23 10:45 ` Palmer Dabbelt
2022-09-28 12:14 ` Christoph Hellwig
2022-09-28 12:14 ` Christoph Hellwig
2022-10-07 3:50 ` Palmer Dabbelt [this message]
2022-10-07 3:50 ` Palmer Dabbelt
2022-10-07 5:34 ` Anup Patel
2022-10-07 5:34 ` Anup Patel
2022-08-30 4:46 ` [PATCH v2 2/4] RISC-V: Move riscv_init_cbom_blocksize() to cacheflush.c Anup Patel
2022-08-30 4:46 ` Anup Patel
2022-09-01 15:29 ` Heiko Stübner
2022-09-01 15:29 ` Heiko Stübner
2022-09-01 15:49 ` Conor.Dooley
2022-09-01 15:49 ` Conor.Dooley
2022-08-30 4:46 ` [PATCH v2 3/4] RISC-V: Implement arch specific PMEM APIs Anup Patel
2022-08-30 4:46 ` Anup Patel
2022-09-01 15:38 ` Heiko Stübner
2022-09-01 15:38 ` Heiko Stübner
2022-09-03 16:03 ` Anup Patel
2022-09-03 16:03 ` Anup Patel
2022-08-30 4:46 ` [PATCH v2 4/4] RISC-V: Enable PMEM drivers Anup Patel
2022-08-30 4:46 ` Anup Patel
2022-09-01 16:11 ` Conor.Dooley
2022-09-01 16:11 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-96bfb7a5-6579-4ebc-9517-db2e62d2f82b@palmer-ri-x1c9 \
--to=palmer@dabbelt.com \
--cc=anup@brainfault.org \
--cc=apatel@ventanamicro.com \
--cc=atishp@atishpatra.org \
--cc=hch@infradead.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mchitale@ventanamicro.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.