From: Palmer Dabbelt <palmer@dabbelt.com> To: nathan@kernel.org Cc: elver@google.com, akpm@linux-foundation.org, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, ndesaulniers@google.com, Arnd Bergmann <arnd@arndb.de>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, linux-mm@kvack.org Subject: Re: [PATCH] kasan: Always respect CONFIG_KASAN_STACK Date: Fri, 08 Oct 2021 11:46:55 -0700 (PDT) [thread overview] Message-ID: <mhng-b5f8a6a0-c3e8-4d25-9daa-346fdc8a2e5e@palmerdabbelt-glaptop> (raw) In-Reply-To: <YUyWYpDl2Dmegz0a@archlinux-ax161> On Thu, 23 Sep 2021 07:59:46 PDT (-0700), nathan@kernel.org wrote: > On Thu, Sep 23, 2021 at 12:07:17PM +0200, Marco Elver wrote: >> On Wed, 22 Sept 2021 at 22:55, Nathan Chancellor <nathan@kernel.org> wrote: >> > Currently, the asan-stack parameter is only passed along if >> > CFLAGS_KASAN_SHADOW is not empty, which requires KASAN_SHADOW_OFFSET to >> > be defined in Kconfig so that the value can be checked. In RISC-V's >> > case, KASAN_SHADOW_OFFSET is not defined in Kconfig, which means that >> > asan-stack does not get disabled with clang even when CONFIG_KASAN_STACK >> > is disabled, resulting in large stack warnings with allmodconfig: >> > >> > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:117:12: >> > error: stack frame size (14400) exceeds limit (2048) in function >> > 'lb035q02_connect' [-Werror,-Wframe-larger-than] >> > static int lb035q02_connect(struct omap_dss_device *dssdev) >> > ^ >> > 1 error generated. >> > >> > Ensure that the value of CONFIG_KASAN_STACK is always passed along to >> > the compiler so that these warnings do not happen when >> > CONFIG_KASAN_STACK is disabled. >> > >> > Link: https://github.com/ClangBuiltLinux/linux/issues/1453 >> > References: 6baec880d7a5 ("kasan: turn off asan-stack for clang-8 and earlier") >> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> >> >> Reviewed-by: Marco Elver <elver@google.com> > > Thanks! > >> [ Which tree are you planning to take it through? ] > > Gah, I was intending for it to go through -mm, then I cc'd neither > Andrew nor linux-mm... :/ Andrew, do you want me to resend or can you > grab it from LKML? Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> (assuming you still want it through somewhere else) >> Note, arch/riscv/include/asm/kasan.h mentions KASAN_SHADOW_OFFSET in >> comment (copied from arm64). Did RISC-V just forget to copy over the >> Kconfig option? > > I do see it defined in that file as well but you are right that they did > not copy the Kconfig logic, even though it was present in the tree when > RISC-V KASAN was implemented. Perhaps they should so that they get > access to the other flags in the "else" branch? Ya, looks like we just screwed this up. I'm seeing some warnings like cc1: warning: ‘-fsanitize=kernel-address’ with stack protection is not supported without ‘-fasan-shadow-offset=’ for this target which is how I ended up here, I'm assuming that's what you're talking about here? LMK if you were planning on sending along a fix or if you want me to go figure it out. > >> > --- >> > scripts/Makefile.kasan | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan >> > index 801c415bac59..b9e94c5e7097 100644 >> > --- a/scripts/Makefile.kasan >> > +++ b/scripts/Makefile.kasan >> > @@ -33,10 +33,11 @@ else >> > CFLAGS_KASAN := $(CFLAGS_KASAN_SHADOW) \ >> > $(call cc-param,asan-globals=1) \ >> > $(call cc-param,asan-instrumentation-with-call-threshold=$(call_threshold)) \ >> > - $(call cc-param,asan-stack=$(stack_enable)) \ >> > $(call cc-param,asan-instrument-allocas=1) >> > endif >> > >> > +CFLAGS_KASAN += $(call cc-param,asan-stack=$(stack_enable)) >> > + >> > endif # CONFIG_KASAN_GENERIC >> > >> > ifdef CONFIG_KASAN_SW_TAGS >> > >> > base-commit: 4057525736b159bd456732d11270af2cc49ec21f >> > -- >> > 2.33.0.514.g99c99ed825 >> > >> >
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@dabbelt.com> To: nathan@kernel.org Cc: elver@google.com, akpm@linux-foundation.org, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, ndesaulniers@google.com, Arnd Bergmann <arnd@arndb.de>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu, linux-mm@kvack.org Subject: Re: [PATCH] kasan: Always respect CONFIG_KASAN_STACK Date: Fri, 08 Oct 2021 11:46:55 -0700 (PDT) [thread overview] Message-ID: <mhng-b5f8a6a0-c3e8-4d25-9daa-346fdc8a2e5e@palmerdabbelt-glaptop> (raw) In-Reply-To: <YUyWYpDl2Dmegz0a@archlinux-ax161> On Thu, 23 Sep 2021 07:59:46 PDT (-0700), nathan@kernel.org wrote: > On Thu, Sep 23, 2021 at 12:07:17PM +0200, Marco Elver wrote: >> On Wed, 22 Sept 2021 at 22:55, Nathan Chancellor <nathan@kernel.org> wrote: >> > Currently, the asan-stack parameter is only passed along if >> > CFLAGS_KASAN_SHADOW is not empty, which requires KASAN_SHADOW_OFFSET to >> > be defined in Kconfig so that the value can be checked. In RISC-V's >> > case, KASAN_SHADOW_OFFSET is not defined in Kconfig, which means that >> > asan-stack does not get disabled with clang even when CONFIG_KASAN_STACK >> > is disabled, resulting in large stack warnings with allmodconfig: >> > >> > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:117:12: >> > error: stack frame size (14400) exceeds limit (2048) in function >> > 'lb035q02_connect' [-Werror,-Wframe-larger-than] >> > static int lb035q02_connect(struct omap_dss_device *dssdev) >> > ^ >> > 1 error generated. >> > >> > Ensure that the value of CONFIG_KASAN_STACK is always passed along to >> > the compiler so that these warnings do not happen when >> > CONFIG_KASAN_STACK is disabled. >> > >> > Link: https://github.com/ClangBuiltLinux/linux/issues/1453 >> > References: 6baec880d7a5 ("kasan: turn off asan-stack for clang-8 and earlier") >> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> >> >> Reviewed-by: Marco Elver <elver@google.com> > > Thanks! > >> [ Which tree are you planning to take it through? ] > > Gah, I was intending for it to go through -mm, then I cc'd neither > Andrew nor linux-mm... :/ Andrew, do you want me to resend or can you > grab it from LKML? Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> (assuming you still want it through somewhere else) >> Note, arch/riscv/include/asm/kasan.h mentions KASAN_SHADOW_OFFSET in >> comment (copied from arm64). Did RISC-V just forget to copy over the >> Kconfig option? > > I do see it defined in that file as well but you are right that they did > not copy the Kconfig logic, even though it was present in the tree when > RISC-V KASAN was implemented. Perhaps they should so that they get > access to the other flags in the "else" branch? Ya, looks like we just screwed this up. I'm seeing some warnings like cc1: warning: ‘-fsanitize=kernel-address’ with stack protection is not supported without ‘-fasan-shadow-offset=’ for this target which is how I ended up here, I'm assuming that's what you're talking about here? LMK if you were planning on sending along a fix or if you want me to go figure it out. > >> > --- >> > scripts/Makefile.kasan | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan >> > index 801c415bac59..b9e94c5e7097 100644 >> > --- a/scripts/Makefile.kasan >> > +++ b/scripts/Makefile.kasan >> > @@ -33,10 +33,11 @@ else >> > CFLAGS_KASAN := $(CFLAGS_KASAN_SHADOW) \ >> > $(call cc-param,asan-globals=1) \ >> > $(call cc-param,asan-instrumentation-with-call-threshold=$(call_threshold)) \ >> > - $(call cc-param,asan-stack=$(stack_enable)) \ >> > $(call cc-param,asan-instrument-allocas=1) >> > endif >> > >> > +CFLAGS_KASAN += $(call cc-param,asan-stack=$(stack_enable)) >> > + >> > endif # CONFIG_KASAN_GENERIC >> > >> > ifdef CONFIG_KASAN_SW_TAGS >> > >> > base-commit: 4057525736b159bd456732d11270af2cc49ec21f >> > -- >> > 2.33.0.514.g99c99ed825 >> > >> > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-10-08 18:46 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-22 20:55 [PATCH] kasan: Always respect CONFIG_KASAN_STACK Nathan Chancellor 2021-09-23 10:07 ` Marco Elver 2021-09-23 10:07 ` Marco Elver 2021-09-23 10:07 ` Marco Elver 2021-09-23 14:59 ` Nathan Chancellor 2021-09-23 14:59 ` Nathan Chancellor 2021-10-08 18:46 ` Palmer Dabbelt [this message] 2021-10-08 18:46 ` Palmer Dabbelt 2021-10-14 16:55 ` Nathan Chancellor 2021-10-14 16:55 ` Nathan Chancellor 2021-10-14 18:31 ` Alex Ghiti 2021-10-14 18:31 ` Alex Ghiti 2021-10-15 13:04 ` Alexandre ghiti 2021-10-15 13:04 ` Alexandre ghiti 2021-10-26 4:39 ` Alexandre Ghiti 2021-10-26 4:39 ` Alexandre Ghiti 2021-10-26 4:48 ` Dmitry Vyukov 2021-10-26 4:48 ` Dmitry Vyukov 2021-10-26 11:33 ` Alexandre Ghiti 2021-10-26 11:33 ` Alexandre Ghiti 2021-10-16 1:11 ` Palmer Dabbelt 2021-10-16 1:11 ` Palmer Dabbelt 2021-10-03 18:04 ` Andrey Konovalov 2021-10-03 18:04 ` Andrey Konovalov 2021-10-06 2:43 ` Nathan Chancellor 2021-10-06 11:57 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=mhng-b5f8a6a0-c3e8-4d25-9daa-346fdc8a2e5e@palmerdabbelt-glaptop \ --to=palmer@dabbelt.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=arnd@arndb.de \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=llvm@lists.linux.dev \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=paul.walmsley@sifive.com \ --cc=ryabinin.a.a@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.