* Re: [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices.
[not found] <acdda6f0-3675-7e8b-b57c-711fe8199ce9@fourwalledcubicle.com>
@ 2020-11-25 13:12 ` Jiri Kosina
2020-11-25 22:26 ` Dean Camera
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2020-11-25 13:12 UTC (permalink / raw)
To: Dean Camera; +Cc: Benjamin Tissoires, linux-input
On Wed, 18 Nov 2020, Dean Camera wrote:
> Currently the maximum HID report size which can be buffered by the
> kernel is 8KB. This is sufficient for the vast majority of HID
> devices on the market, as most HID reports are fairly small.
>
> However, some unusual devices such as the Elgate Stream Deck exist
> which use a report size slightly over 8KB for the image data that
> is sent to the device. Reports these large cannot be buffered by
> the regular HID subsystem currently, thus the only way to use such
> device is to bypass the HID subsystem entirely.
>
> This increases the maximum HID report size to 16KB, which should
> cover all sanely designed HID devices.
>
> Signed-off-by: Dean Camera <dean@fourwalledcubicle.com>
Dean,
thanks for the patch.
It has been whitespace-damaged by your mail client though. Could you
please fix that and resubmit?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices.
2020-11-25 13:12 ` [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices Jiri Kosina
@ 2020-11-25 22:26 ` Dean Camera
2020-11-25 22:42 ` Dean Camera
0 siblings, 1 reply; 4+ messages in thread
From: Dean Camera @ 2020-11-25 22:26 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input
Sure, I'll do that now (and do the same for my other unreviewed patch,
which adds additional ioctls(). It's suprisingly frustratingly difficult
to get Thunderbird to send a one-time unformatted plain-text email, as
it seems to be a global setting that has to be changed.
I've given up on that and just set up git-send-email, which I've never
used before but hope doesn't mangle anything.
Cheers!
- Dean
On 26/11/2020 12:12 am, Jiri Kosina wrote:
> On Wed, 18 Nov 2020, Dean Camera wrote:
>
>> Currently the maximum HID report size which can be buffered by the
>> kernel is 8KB. This is sufficient for the vast majority of HID
>> devices on the market, as most HID reports are fairly small.
>>
>> However, some unusual devices such as the Elgate Stream Deck exist
>> which use a report size slightly over 8KB for the image data that
>> is sent to the device. Reports these large cannot be buffered by
>> the regular HID subsystem currently, thus the only way to use such
>> device is to bypass the HID subsystem entirely.
>>
>> This increases the maximum HID report size to 16KB, which should
>> cover all sanely designed HID devices.
>>
>> Signed-off-by: Dean Camera <dean@fourwalledcubicle.com>
>
> Dean,
>
> thanks for the patch.
>
> It has been whitespace-damaged by your mail client though. Could you
> please fix that and resubmit?
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices.
2020-11-25 22:26 ` Dean Camera
@ 2020-11-25 22:42 ` Dean Camera
0 siblings, 0 replies; 4+ messages in thread
From: Dean Camera @ 2020-11-25 22:42 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input
Argh, and of course I forgot I hadn't added the requisite cover letter
and descriptions for those patches on that machine.
Sorry for the noise - I've sent V3 of both which should now be formatted
correctly, and have the correct description.
- Dean
On 26/11/2020 9:26 am, Dean Camera wrote:
> Sure, I'll do that now (and do the same for my other unreviewed patch,
> which adds additional ioctls(). It's suprisingly frustratingly difficult
> to get Thunderbird to send a one-time unformatted plain-text email, as
> it seems to be a global setting that has to be changed.
>
> I've given up on that and just set up git-send-email, which I've never
> used before but hope doesn't mangle anything.
>
> Cheers!
> - Dean
>
> On 26/11/2020 12:12 am, Jiri Kosina wrote:
>> On Wed, 18 Nov 2020, Dean Camera wrote:
>>
>>> Currently the maximum HID report size which can be buffered by the
>>> kernel is 8KB. This is sufficient for the vast majority of HID
>>> devices on the market, as most HID reports are fairly small.
>>>
>>> However, some unusual devices such as the Elgate Stream Deck exist
>>> which use a report size slightly over 8KB for the image data that
>>> is sent to the device. Reports these large cannot be buffered by
>>> the regular HID subsystem currently, thus the only way to use such
>>> device is to bypass the HID subsystem entirely.
>>>
>>> This increases the maximum HID report size to 16KB, which should
>>> cover all sanely designed HID devices.
>>>
>>> Signed-off-by: Dean Camera <dean@fourwalledcubicle.com>
>>
>> Dean,
>>
>> thanks for the patch.
>>
>> It has been whitespace-damaged by your mail client though. Could you
>> please fix that and resubmit?
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices.
@ 2020-11-19 5:55 Dean Camera
0 siblings, 0 replies; 4+ messages in thread
From: Dean Camera @ 2020-11-19 5:55 UTC (permalink / raw)
To: linux-input
Currently the maximum HID report size which can be buffered by the
kernel is 8KB. This is sufficient for the vast majority of HID
devices on the market, as most HID reports are fairly small.
However, some unusual devices such as the Elgate Stream Deck exist
which use a report size slightly over 8KB for the image data that
is sent to the device. Reports these large cannot be buffered by
the regular HID subsystem currently, thus the only way to use such
device is to bypass the HID subsystem entirely.
This increases the maximum HID report size to 16KB, which should
cover all sanely designed HID devices.
Signed-off-by: Dean Camera <dean@fourwalledcubicle.com>
---
include/linux/hid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 58684657960b..2faa7aba67ed 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -494,7 +494,7 @@ struct hid_report_enum {
};
#define HID_MIN_BUFFER_SIZE 64 /* make sure there is at least a
packet size of space */
-#define HID_MAX_BUFFER_SIZE 8192 /* 8kb */
+#define HID_MAX_BUFFER_SIZE 16384 /* 16kb */
#define HID_CONTROL_FIFO_SIZE 256 /* to init devices with >100 reports */
#define HID_OUTPUT_FIFO_SIZE 64
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-25 22:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <acdda6f0-3675-7e8b-b57c-711fe8199ce9@fourwalledcubicle.com>
2020-11-25 13:12 ` [PATCH 1/2] Increase HID_MAX_BUFFER_SIZE to 8KB to support additional, devices Jiri Kosina
2020-11-25 22:26 ` Dean Camera
2020-11-25 22:42 ` Dean Camera
2020-11-19 5:55 Dean Camera
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.