[PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Filipe Laíns]

From: Filipe Laíns <lains@riseup.net>

In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
receiver that comes with the G602 device, but unfortunately I screwed up
during testing and it seems the keyboard events were actually not being
sent to userspace.
This resulted in keyboard events being broken in userspace, please
backport the fix.

The receiver uses the normal 0x01 Logitech keyboard report descriptor,
as expected, so it is just a matter of flagging it as supported.

Reported in
https://github.com/libratbag/libratbag/issues/1124

Signed-off-by: Filipe Laíns <lains@riseup.net>
---
 drivers/hid/hid-logitech-dj.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 6596c81947a8..2703333edc34 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -981,6 +981,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
 	case 0x07:
 		device_type = "eQUAD step 4 Gaming";
 		logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
+		workitem.reports_supported |= STD_KEYBOARD;
 		break;
 	case 0x08:
 		device_type = "eQUAD step 4 for gamepads";
-- 
2.30.0

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Filipe Laíns]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

Hans,

You added support for non unifying receivers in
74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure
this cause any breakage with your devices?

AFAIK, they could only break if they have a 0x01 report which is different from
kbd_descriptor.

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Filipe Laíns]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

Oops

On Sat, 2021-01-30 at 19:14 +0000, Filipe Laíns wrote:
> this cause any breakage with your devices?

this *doesn't* cause

-- 
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Hans de Goede]

Hi,

On 1/30/21 8:14 PM, Filipe Laíns wrote:
> Hans,
> 
> You added support for non unifying receivers in
> 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure
> this cause any breakage with your devices?
> 
> AFAIK, they could only break if they have a 0x01 report which is different from
> kbd_descriptor.

I don't have any receivers hitting the "case 7" which you are modifying,
so I don't expect to see any effects of this change on my hw.

Regards,

Hans

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Filipe Laíns]

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Sat, 2021-01-30 at 21:27 +0100, Hans de Goede wrote:
> Hi,
> 
> On 1/30/21 8:14 PM, Filipe Laíns wrote:
> > Hans,
> > 
> > You added support for non unifying receivers in
> > 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make
> > sure
> > this cause any breakage with your devices?
> > 
> > AFAIK, they could only break if they have a 0x01 report which is different
> > from
> > kbd_descriptor.
> 
> I don't have any receivers hitting the "case 7" which you are modifying,
> so I don't expect to see any effects of this change on my hw.
> 
> Regards,
> 
> Hans
> 

Alright, then we should not have any other receivers that use this protocol.

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Jiri Kosina]

On Sat, 30 Jan 2021, Filipe Laíns wrote:

> From: Filipe Laíns <lains@riseup.net>
> 
> In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
> receiver that comes with the G602 device, but unfortunately I screwed up
> during testing and it seems the keyboard events were actually not being
> sent to userspace.
> This resulted in keyboard events being broken in userspace, please
> backport the fix.
> 
> The receiver uses the normal 0x01 Logitech keyboard report descriptor,
> as expected, so it is just a matter of flagging it as supported.
> 
> Reported in
> https://github.com/libratbag/libratbag/issues/1124
> 
> Signed-off-by: Filipe Laíns <lains@riseup.net>

Given this is a regression, could you please add proper Fixes: and Cc: 
stable tags?

Thank you,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming

[Filipe Laíns]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

On Fri, 2021-02-05 at 10:18 +0100, Jiri Kosina wrote:
> On Sat, 30 Jan 2021, Filipe Laíns wrote:
> 
> > From: Filipe Laíns <lains@riseup.net>
> > 
> > In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
> > receiver that comes with the G602 device, but unfortunately I screwed up
> > during testing and it seems the keyboard events were actually not being
> > sent to userspace.
> > This resulted in keyboard events being broken in userspace, please
> > backport the fix.
> > 
> > The receiver uses the normal 0x01 Logitech keyboard report descriptor,
> > as expected, so it is just a matter of flagging it as supported.
> > 
> > Reported in
> > https://github.com/libratbag/libratbag/issues/1124
> > 
> > Signed-off-by: Filipe Laíns <lains@riseup.net>
> 
> Given this is a regression, could you please add proper Fixes: and Cc: 
> stable tags?
> 
> Thank you,
> 

Done :)
Sorry about that, I am not yet familiarized with all steps of the workflow.

Cheers,
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]