All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dylan Reid <dgreid@chromium.org>
Cc: alsa-devel@alsa-project.org, Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c
Date: Thu, 27 Feb 2014 17:57:41 +0100	[thread overview]
Message-ID: <s5h1tyowl16.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAEUnVG7B6B7wD0xDSi87vZj=WKJdY8ZokQ1zUKz_vknL9e=UkQ@mail.gmail.com>

At Thu, 27 Feb 2014 08:44:48 -0800,
Dylan Reid wrote:
> 
> On Thu, Feb 27, 2014 at 4:03 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Wed, 19 Feb 2014 07:16:38 -0800,
> > Dylan Reid wrote:
> >>
> >> On Wed, Feb 19, 2014 at 12:33 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > At Tue, 18 Feb 2014 11:04:19 -0700,
> >> > Stephen Warren wrote:
> >> >>
> >> >> On 02/15/2014 02:22 AM, Takashi Iwai wrote:
> >> >> > At Sat, 15 Feb 2014 10:17:33 +0100,
> >> >> > Takashi Iwai wrote:
> >> >> >>
> >> >> >> The default parent device can be obtained directly via card object, so
> >> >> >> we don't need to rely on pci->dev.parent.  Since there is no access to
> >> >> >> pci_dev, we can reduce the inclusion of linux/pci.h, too.
> >> >> >>
> >> >> >> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >> >> >
> >> >> > I forgot the cover page: these tree patches are trivial cleanups of
> >> >> > hda-codec drivers (not the controller) to work without PCI device
> >> >> > assignment. The idea was triggered by Dylan's question.
> >> >>
> >> >> The series seems fine to me, so briefly,
> >> >> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> >> >
> >> > Thanks.  Any chance to work on / submit other changes for Tegra
> >> > HD-audio support?
> >>
> >> That's the plan, hopefully I'll be able to find time to throw together
> >> an RFC by the end of the week.
> >
> > Since there was no patch appearing yet, I merged my latest development
> > branch to for-next branch, which includes lots of changes in
> > hda_intel.c and hda_codec.c.  If any, please rebase your patches to
> > it.
> 
> Thanks for the heads up.  I've got a series that is almost ready, I'm
> still trying to tease part of the build out from under CONFIG_PCI in
> the hda makefile.

I don't think we have a dependency on CONFIG_PCI in Makefile.  Kconfig
has a dependency, but it can be easily reduced by a patch like below.

Of course, it'd be better to move the whole hda directory out of pci,
but we can do it later at any time once via git.

>  I'll try to button that up and get a the whole lot
> rebased on top of the for-next branch.

Thanks!


Takashi

---
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index 8756c8e32922..56d93bf45025 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -578,8 +578,6 @@ config SND_FM801_TEA575X_BOOL
 	  FM801 chip with a TEA5757 tuner (MediaForte SF256-PCS, SF256-PCP and
 	  SF64-PCR) into the snd-fm801 driver.
 
-source "sound/pci/hda/Kconfig"
-
 config SND_HDSP
 	tristate "RME Hammerfall DSP Audio"
 	select FW_LOADER
@@ -889,3 +887,5 @@ config SND_YMFPCI
 	  will be called snd-ymfpci.
 
 endif	# SND_PCI
+
+source "sound/pci/hda/Kconfig"
diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index f2032dd7e35e..6fc769da6949 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -1,5 +1,6 @@
 menuconfig SND_HDA_INTEL
 	tristate "Intel HD Audio"
+	depends on (PCI || SOMETHING_YOU_WANT)
 	select SND_PCM
 	select SND_VMASTER
 	select SND_KCTL_JACK

  reply	other threads:[~2014-02-27 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15  9:17 Takashi Iwai
2014-02-15  9:17 ` [PATCH 2/3] ALSA: hda/realtek - Allow NULL bus->pci Takashi Iwai
2014-02-15  9:17 ` [PATCH 3/3] ALSA: hda - Remove superfluous inclusion of linux/pci.h Takashi Iwai
2014-02-15  9:22 ` [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c Takashi Iwai
2014-02-18 18:04   ` Stephen Warren
2014-02-18 18:20     ` Dylan Reid
2014-02-19  8:33     ` Takashi Iwai
2014-02-19 15:16       ` Dylan Reid
2014-02-27 12:03         ` Takashi Iwai
2014-02-27 16:44           ` Dylan Reid
2014-02-27 16:57             ` Takashi Iwai [this message]
2014-02-27 17:32               ` Dylan Reid
2014-02-27 20:10                 ` Takashi Iwai
2014-02-27 20:41                   ` Dylan Reid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1tyowl16.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dgreid@chromium.org \
    --cc=swarren@wwwdotorg.org \
    --subject='Re: [PATCH 1/3] ALSA: hda - Remove dependency on bus->pci in hda_beep.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.