patch to support Samsung NC10 mini notebook

patch to support Samsung NC10 mini notebook

[Chris Pockele]

[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]

Hello,

The attached file is a patch to support the sound hardware in the
Samsung NC10 mini notebook.
The Samsung NC10 is and Intel Atom-based notebook with Realtek ALC272
HDA codecs.
Sound is supported partly in Linux depending on ALSA version, but
there were always some issues (wrong mixer behaviour, PC beep always
muted, ...). This patch tries to solve most of these issues.
I updated the patch so it would work using the alsa-driver-20090509
snapshot from ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
(originally developed from alsa-driver-20090416 snapshot).

Fixes:
 - mute internal speaker / microphone when plugging in external
headphone / microphone
 - stereo capture from external microphone
 - separate volume controls for headphone and internal speakers +
"Master" for both
 - "PC Beep" mixer control
 - "Mic boost" and "External mic boost" controls
 - ...

A few issues remaining:
 - Recording PCM output does not work yet. It works on the version of
Windows that comes with the NC10.
 - When choosing recording source "Internal Mic" while an external
microphone is plugged in, the internal microphone will be used instead
of the external one, as it should. However, when plugging in the
external microphone after choosing the recording source setting, it
WILL override the internal microphone.

When replying, please note I am not on list.

Regards,
Chris
http://users.skynet.be/chrisp/linux/

[-- Attachment #2: alsa20090509-add-nc10-support.patch --]
[-- Type: text/x-patch, Size: 3481 bytes --]

diff -ru alsa-driver/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c
--- alsa-driver/alsa-kernel/pci/hda/patch_realtek.c	2009-05-09 00:05:02.000000000 +0200
+++ alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c	2009-05-10 13:07:22.000000000 +0200
@@ -190,6 +190,7 @@
 	ALC663_ASUS_MODE6,
 	ALC272_DELL,
 	ALC272_DELL_ZM1,
+	ALC272_SAMSUNG_NC10,	/*20090509 Samsung NC10 support - chris.pockele.f1@gmail.com*/
 	ALC662_AUTO,
 	ALC662_MODEL_LAST,
 };
@@ -15120,6 +15121,38 @@
 	},
 };
 
+#ifndef CONFIG_SND_DEBUG
+static struct hda_input_mux alc272_nc10_capture_source = {
+	.num_items = 2,
+	.items = {
+		{ "Autoselect Mic", 0x0 },
+		{ "Internal Mic", 0x1 },
+	},
+};
+#else
+static struct hda_input_mux alc272_nc10_capture_source = {
+	.num_items = 16,
+	.items = {
+		{ "Autoselect Mic", 0x0 },
+		{ "Internal Mic", 0x1 },
+		{ "In-0x02", 0x2 },
+		{ "In-0x03", 0x3 },
+		{ "In-0x04", 0x4 },
+		{ "In-0x05", 0x5 },
+		{ "In-0x06", 0x6 },
+		{ "In-0x07", 0x7 },
+		{ "In-0x08", 0x8 },
+		{ "In-0x09", 0x9 },
+		{ "In-0x0a", 0x0a },
+		{ "In-0x0b", 0x0b },
+		{ "In-0x0c", 0x0c },
+		{ "In-0x0d", 0x0d },
+		{ "In-0x0e", 0x0e },
+		{ "In-0x0f", 0x0f },
+	},
+};
+#endif
+
 /*
  * 2ch mode
  */
@@ -16151,6 +16184,23 @@
 	{ } /* end */
 };
 
+static struct snd_kcontrol_new alc272_nc10_mixer[] = {
+	/* Master Playback automatically created from Speaker and Headphone */
+	HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
+	HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT),
+	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
+	HDA_CODEC_MUTE("Headphone Playback Switch", 0x21, 0x0, HDA_OUTPUT),
+
+	HDA_CODEC_VOLUME("Ext Mic Playback Volume", 0x0b, 0x0, HDA_INPUT),
+	HDA_CODEC_MUTE("Ext Mic Playback Switch", 0x0b, 0x0, HDA_INPUT),
+	HDA_CODEC_VOLUME("Ext Mic Boost Playback Volume", 0x18, 0, HDA_INPUT),
+
+	HDA_CODEC_VOLUME("Int Mic Playback Volume", 0x0b, 0x1, HDA_INPUT),
+	HDA_CODEC_MUTE("Int Mic Playback Switch", 0x0b, 0x1, HDA_INPUT),
+	HDA_CODEC_VOLUME("Int Mic Boost Playback Volume", 0x19, 0, HDA_INPUT),
+	{ } /* end */
+};
+
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 #define alc662_loopbacks	alc880_loopbacks
 #endif
@@ -16184,6 +16234,9 @@
 	[ALC663_ASUS_MODE4] = "asus-mode4",
 	[ALC663_ASUS_MODE5] = "asus-mode5",
 	[ALC663_ASUS_MODE6] = "asus-mode6",
+	[ALC272_DELL] = "dell272",
+	[ALC272_DELL_ZM1] = "dell-zm1",
+	[ALC272_SAMSUNG_NC10] = "samsung-nc10",
 	[ALC662_AUTO]		= "auto",
 };
 
@@ -16241,6 +16294,7 @@
 	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
 	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
 		      ALC662_3ST_6ch_DIG),
+	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
 		      ALC662_3ST_6ch_DIG),
 	SND_PCI_QUIRK(0x1565, 0x820f, "Biostar TA780G M2+", ALC662_3ST_6ch_DIG),
@@ -16512,6 +16566,18 @@
 		.unsol_event = alc663_m51va_unsol_event,
 		.init_hook = alc663_m51va_inithook,
 	},
+	[ALC272_SAMSUNG_NC10] = {
+		.mixers = { alc272_nc10_mixer },
+		.init_verbs = { alc662_init_verbs,
+				alc663_21jd_amic_init_verbs },
+		.num_dacs = ARRAY_SIZE(alc272_dac_nids),
+		.dac_nids = alc272_dac_nids,
+		.num_channel_mode = ARRAY_SIZE(alc662_3ST_2ch_modes),
+		.channel_mode = alc662_3ST_2ch_modes,
+		.input_mux = &alc272_nc10_capture_source,
+		.unsol_event = alc663_mode4_unsol_event,
+		.init_hook = alc663_mode4_inithook,
+	},
 };


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: patch to support Samsung NC10 mini notebook

[Takashi Iwai]

At Sun, 10 May 2009 21:21:33 +0200,
Chris Pockele wrote:
> 
> Hello,
> 
> The attached file is a patch to support the sound hardware in the
> Samsung NC10 mini notebook.
> The Samsung NC10 is and Intel Atom-based notebook with Realtek ALC272
> HDA codecs.
> Sound is supported partly in Linux depending on ALSA version, but
> there were always some issues (wrong mixer behaviour, PC beep always
> muted, ...). This patch tries to solve most of these issues.
> I updated the patch so it would work using the alsa-driver-20090509
> snapshot from ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/
> (originally developed from alsa-driver-20090416 snapshot).

Thanks for the patch!
After a brief look, the changes look good.  But there are some issues
to be fixed.  See some comments below.

> Fixes:
>  - mute internal speaker / microphone when plugging in external
> headphone / microphone
>  - stereo capture from external microphone
>  - separate volume controls for headphone and internal speakers +
> "Master" for both
>  - "PC Beep" mixer control
>  - "Mic boost" and "External mic boost" controls
>  - ...
> 
> A few issues remaining:
>  - Recording PCM output does not work yet. It works on the version of
> Windows that comes with the NC10.
>  - When choosing recording source "Internal Mic" while an external
> microphone is plugged in, the internal microphone will be used instead
> of the external one, as it should. However, when plugging in the
> external microphone after choosing the recording source setting, it
> WILL override the internal microphone.

First off, please give a text as a change log together with your
sign-off so that the patch can be merged to the upstream.


> diff -ru alsa-driver/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c
> --- alsa-driver/alsa-kernel/pci/hda/patch_realtek.c	2009-05-09 00:05:02.000000000 +0200
> +++ alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c	2009-05-10 13:07:22.000000000 +0200
> @@ -190,6 +190,7 @@
>  	ALC663_ASUS_MODE6,
>  	ALC272_DELL,
>  	ALC272_DELL_ZM1,
> +	ALC272_SAMSUNG_NC10,	/*20090509 Samsung NC10 support - chris.pockele.f1@gmail.com*/

This kind of comment isn't needed because we track all changes via GIT.

> +#ifndef CONFIG_SND_DEBUG
> +static struct hda_input_mux alc272_nc10_capture_source = {
> +	.num_items = 2,
> +	.items = {
> +		{ "Autoselect Mic", 0x0 },
> +		{ "Internal Mic", 0x1 },
> +	},
> +};
> +#else
> +static struct hda_input_mux alc272_nc10_capture_source = {

CONFIG_SND_DEBUG is set on some distros as default, so the driver
shouldn't change the fundamental behavior by that option.
If you'd like to keep the test code, just comment out with some other
ifdef.   Even an ifdef 0 with a comment would be OK.


> +static struct snd_kcontrol_new alc272_nc10_mixer[] = {
> +	/* Master Playback automatically created from Speaker and Headphone */
> +	HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_MUTE("Headphone Playback Switch", 0x21, 0x0, HDA_OUTPUT),
> +
> +	HDA_CODEC_VOLUME("Ext Mic Playback Volume", 0x0b, 0x0, HDA_INPUT),
> +	HDA_CODEC_MUTE("Ext Mic Playback Switch", 0x0b, 0x0, HDA_INPUT),
> +	HDA_CODEC_VOLUME("Ext Mic Boost Playback Volume", 0x18, 0, HDA_INPUT),

The mic boost is for both playback and capture.  Thus, simply name it as
"... Mic Boost".

> +	HDA_CODEC_VOLUME("Int Mic Playback Volume", 0x0b, 0x1, HDA_INPUT),
> +	HDA_CODEC_MUTE("Int Mic Playback Switch", 0x0b, 0x1, HDA_INPUT),
> +	HDA_CODEC_VOLUME("Int Mic Boost Playback Volume", 0x19, 0, HDA_INPUT),

Ditto.

> +};
> +
>  #ifdef CONFIG_SND_HDA_POWER_SAVE
>  #define alc662_loopbacks	alc880_loopbacks
>  #endif
> @@ -16184,6 +16234,9 @@
>  	[ALC663_ASUS_MODE4] = "asus-mode4",
>  	[ALC663_ASUS_MODE5] = "asus-mode5",
>  	[ALC663_ASUS_MODE6] = "asus-mode6",
> +	[ALC272_DELL] = "dell272",
> +	[ALC272_DELL_ZM1] = "dell-zm1",

These models have been already added pretty recently.
Please rebase your patch with the latest snapshot.


> +	[ALC272_SAMSUNG_NC10] = "samsung-nc10",

Also, don't forget to update
Documentation/sound/alsa/HD-Audio-Models.txt, too.


Could you fix the issues above and repost?

thanks,

Takashi

Re: patch to support Samsung NC10 mini notebook

[Chris Pockele]

[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]

On Mon, May 11, 2009 at 10:38 AM, Takashi Iwai <tiwai@suse.de> wrote:
>
> First off, please give a text as a change log together with your
> sign-off so that the patch can be merged to the upstream.

Here it is:
=====
Add specific configuration for Samsung NC10 mini notebook.  Internal
mic/speakers will be correctly muted when plugging in external ones.
Mixer controls are added for speakers, headphones and PC beep.
"Boost" is added for the microphones.
Signed-off-by: Chris Pockelé <chris.pockele.f1@gmail.com >
=====


>...
> This kind of comment isn't needed because we track all changes via GIT.
>
It's gone now.

> If you'd like to keep the test code, just comment out with some other
> ifdef.   Even an ifdef 0 with a comment would be OK.
>
Ok, did that.

...
>> +     HDA_CODEC_VOLUME("Ext Mic Boost Playback Volume", 0x18, 0, HDA_INPUT),
>
> The mic boost is for both playback and capture.  Thus, simply name it as
> "... Mic Boost".
>
>> +     HDA_CODEC_VOLUME("Int Mic Playback Volume", 0x0b, 0x1, HDA_INPUT),
>> +     HDA_CODEC_MUTE("Int Mic Playback Switch", 0x0b, 0x1, HDA_INPUT),
>> +     HDA_CODEC_VOLUME("Int Mic Boost Playback Volume", 0x19, 0, HDA_INPUT),
>
> Ditto.
>
Changed the names.

>>       [ALC663_ASUS_MODE6] = "asus-mode6",
>> +     [ALC272_DELL] = "dell272",
>> +     [ALC272_DELL_ZM1] = "dell-zm1",
>
> These models have been already added pretty recently.
> Please rebase your patch with the latest snapshot.
>
I rebased using 20090509 snapshot before sending the patch (I checked
out today's snapshot too - patch_realtek.c hasn't changed), and those
models were there indeed.  However, I wanted to try those
configurations but I couldn't use the model= option because the
configurations were not in the alc662_models array.  That's why I
added these 2 lines, and it got through to the patch.  I removed them
for now, as that should probably be another patch.

>
>> +     [ALC272_SAMSUNG_NC10] = "samsung-nc10",
>
> Also, don't forget to update
> Documentation/sound/alsa/HD-Audio-Models.txt, too.
>
>
> Could you fix the issues above and repost?
>
The attached version fixes all issues you mentioned.

Regards,
Chris

[-- Attachment #2: alsa20090509-add-nc10-support-v2.patch --]
[-- Type: text/x-patch, Size: 4384 bytes --]

diff -pru alsa-driver/alsa-kernel/Documentation/HD-Audio-Models.txt alsa-driver-20090509-MOD/alsa-kernel/Documentation/HD-Audio-Models.txt
--- alsa-driver/alsa-kernel/Documentation/HD-Audio-Models.txt	2009-05-09 00:05:01.000000000 +0200
+++ alsa-driver-20090509-MOD/alsa-kernel/Documentation/HD-Audio-Models.txt	2009-05-11 21:05:04.000000000 +0200
@@ -87,8 +87,8 @@ ALC269
   fujitsu	FSC Amilo
   auto		auto-config reading BIOS (default)
 
-ALC662/663
-==========
+ALC662/663/272
+==============
   3stack-dig	3-stack (2-channel) with SPDIF
   3stack-6ch	 3-stack (6-channel)
   3stack-6ch-dig 3-stack (6-channel) with SPDIF
@@ -107,6 +107,7 @@ ALC662/663
   asus-mode4	ASUS
   asus-mode5	ASUS
   asus-mode6	ASUS
+  samsung-nc10	Samsung NC10 mini notebook
   auto		auto-config reading BIOS (default)
 
 ALC882/885
diff -pru alsa-driver/alsa-kernel/pci/hda/patch_realtek.c alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c
--- alsa-driver/alsa-kernel/pci/hda/patch_realtek.c	2009-05-09 00:05:02.000000000 +0200
+++ alsa-driver-20090509-MOD/alsa-kernel/pci/hda/patch_realtek.c	2009-05-11 21:01:36.000000000 +0200
@@ -190,6 +190,7 @@ enum {
 	ALC663_ASUS_MODE6,
 	ALC272_DELL,
 	ALC272_DELL_ZM1,
+	ALC272_SAMSUNG_NC10,
 	ALC662_AUTO,
 	ALC662_MODEL_LAST,
 };
@@ -15120,6 +15121,38 @@ static struct hda_input_mux alc663_m51va
 	},
 };
 
+#if 1 /* set to 0 for testing other input sources below */
+static struct hda_input_mux alc272_nc10_capture_source = {
+	.num_items = 2,
+	.items = {
+		{ "Autoselect Mic", 0x0 },
+		{ "Internal Mic", 0x1 },
+	},
+};
+#else
+static struct hda_input_mux alc272_nc10_capture_source = {
+	.num_items = 16,
+	.items = {
+		{ "Autoselect Mic", 0x0 },
+		{ "Internal Mic", 0x1 },
+		{ "In-0x02", 0x2 },
+		{ "In-0x03", 0x3 },
+		{ "In-0x04", 0x4 },
+		{ "In-0x05", 0x5 },
+		{ "In-0x06", 0x6 },
+		{ "In-0x07", 0x7 },
+		{ "In-0x08", 0x8 },
+		{ "In-0x09", 0x9 },
+		{ "In-0x0a", 0x0a },
+		{ "In-0x0b", 0x0b },
+		{ "In-0x0c", 0x0c },
+		{ "In-0x0d", 0x0d },
+		{ "In-0x0e", 0x0e },
+		{ "In-0x0f", 0x0f },
+	},
+};
+#endif
+
 /*
  * 2ch mode
  */
@@ -16151,6 +16184,23 @@ static struct snd_kcontrol_new alc662_ec
 	{ } /* end */
 };
 
+static struct snd_kcontrol_new alc272_nc10_mixer[] = {
+	/* Master Playback automatically created from Speaker and Headphone */
+	HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
+	HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT),
+	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
+	HDA_CODEC_MUTE("Headphone Playback Switch", 0x21, 0x0, HDA_OUTPUT),
+
+	HDA_CODEC_VOLUME("Ext Mic Playback Volume", 0x0b, 0x0, HDA_INPUT),
+	HDA_CODEC_MUTE("Ext Mic Playback Switch", 0x0b, 0x0, HDA_INPUT),
+	HDA_CODEC_VOLUME("Ext Mic Boost", 0x18, 0, HDA_INPUT),
+
+	HDA_CODEC_VOLUME("Int Mic Playback Volume", 0x0b, 0x1, HDA_INPUT),
+	HDA_CODEC_MUTE("Int Mic Playback Switch", 0x0b, 0x1, HDA_INPUT),
+	HDA_CODEC_VOLUME("Int Mic Boost", 0x19, 0, HDA_INPUT),
+	{ } /* end */
+};
+
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 #define alc662_loopbacks	alc880_loopbacks
 #endif
@@ -16184,6 +16234,7 @@ static const char *alc662_models[ALC662_
 	[ALC663_ASUS_MODE4] = "asus-mode4",
 	[ALC663_ASUS_MODE5] = "asus-mode5",
 	[ALC663_ASUS_MODE6] = "asus-mode6",
+	[ALC272_SAMSUNG_NC10] = "samsung-nc10",
 	[ALC662_AUTO]		= "auto",
 };
 
@@ -16241,6 +16292,7 @@ static struct snd_pci_quirk alc662_cfg_t
 	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
 	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
 		      ALC662_3ST_6ch_DIG),
+	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
 		      ALC662_3ST_6ch_DIG),
 	SND_PCI_QUIRK(0x1565, 0x820f, "Biostar TA780G M2+", ALC662_3ST_6ch_DIG),
@@ -16512,6 +16564,18 @@ static struct alc_config_preset alc662_p
 		.unsol_event = alc663_m51va_unsol_event,
 		.init_hook = alc663_m51va_inithook,
 	},
+	[ALC272_SAMSUNG_NC10] = {
+		.mixers = { alc272_nc10_mixer },
+		.init_verbs = { alc662_init_verbs,
+				alc663_21jd_amic_init_verbs },
+		.num_dacs = ARRAY_SIZE(alc272_dac_nids),
+		.dac_nids = alc272_dac_nids,
+		.num_channel_mode = ARRAY_SIZE(alc662_3ST_2ch_modes),
+		.channel_mode = alc662_3ST_2ch_modes,
+		.input_mux = &alc272_nc10_capture_source,
+		.unsol_event = alc663_mode4_unsol_event,
+		.init_hook = alc663_mode4_inithook,
+	},
 };


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: patch to support Samsung NC10 mini notebook

[Takashi Iwai]

At Mon, 11 May 2009 22:25:14 +0200,
Chris Pockele wrote:
> 
> >>       [ALC663_ASUS_MODE6] = "asus-mode6",
> >> +     [ALC272_DELL] = "dell272",
> >> +     [ALC272_DELL_ZM1] = "dell-zm1",
> >
> > These models have been already added pretty recently.
> > Please rebase your patch with the latest snapshot.
> >
> I rebased using 20090509 snapshot before sending the patch (I checked
> out today's snapshot too - patch_realtek.c hasn't changed), and those
> models were there indeed.  However, I wanted to try those
> configurations but I couldn't use the model= option because the
> configurations were not in the alc662_models array.  That's why I
> added these 2 lines, and it got through to the patch.  I removed them
> for now, as that should probably be another patch.

Hm, the model strings should have been there, at least, in
alsa-driver-snapshot.tar.gz.  The snapshot.tar.gz is always the latest
tarball.  Anyway, the change is trivial, so I fixed manually.

> >> +     [ALC272_SAMSUNG_NC10] = "samsung-nc10",
> >
> > Also, don't forget to update
> > Documentation/sound/alsa/HD-Audio-Models.txt, too.
> >
> >
> > Could you fix the issues above and repost?
> >
> The attached version fixes all issues you mentioned.

Thanks!  Now applied to sound git tree.


Takashi

Re: patch to support Samsung NC10 mini notebook

[Takashi Iwai]

At Tue, 12 May 2009 08:13:12 +0200,
I wrote:
> > >
> > > Could you fix the issues above and repost?
> > >
> > The attached version fixes all issues you mentioned.
> 
> Thanks!  Now applied to sound git tree.

BTW, could you give alsa-info.sh output (run with --no-upload option)
on this machine?  Just wonder why the default model=auto doesn't
work.


thanks,

Takashi