From: Takashi Iwai <tiwai@suse.de>
To: " Gustavo A. R. Silva " <gustavo@embeddedor.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: Use struct_size() helper
Date: Fri, 24 May 2019 07:55:21 +0200 [thread overview]
Message-ID: <s5h36l4flbq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190523202917.GA12595@embeddedor>
On Thu, 23 May 2019 22:29:17 +0200,
Gustavo A. R. Silva wrote:
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, replace the following form:
>
> sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel)
>
> with:
>
> struct_size(data, channels, src_format->channels)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied now, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: " Gustavo A. R. Silva " <gustavo@embeddedor.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: Use struct_size() helper
Date: Fri, 24 May 2019 07:55:21 +0200 [thread overview]
Message-ID: <s5h36l4flbq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190523202917.GA12595@embeddedor>
On Thu, 23 May 2019 22:29:17 +0200,
Gustavo A. R. Silva wrote:
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, replace the following form:
>
> sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel)
>
> with:
>
> struct_size(data, channels, src_format->channels)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied now, thanks.
Takashi
next prev parent reply other threads:[~2019-05-24 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 20:29 [PATCH] ALSA: Use struct_size() helper Gustavo A. R. Silva
2019-05-24 5:55 ` Takashi Iwai [this message]
2019-05-24 5:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36l4flbq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.