From: Takashi Iwai <tiwai@suse.de>
To: "kbuild test robot" <lkp@intel.com>
Cc: "Ruslan Bilovol" <ruslan.bilovol@gmail.com>, <kbuild-all@01.org>,
<alsa-devel@alsa-project.org>,
"Jorge" <jorge.sanjuan@codethink.co.uk>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support
Date: Mon, 19 Mar 2018 17:20:30 +0100 [thread overview]
Message-ID: <s5h370wvxyp.wl-tiwai@suse.de> (raw)
In-Reply-To: <201803192103.TpMCRTC7%fengguang.wu@intel.com>
On Mon, 19 Mar 2018 14:43:29 +0100,
kbuild test robot wrote:
>
> Hi Ruslan,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.16-rc6 next-20180316]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/ALSA-usb-audio-move-audioformat-quirks-to-quirks-c/20180319-205541
> config: i386-randconfig-x016-201811 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
> http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
>
> All warnings (new ones prefixed by >>):
>
> sound/usb/stream.c: In function 'snd_usb_parse_audio_interface':
> >> sound/usb/stream.c:956:8: warning: 'fmt' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (snd_usb_parse_audio_format(chip, fp, format,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fmt, stream) < 0) {
> ~~~~~~~~~~~~
Hm, this looks like a false-postive, although I see it on my local
build, too.
I'm not always a fan of unneeded initialization, but this time, we can
be lazy and add a NULL initialization...
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: kbuild test robot <lkp@intel.com>
Cc: alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org,
Jorge <jorge.sanjuan@codethink.co.uk>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
kbuild-all@01.org
Subject: Re: [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support
Date: Mon, 19 Mar 2018 17:20:30 +0100 [thread overview]
Message-ID: <s5h370wvxyp.wl-tiwai@suse.de> (raw)
In-Reply-To: <201803192103.TpMCRTC7%fengguang.wu@intel.com>
On Mon, 19 Mar 2018 14:43:29 +0100,
kbuild test robot wrote:
>
> Hi Ruslan,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.16-rc6 next-20180316]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/ALSA-usb-audio-move-audioformat-quirks-to-quirks-c/20180319-205541
> config: i386-randconfig-x016-201811 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
> http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
>
> All warnings (new ones prefixed by >>):
>
> sound/usb/stream.c: In function 'snd_usb_parse_audio_interface':
> >> sound/usb/stream.c:956:8: warning: 'fmt' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (snd_usb_parse_audio_format(chip, fp, format,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fmt, stream) < 0) {
> ~~~~~~~~~~~~
Hm, this looks like a false-postive, although I see it on my local
build, too.
I'm not always a fan of unneeded initialization, but this time, we can
be lazy and add a NULL initialization...
thanks,
Takashi
next prev parent reply other threads:[~2018-03-19 16:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 1:46 [PATCH v2 0/2] USB Audio Device Class 3.0 support Ruslan Bilovol
2018-03-19 1:46 ` Ruslan Bilovol
2018-03-19 1:46 ` [PATCH v2 1/2] ALSA: usb-audio: move audioformat quirks to quirks.c Ruslan Bilovol
2018-03-19 1:46 ` Ruslan Bilovol
2018-03-19 16:00 ` Takashi Iwai
2018-03-19 16:00 ` Takashi Iwai
2018-03-19 23:42 ` Ruslan Bilovol
2018-03-19 1:46 ` [PATCH v2 2/2] ALSA: usb: initial USB Audio Device Class 3.0 support Ruslan Bilovol
2018-03-19 1:46 ` Ruslan Bilovol
2018-03-19 13:43 ` kbuild test robot
2018-03-19 16:20 ` Takashi Iwai [this message]
2018-03-19 16:20 ` Takashi Iwai
2018-03-19 16:28 ` Takashi Iwai
2018-03-19 16:28 ` Takashi Iwai
2018-03-19 17:14 ` Greg Kroah-Hartman
2018-03-19 17:14 ` Greg Kroah-Hartman
2018-03-19 23:57 ` Ruslan Bilovol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h370wvxyp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=jorge.sanjuan@codethink.co.uk \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ruslan.bilovol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.