From: Takashi Iwai <tiwai@suse.de> To: Hui Wang <hui.wang@canonical.com> Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table Date: Thu, 07 Jul 2016 07:35:26 +0200 [thread overview] Message-ID: <s5h37nmm2n5.wl-tiwai@suse.de> (raw) In-Reply-To: <577DBF4C.3030201@canonical.com> On Thu, 07 Jul 2016 04:32:44 +0200, Hui Wang wrote: > > Please skip this patch, we have more pins to add into this pin quirk > table (for new machines). OK. thanks, Takashi > On 07/06/2016 11:49 AM, Hui Wang wrote: > > We have some Dell laptops which can't detect headset mic, the machines > > use the codec ALC225, they have some new pin configuration values, > > after adding them in the alc225 pin quirk table, they work well. > > > > Cc: <stable@vger.kernel.org> > > Signed-off-by: Hui Wang <hui.wang@canonical.com> > > --- > > sound/pci/hda/patch_realtek.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 45d4dc1..e25ef2b 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > > {} > > }; > > #define ALC225_STANDARD_PINS \ > > - {0x12, 0xb7a60130}, \ > > {0x21, 0x04211020} > > #define ALC256_STANDARD_PINS \ > > @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > > static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { > > SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60130}, > > {0x14, 0x901701a0}), > > SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60130}, > > + {0x14, 0x901701b0}), > > + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > + ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60150}, > > + {0x14, 0x901701a0}), > > + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > + ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60150}, > > {0x14, 0x901701b0}), > > SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, > > {0x14, 0x90170110}, >
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Hui Wang <hui.wang@canonical.com> Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table Date: Thu, 07 Jul 2016 07:35:26 +0200 [thread overview] Message-ID: <s5h37nmm2n5.wl-tiwai@suse.de> (raw) In-Reply-To: <577DBF4C.3030201@canonical.com> On Thu, 07 Jul 2016 04:32:44 +0200, Hui Wang wrote: > > Please skip this patch, we have more pins to add into this pin quirk > table (for new machines). OK. thanks, Takashi > On 07/06/2016 11:49 AM, Hui Wang wrote: > > We have some Dell laptops which can't detect headset mic, the machines > > use the codec ALC225, they have some new pin configuration values, > > after adding them in the alc225 pin quirk table, they work well. > > > > Cc: <stable@vger.kernel.org> > > Signed-off-by: Hui Wang <hui.wang@canonical.com> > > --- > > sound/pci/hda/patch_realtek.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 45d4dc1..e25ef2b 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > > {} > > }; > > #define ALC225_STANDARD_PINS \ > > - {0x12, 0xb7a60130}, \ > > {0x21, 0x04211020} > > #define ALC256_STANDARD_PINS \ > > @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > > static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { > > SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60130}, > > {0x14, 0x901701a0}), > > SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60130}, > > + {0x14, 0x901701b0}), > > + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > + ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60150}, > > + {0x14, 0x901701a0}), > > + SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > + ALC225_STANDARD_PINS, > > + {0x12, 0xb7a60150}, > > {0x14, 0x901701b0}), > > SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE, > > {0x14, 0x90170110}, >
next prev parent reply other threads:[~2016-07-07 5:35 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-06 3:49 [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table Hui Wang 2016-07-07 2:32 ` [alsa-devel] " Hui Wang 2016-07-07 5:35 ` Takashi Iwai [this message] 2016-07-07 5:35 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5h37nmm2n5.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=hui.wang@canonical.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.