All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table
@ 2016-07-06  3:49 Hui Wang
  2016-07-07  2:32 ` [alsa-devel] " Hui Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Hui Wang @ 2016-07-06  3:49 UTC (permalink / raw)
  To: tiwai, alsa-devel; +Cc: stable, hui.wang

We have some Dell laptops which can't detect headset mic, the machines
use the codec ALC225, they have some new pin configuration values,
after adding them in the alc225 pin quirk table, they work well.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 45d4dc1..e25ef2b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{}
 };
 #define ALC225_STANDARD_PINS \
-	{0x12, 0xb7a60130}, \
 	{0x21, 0x04211020}
 
 #define ALC256_STANDARD_PINS \
@@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60130},
 		{0x14, 0x901701a0}),
 	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
 		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60130},
+		{0x14, 0x901701b0}),
+	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60150},
+		{0x14, 0x901701a0}),
+	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+		ALC225_STANDARD_PINS,
+		{0x12, 0xb7a60150},
 		{0x14, 0x901701b0}),
 	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
 		{0x14, 0x90170110},
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table
  2016-07-06  3:49 [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table Hui Wang
@ 2016-07-07  2:32 ` Hui Wang
  2016-07-07  5:35     ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Hui Wang @ 2016-07-07  2:32 UTC (permalink / raw)
  To: tiwai, alsa-devel; +Cc: stable

Please skip this patch, we have more pins to add into this pin quirk 
table (for new machines).

On 07/06/2016 11:49 AM, Hui Wang wrote:
> We have some Dell laptops which can't detect headset mic, the machines
> use the codec ALC225, they have some new pin configuration values,
> after adding them in the alc225 pin quirk table, they work well.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 45d4dc1..e25ef2b 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>   	{}
>   };
>   #define ALC225_STANDARD_PINS \
> -	{0x12, 0xb7a60130}, \
>   	{0x21, 0x04211020}
>   
>   #define ALC256_STANDARD_PINS \
> @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>   static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>   		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60130},
>   		{0x14, 0x901701a0}),
>   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
>   		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60130},
> +		{0x14, 0x901701b0}),
> +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60150},
> +		{0x14, 0x901701a0}),
> +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		ALC225_STANDARD_PINS,
> +		{0x12, 0xb7a60150},
>   		{0x14, 0x901701b0}),
>   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
>   		{0x14, 0x90170110},


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [alsa-devel] [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table
  2016-07-07  2:32 ` [alsa-devel] " Hui Wang
@ 2016-07-07  5:35     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2016-07-07  5:35 UTC (permalink / raw)
  To: Hui Wang; +Cc: alsa-devel, stable

On Thu, 07 Jul 2016 04:32:44 +0200,
Hui Wang wrote:
> 
> Please skip this patch, we have more pins to add into this pin quirk
> table (for new machines).

OK.


thanks,

Takashi

> On 07/06/2016 11:49 AM, Hui Wang wrote:
> > We have some Dell laptops which can't detect headset mic, the machines
> > use the codec ALC225, they have some new pin configuration values,
> > after adding them in the alc225 pin quirk table, they work well.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Hui Wang <hui.wang@canonical.com>
> > ---
> >   sound/pci/hda/patch_realtek.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 45d4dc1..e25ef2b 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   	{}
> >   };
> >   #define ALC225_STANDARD_PINS \
> > -	{0x12, 0xb7a60130}, \
> >   	{0x21, 0x04211020}
> >     #define ALC256_STANDARD_PINS \
> > @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> >   		{0x14, 0x901701a0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> > +		{0x14, 0x901701b0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> > +		{0x14, 0x901701a0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> >   		{0x14, 0x901701b0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
> >   		{0x14, 0x90170110},
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table
@ 2016-07-07  5:35     ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2016-07-07  5:35 UTC (permalink / raw)
  To: Hui Wang; +Cc: alsa-devel, stable

On Thu, 07 Jul 2016 04:32:44 +0200,
Hui Wang wrote:
> 
> Please skip this patch, we have more pins to add into this pin quirk
> table (for new machines).

OK.


thanks,

Takashi

> On 07/06/2016 11:49 AM, Hui Wang wrote:
> > We have some Dell laptops which can't detect headset mic, the machines
> > use the codec ALC225, they have some new pin configuration values,
> > after adding them in the alc225 pin quirk table, they work well.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Hui Wang <hui.wang@canonical.com>
> > ---
> >   sound/pci/hda/patch_realtek.c | 11 ++++++++++-
> >   1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 45d4dc1..e25ef2b 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5753,7 +5753,6 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   	{}
> >   };
> >   #define ALC225_STANDARD_PINS \
> > -	{0x12, 0xb7a60130}, \
> >   	{0x21, 0x04211020}
> >     #define ALC256_STANDARD_PINS \
> > @@ -5778,9 +5777,19 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
> >   static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> >   		{0x14, 0x901701a0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> >   		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60130},
> > +		{0x14, 0x901701b0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> > +		{0x14, 0x901701a0}),
> > +	SND_HDA_PIN_QUIRK(0x10ec0225, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
> > +		ALC225_STANDARD_PINS,
> > +		{0x12, 0xb7a60150},
> >   		{0x14, 0x901701b0}),
> >   	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
> >   		{0x14, 0x90170110},
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-07  5:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06  3:49 [PATCH] ALSA: hda/realtek - add new pin definition in alc225 pin quirk table Hui Wang
2016-07-07  2:32 ` [alsa-devel] " Hui Wang
2016-07-07  5:35   ` Takashi Iwai
2016-07-07  5:35     ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.