All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array
Date: Tue, 06 Dec 2011 13:28:03 +0100	[thread overview]
Message-ID: <s5hhb1dnauk.wl%tiwai@suse.de> (raw)
In-Reply-To: <1322600880.1534.351.camel@localhost.localdomain>

At Tue, 29 Nov 2011 22:08:00 +0100,
Thomas Meyer wrote:
> 
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

Thanks, applied both this and asihpi patches.


Takashi

> ---
> 
> diff -u -p a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
> --- a/sound/pci/ctxfi/ctsrc.c 2011-11-13 11:08:15.090921741 +0100
> +++ b/sound/pci/ctxfi/ctsrc.c 2011-11-28 20:14:46.651112893 +0100
> @@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const s
>  
>  	/* Allocate mem for master src resource */
>  	if (MEMRD == desc->mode)
> -		src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL);
> +		src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL);
>  	else
>  		src = kzalloc(sizeof(*src), GFP_KERNEL);
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array
Date: Tue, 06 Dec 2011 13:28:03 +0100	[thread overview]
Message-ID: <s5hhb1dnauk.wl%tiwai@suse.de> (raw)
In-Reply-To: <1322600880.1534.351.camel@localhost.localdomain>

At Tue, 29 Nov 2011 22:08:00 +0100,
Thomas Meyer wrote:
> 
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
> 
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

Thanks, applied both this and asihpi patches.


Takashi

> ---
> 
> diff -u -p a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c
> --- a/sound/pci/ctxfi/ctsrc.c 2011-11-13 11:08:15.090921741 +0100
> +++ b/sound/pci/ctxfi/ctsrc.c 2011-11-28 20:14:46.651112893 +0100
> @@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const s
>  
>  	/* Allocate mem for master src resource */
>  	if (MEMRD == desc->mode)
> -		src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL);
> +		src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL);
>  	else
>  		src = kzalloc(sizeof(*src), GFP_KERNEL);
>  
> 

  reply	other threads:[~2011-12-06 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 21:08 [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
2011-12-06 12:28 ` Takashi Iwai [this message]
2011-12-06 12:28   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hhb1dnauk.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.