* [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
@ 2017-12-07 12:36 Guneshwor Singh
2017-12-07 12:45 ` Takashi Iwai
2017-12-08 3:36 ` Subhransu S. Prusty
0 siblings, 2 replies; 4+ messages in thread
From: Guneshwor Singh @ 2017-12-07 12:36 UTC (permalink / raw)
To: ALSA, Takashi Iwai; +Cc: Vinod Koul, Patches Audio, Guneshwor Singh
Cannonlake HDMI codec has the same nid as Geminilake. This adds the
codec entry for it.
Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
---
sound/pci/hda/patch_hdmi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index c19c81d230bd..b4f1b6e88305 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -55,10 +55,11 @@ MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info");
#define is_kabylake(codec) ((codec)->core.vendor_id == 0x8086280b)
#define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \
((codec)->core.vendor_id == 0x80862800))
+#define is_cannonlake(codec) ((codec)->core.vendor_id == 0x8086280c)
#define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \
|| is_skylake(codec) || is_broxton(codec) \
- || is_kabylake(codec)) || is_geminilake(codec)
-
+ || is_kabylake(codec)) || is_geminilake(codec) \
+ || is_cannonlake(codec)
#define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882)
#define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883)
#define is_valleyview_plus(codec) (is_valleyview(codec) || is_cherryview(codec))
@@ -3841,6 +3842,7 @@ HDA_CODEC_ENTRY(0x80862808, "Broadwell HDMI", patch_i915_hsw_hdmi),
HDA_CODEC_ENTRY(0x80862809, "Skylake HDMI", patch_i915_hsw_hdmi),
HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi),
HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi),
+HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi),
HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi),
HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi),
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
2017-12-07 12:36 [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec Guneshwor Singh
@ 2017-12-07 12:45 ` Takashi Iwai
2017-12-08 3:36 ` Subhransu S. Prusty
1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-12-07 12:45 UTC (permalink / raw)
To: Guneshwor Singh; +Cc: Vinod Koul, Patches Audio, ALSA
On Thu, 07 Dec 2017 13:36:20 +0100,
Guneshwor Singh wrote:
>
> Cannonlake HDMI codec has the same nid as Geminilake. This adds the
> codec entry for it.
>
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
2017-12-07 12:36 [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec Guneshwor Singh
2017-12-07 12:45 ` Takashi Iwai
@ 2017-12-08 3:36 ` Subhransu S. Prusty
2017-12-08 4:01 ` Singh, Guneshwor
1 sibling, 1 reply; 4+ messages in thread
From: Subhransu S. Prusty @ 2017-12-08 3:36 UTC (permalink / raw)
To: Guneshwor Singh; +Cc: Takashi Iwai, Vinod Koul, ALSA, Patches Audio
On Thu, Dec 07, 2017 at 06:06:20PM +0530, Guneshwor Singh wrote:
> Cannonlake HDMI codec has the same nid as Geminilake. This adds the
> codec entry for it.
CNL and GLK share the same vendor nid not the vendor id.
You may update the subject and commit message.
Regards,
Subhransu
>
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
> ---
> sound/pci/hda/patch_hdmi.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index c19c81d230bd..b4f1b6e88305 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -55,10 +55,11 @@ MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info");
> #define is_kabylake(codec) ((codec)->core.vendor_id == 0x8086280b)
> #define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \
> ((codec)->core.vendor_id == 0x80862800))
> +#define is_cannonlake(codec) ((codec)->core.vendor_id == 0x8086280c)
> #define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \
> || is_skylake(codec) || is_broxton(codec) \
> - || is_kabylake(codec)) || is_geminilake(codec)
> -
> + || is_kabylake(codec)) || is_geminilake(codec) \
> + || is_cannonlake(codec)
> #define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882)
> #define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883)
> #define is_valleyview_plus(codec) (is_valleyview(codec) || is_cherryview(codec))
> @@ -3841,6 +3842,7 @@ HDA_CODEC_ENTRY(0x80862808, "Broadwell HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x80862809, "Skylake HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi),
> +HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi),
> --
> 2.15.1
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec
2017-12-08 3:36 ` Subhransu S. Prusty
@ 2017-12-08 4:01 ` Singh, Guneshwor
0 siblings, 0 replies; 4+ messages in thread
From: Singh, Guneshwor @ 2017-12-08 4:01 UTC (permalink / raw)
To: Subhransu S. Prusty; +Cc: Takashi Iwai, Vinod Koul, ALSA, Patches Audio
On Fri, Dec 08, 2017 at 09:06:34AM +0530, Subhransu S. Prusty wrote:
> On Thu, Dec 07, 2017 at 06:06:20PM +0530, Guneshwor Singh wrote:
> > Cannonlake HDMI codec has the same nid as Geminilake. This adds the
> > codec entry for it.
>
> CNL and GLK share the same vendor nid not the vendor id.
> You may update the subject and commit message.
>
It's adding new vendor id and uses vendor nid from GLK's. So commit msg
seems fine.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-08 4:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-07 12:36 [PATCH] ALSA: hda - Add vendor id for Cannonlake HDMI codec Guneshwor Singh
2017-12-07 12:45 ` Takashi Iwai
2017-12-08 3:36 ` Subhransu S. Prusty
2017-12-08 4:01 ` Singh, Guneshwor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.