From: Takashi Iwai <tiwai@suse.de> To: Quentin Lambert <lambert.quentin@gmail.com> Cc: Johannes Berg <johannes@sipsolutions.net>, Jaroslav Kysela <perex@perex.cz>, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Date: Fri, 29 May 2015 17:53:26 +0200 [thread overview] Message-ID: <s5hoal34byh.wl-tiwai@suse.de> (raw) In-Reply-To: <55688A72.7000306@gmail.com> At Fri, 29 May 2015 17:49:06 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 17:01, Takashi Iwai wrote: > >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into > >>> soundbus/sysfs.c, and make it this global instead of > >>> soundbus_dev_attrs[]. > >> Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS > >> declares the > >> structure as static. > > > > If it results in an ungly code, it's fine with the original code, > > too. But, maybe with a comment indicating that xxx_dev_attrs[] is > > defined in xxx.c. > > > > > Since sound/aoa/soundbus/sysfs is small, a solution would be > to merge sound/aoa/soundbus/sysfs.c and sound/aoa/soundus/core.c. > Moreover all 172 other usages of the ATTRIBUTE_GROUPS macro > define the struct attribute *xxx_attrs[] in the same file > they assign the .dev_groups field. > > I'm not sure about this change as it seems way more important than > adding a comment line as you suggested. Not "important" but more "radical", I'd say. > Should I send a patch merging these two files? I don't think it's worth. This is a fairly old hardware, thus the code isn't so actively used/maintained. Unless it looks too ugly, we shouldn't touch too many things just for refactoring. So, go for the way to have a minimum change. thanks, Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Quentin Lambert <lambert.quentin@gmail.com> Cc: Johannes Berg <johannes@sipsolutions.net>, Jaroslav Kysela <perex@perex.cz>, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Date: Fri, 29 May 2015 15:53:26 +0000 [thread overview] Message-ID: <s5hoal34byh.wl-tiwai@suse.de> (raw) In-Reply-To: <55688A72.7000306@gmail.com> At Fri, 29 May 2015 17:49:06 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 17:01, Takashi Iwai wrote: > >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into > >>> soundbus/sysfs.c, and make it this global instead of > >>> soundbus_dev_attrs[]. > >> Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS > >> declares the > >> structure as static. > > > > If it results in an ungly code, it's fine with the original code, > > too. But, maybe with a comment indicating that xxx_dev_attrs[] is > > defined in xxx.c. > > > > > Since sound/aoa/soundbus/sysfs is small, a solution would be > to merge sound/aoa/soundbus/sysfs.c and sound/aoa/soundus/core.c. > Moreover all 172 other usages of the ATTRIBUTE_GROUPS macro > define the struct attribute *xxx_attrs[] in the same file > they assign the .dev_groups field. > > I'm not sure about this change as it seems way more important than > adding a comment line as you suggested. Not "important" but more "radical", I'd say. > Should I send a patch merging these two files? I don't think it's worth. This is a fairly old hardware, thus the code isn't so actively used/maintained. Unless it looks too ugly, we shouldn't touch too many things just for refactoring. So, go for the way to have a minimum change. thanks, Takashi
next prev parent reply other threads:[~2015-05-29 15:53 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-28 12:48 [PATCH] ALSA: aoa: convert bus code to use dev_groups Quentin Lambert 2015-05-28 12:48 ` Quentin Lambert 2015-05-28 13:52 ` Takashi Iwai 2015-05-28 13:52 ` Takashi Iwai 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 14:09 ` Takashi Iwai 2015-05-28 14:09 ` Takashi Iwai 2015-05-28 14:43 ` Quentin Lambert 2015-05-28 14:43 ` Quentin Lambert 2015-05-28 15:01 ` Takashi Iwai 2015-05-28 15:01 ` Takashi Iwai 2015-05-29 15:49 ` Quentin Lambert 2015-05-29 15:49 ` Quentin Lambert 2015-05-29 15:53 ` Takashi Iwai [this message] 2015-05-29 15:53 ` Takashi Iwai 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 13:59 ` Quentin Lambert 2015-06-11 8:03 ` [PATCH v2] " Quentin Lambert 2015-06-11 8:03 ` Quentin Lambert 2015-06-11 10:02 ` [alsa-devel] " Takashi Iwai 2015-06-11 10:02 ` Takashi Iwai 2015-06-11 12:04 ` Quentin Lambert 2015-06-11 12:04 ` Quentin Lambert 2015-06-11 12:25 ` Takashi Iwai 2015-06-11 12:25 ` Takashi Iwai 2015-06-11 12:25 ` [alsa-devel] " Takashi Iwai 2015-06-12 7:55 ` Quentin Lambert 2015-06-12 7:55 ` Quentin Lambert 2015-06-11 11:55 ` walter harms 2015-06-11 11:55 ` walter harms 2015-06-11 12:06 ` Quentin Lambert 2015-06-11 12:06 ` Quentin Lambert 2015-06-12 8:38 ` [PATCH v3] " Quentin Lambert 2015-06-12 8:38 ` Quentin Lambert 2015-06-12 9:59 ` Andreas Schwab 2015-06-12 9:59 ` Andreas Schwab 2015-06-12 10:01 ` Quentin Lambert 2015-06-12 10:01 ` Quentin Lambert 2015-06-12 18:50 ` Takashi Iwai 2015-06-12 18:50 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5hoal34byh.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=johannes@sipsolutions.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=lambert.quentin@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=perex@perex.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.