From: Takashi Iwai <tiwai@suse.de> To: Quentin Lambert <lambert.quentin@gmail.com> Cc: Johannes Berg <johannes@sipsolutions.net>, Jaroslav Kysela <perex@perex.cz>, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Date: Thu, 28 May 2015 15:52:48 +0200 [thread overview] Message-ID: <s5hwpzs7qrz.wl-tiwai@suse.de> (raw) In-Reply-To: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: > > You should use dev_groups instead of the dev_attrs field of struct > bus_type. This converts the MDIO bus code to use the correct field. > > These modifications were made using Coccinelle. > > Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com> What's wrong with dev_attrs? (Not offending, I'm just curious where the preference for dev_groups is referred...) thanks, Takashi > --- > sound/aoa/soundbus/core.c | 3 ++- > sound/aoa/soundbus/soundbus.h | 2 +- > sound/aoa/soundbus/sysfs.c | 13 ++++++++----- > 3 files changed, 11 insertions(+), 7 deletions(-) > > --- a/sound/aoa/soundbus/core.c > +++ b/sound/aoa/soundbus/core.c > @@ -150,6 +150,7 @@ static int soundbus_device_resume(struct > > #endif /* CONFIG_PM */ > > +ATTRIBUTE_GROUPS(soundbus_dev); > static struct bus_type soundbus_bus_type = { > .name = "aoa-soundbus", > .probe = soundbus_probe, > @@ -160,7 +161,7 @@ static struct bus_type soundbus_bus_type > .suspend = soundbus_device_suspend, > .resume = soundbus_device_resume, > #endif > - .dev_attrs = soundbus_dev_attrs, > + .dev_groups = soundbus_dev_groups, > }; > > int soundbus_add_one(struct soundbus_dev *dev) > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -199,6 +199,6 @@ struct soundbus_driver { > extern int soundbus_register_driver(struct soundbus_driver *drv); > extern void soundbus_unregister_driver(struct soundbus_driver *drv); > > -extern struct device_attribute soundbus_dev_attrs[]; > +extern struct attribute *soundbus_dev_attrs[]; > > #endif /* __SOUNDBUS_H */ > --- a/sound/aoa/soundbus/sysfs.c > +++ b/sound/aoa/soundbus/sysfs.c > @@ -30,13 +30,16 @@ static ssize_t modalias_show(struct devi > > return length; > } > +static DEVICE_ATTR_RO(modalias); > > soundbus_config_of_attr (name, "%s\n"); > +static DEVICE_ATTR_RO(name); > soundbus_config_of_attr (type, "%s\n"); > +static DEVICE_ATTR_RO(type); > > -struct device_attribute soundbus_dev_attrs[] = { > - __ATTR_RO(name), > - __ATTR_RO(type), > - __ATTR_RO(modalias), > - __ATTR_NULL > +struct attribute *soundbus_dev_attrs[] = { > + &dev_attr_name.attr, > + &dev_attr_type.attr, > + &dev_attr_modalias.attr, > + NULL, > }; >
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Quentin Lambert <lambert.quentin@gmail.com> Cc: Johannes Berg <johannes@sipsolutions.net>, Jaroslav Kysela <perex@perex.cz>, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Date: Thu, 28 May 2015 13:52:48 +0000 [thread overview] Message-ID: <s5hwpzs7qrz.wl-tiwai@suse.de> (raw) In-Reply-To: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: > > You should use dev_groups instead of the dev_attrs field of struct > bus_type. This converts the MDIO bus code to use the correct field. > > These modifications were made using Coccinelle. > > Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com> What's wrong with dev_attrs? (Not offending, I'm just curious where the preference for dev_groups is referred...) thanks, Takashi > --- > sound/aoa/soundbus/core.c | 3 ++- > sound/aoa/soundbus/soundbus.h | 2 +- > sound/aoa/soundbus/sysfs.c | 13 ++++++++----- > 3 files changed, 11 insertions(+), 7 deletions(-) > > --- a/sound/aoa/soundbus/core.c > +++ b/sound/aoa/soundbus/core.c > @@ -150,6 +150,7 @@ static int soundbus_device_resume(struct > > #endif /* CONFIG_PM */ > > +ATTRIBUTE_GROUPS(soundbus_dev); > static struct bus_type soundbus_bus_type = { > .name = "aoa-soundbus", > .probe = soundbus_probe, > @@ -160,7 +161,7 @@ static struct bus_type soundbus_bus_type > .suspend = soundbus_device_suspend, > .resume = soundbus_device_resume, > #endif > - .dev_attrs = soundbus_dev_attrs, > + .dev_groups = soundbus_dev_groups, > }; > > int soundbus_add_one(struct soundbus_dev *dev) > --- a/sound/aoa/soundbus/soundbus.h > +++ b/sound/aoa/soundbus/soundbus.h > @@ -199,6 +199,6 @@ struct soundbus_driver { > extern int soundbus_register_driver(struct soundbus_driver *drv); > extern void soundbus_unregister_driver(struct soundbus_driver *drv); > > -extern struct device_attribute soundbus_dev_attrs[]; > +extern struct attribute *soundbus_dev_attrs[]; > > #endif /* __SOUNDBUS_H */ > --- a/sound/aoa/soundbus/sysfs.c > +++ b/sound/aoa/soundbus/sysfs.c > @@ -30,13 +30,16 @@ static ssize_t modalias_show(struct devi > > return length; > } > +static DEVICE_ATTR_RO(modalias); > > soundbus_config_of_attr (name, "%s\n"); > +static DEVICE_ATTR_RO(name); > soundbus_config_of_attr (type, "%s\n"); > +static DEVICE_ATTR_RO(type); > > -struct device_attribute soundbus_dev_attrs[] = { > - __ATTR_RO(name), > - __ATTR_RO(type), > - __ATTR_RO(modalias), > - __ATTR_NULL > +struct attribute *soundbus_dev_attrs[] = { > + &dev_attr_name.attr, > + &dev_attr_type.attr, > + &dev_attr_modalias.attr, > + NULL, > }; >
next prev parent reply other threads:[~2015-05-28 13:52 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-28 12:48 [PATCH] ALSA: aoa: convert bus code to use dev_groups Quentin Lambert 2015-05-28 12:48 ` Quentin Lambert 2015-05-28 13:52 ` Takashi Iwai [this message] 2015-05-28 13:52 ` Takashi Iwai 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 14:09 ` Takashi Iwai 2015-05-28 14:09 ` Takashi Iwai 2015-05-28 14:43 ` Quentin Lambert 2015-05-28 14:43 ` Quentin Lambert 2015-05-28 15:01 ` Takashi Iwai 2015-05-28 15:01 ` Takashi Iwai 2015-05-29 15:49 ` Quentin Lambert 2015-05-29 15:49 ` Quentin Lambert 2015-05-29 15:53 ` Takashi Iwai 2015-05-29 15:53 ` Takashi Iwai 2015-05-28 13:59 ` Quentin Lambert 2015-05-28 13:59 ` Quentin Lambert 2015-06-11 8:03 ` [PATCH v2] " Quentin Lambert 2015-06-11 8:03 ` Quentin Lambert 2015-06-11 10:02 ` [alsa-devel] " Takashi Iwai 2015-06-11 10:02 ` Takashi Iwai 2015-06-11 12:04 ` Quentin Lambert 2015-06-11 12:04 ` Quentin Lambert 2015-06-11 12:25 ` Takashi Iwai 2015-06-11 12:25 ` Takashi Iwai 2015-06-11 12:25 ` [alsa-devel] " Takashi Iwai 2015-06-12 7:55 ` Quentin Lambert 2015-06-12 7:55 ` Quentin Lambert 2015-06-11 11:55 ` walter harms 2015-06-11 11:55 ` walter harms 2015-06-11 12:06 ` Quentin Lambert 2015-06-11 12:06 ` Quentin Lambert 2015-06-12 8:38 ` [PATCH v3] " Quentin Lambert 2015-06-12 8:38 ` Quentin Lambert 2015-06-12 9:59 ` Andreas Schwab 2015-06-12 9:59 ` Andreas Schwab 2015-06-12 10:01 ` Quentin Lambert 2015-06-12 10:01 ` Quentin Lambert 2015-06-12 18:50 ` Takashi Iwai 2015-06-12 18:50 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5hwpzs7qrz.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=johannes@sipsolutions.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=lambert.quentin@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=perex@perex.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.