From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org,
wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting
Date: Sun, 25 Jul 2021 09:44:01 +0200 [thread overview]
Message-ID: <s5hwnpehm7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
On Sat, 24 Jul 2021 17:04:13 +0200,
Geraldo Nascimento wrote:
>
> On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This looks like a regression introduced by the recent commit
> > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> > selector"), which is a fix for certain devices. Too bad that the
> > behavior really depends on the device...
>
> Dr. Iwai, perhaps we could restrict the generalized fix for the
> Behringer UFX1604 / UFX1204 with some simple logic to devices that
> only have *one* clock source.
>
> In that case the clock selector must be set to the only clock source.
>
> This way we keep the generalization without breaking devices with more
> than one clock source.
>
> Just an idea.
I don't think it's easy to generalize. All those bugs are more or
less BIOS bugs, and a logic doesn't apply always, just because it's a
bug :) For example, setting the clock selector itself should be a
valid operation from the specification POV, while this leads to
breakage on some devices. So, even if we add a more generic
workaround, we need to see which side effect is more commonly seen at
first.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: alsa-devel@alsa-project.org, wsd_upstream@mediatek.com,
damien@zamaudio.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, chihhao.chen@mediatek.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting
Date: Sun, 25 Jul 2021 09:44:01 +0200 [thread overview]
Message-ID: <s5hwnpehm7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
On Sat, 24 Jul 2021 17:04:13 +0200,
Geraldo Nascimento wrote:
>
> On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This looks like a regression introduced by the recent commit
> > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> > selector"), which is a fix for certain devices. Too bad that the
> > behavior really depends on the device...
>
> Dr. Iwai, perhaps we could restrict the generalized fix for the
> Behringer UFX1604 / UFX1204 with some simple logic to devices that
> only have *one* clock source.
>
> In that case the clock selector must be set to the only clock source.
>
> This way we keep the generalization without breaking devices with more
> than one clock source.
>
> Just an idea.
I don't think it's easy to generalize. All those bugs are more or
less BIOS bugs, and a logic doesn't apply always, just because it's a
bug :) For example, setting the clock selector itself should be a
valid operation from the specification POV, while this leads to
breakage on some devices. So, even if we add a more generic
workaround, we need to see which side effect is more commonly seen at
first.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org,
wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting
Date: Sun, 25 Jul 2021 09:44:01 +0200 [thread overview]
Message-ID: <s5hwnpehm7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
On Sat, 24 Jul 2021 17:04:13 +0200,
Geraldo Nascimento wrote:
>
> On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This looks like a regression introduced by the recent commit
> > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> > selector"), which is a fix for certain devices. Too bad that the
> > behavior really depends on the device...
>
> Dr. Iwai, perhaps we could restrict the generalized fix for the
> Behringer UFX1604 / UFX1204 with some simple logic to devices that
> only have *one* clock source.
>
> In that case the clock selector must be set to the only clock source.
>
> This way we keep the generalization without breaking devices with more
> than one clock source.
>
> Just an idea.
I don't think it's easy to generalize. All those bugs are more or
less BIOS bugs, and a logic doesn't apply always, just because it's a
bug :) For example, setting the clock selector itself should be a
valid operation from the specification POV, while this leads to
breakage on some devices. So, even if we add a more generic
workaround, we need to see which side effect is more commonly seen at
first.
Takashi
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org,
wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting
Date: Sun, 25 Jul 2021 09:44:01 +0200 [thread overview]
Message-ID: <s5hwnpehm7y.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAEsQvcs3P+TqQFzQetPfRycpo66eJFwnzwhk2JyCXFaCLFHmFg@mail.gmail.com>
On Sat, 24 Jul 2021 17:04:13 +0200,
Geraldo Nascimento wrote:
>
> On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This looks like a regression introduced by the recent commit
> > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> > selector"), which is a fix for certain devices. Too bad that the
> > behavior really depends on the device...
>
> Dr. Iwai, perhaps we could restrict the generalized fix for the
> Behringer UFX1604 / UFX1204 with some simple logic to devices that
> only have *one* clock source.
>
> In that case the clock selector must be set to the only clock source.
>
> This way we keep the generalization without breaking devices with more
> than one clock source.
>
> Just an idea.
I don't think it's easy to generalize. All those bugs are more or
less BIOS bugs, and a logic doesn't apply always, just because it's a
bug :) For example, setting the clock selector itself should be a
valid operation from the specification POV, while this leads to
breakage on some devices. So, even if we add a more generic
workaround, we need to see which side effect is more commonly seen at
first.
Takashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-25 7:44 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 4:23 [PATCH] ALSA: usb-audio: fix incorrect clock source setting chihhao.chen
2021-07-24 4:23 ` chihhao.chen
2021-07-24 4:23 ` chihhao.chen
2021-07-24 4:23 ` chihhao.chen
2021-07-24 8:04 ` Takashi Iwai
2021-07-24 8:04 ` Takashi Iwai
2021-07-24 8:04 ` Takashi Iwai
2021-07-24 8:04 ` Takashi Iwai
2021-07-24 15:04 ` Geraldo Nascimento
2021-07-24 15:04 ` Geraldo Nascimento
2021-07-24 15:04 ` Geraldo Nascimento
2021-07-24 15:04 ` Geraldo Nascimento
2021-07-24 15:20 ` Geraldo Nascimento
2021-07-24 15:20 ` Geraldo Nascimento
2021-07-24 15:20 ` Geraldo Nascimento
2021-07-24 15:20 ` Geraldo Nascimento
2021-07-24 18:42 ` Geraldo Nascimento
2021-07-24 18:42 ` Geraldo Nascimento
2021-07-24 18:42 ` Geraldo Nascimento
2021-07-24 18:42 ` Geraldo Nascimento
2021-07-25 7:44 ` Takashi Iwai [this message]
2021-07-25 7:44 ` Takashi Iwai
2021-07-25 7:44 ` Takashi Iwai
2021-07-25 7:44 ` Takashi Iwai
2021-07-26 2:16 ` Geraldo Nascimento
2021-07-26 2:16 ` Geraldo Nascimento
2021-07-26 2:16 ` Geraldo Nascimento
2021-07-26 2:16 ` Geraldo Nascimento
2021-07-26 8:42 ` chihhao chen
2021-07-26 8:42 ` chihhao chen
2021-07-26 8:42 ` chihhao chen
2021-07-26 8:42 ` chihhao chen
2021-07-26 20:57 ` Geraldo Nascimento
2021-07-26 20:57 ` Geraldo Nascimento
2021-07-26 20:57 ` Geraldo Nascimento
2021-07-26 20:57 ` Geraldo Nascimento
2021-07-27 10:27 ` chihhao.chen
2021-07-27 10:27 ` chihhao.chen
2021-07-27 10:27 ` chihhao.chen
2021-07-27 10:27 ` chihhao.chen
2021-07-27 17:56 ` Geraldo Nascimento
2021-07-27 17:56 ` Geraldo Nascimento
2021-07-27 17:56 ` Geraldo Nascimento
2021-07-27 17:56 ` Geraldo Nascimento
2021-07-28 1:19 ` Geraldo Nascimento
2021-07-28 1:19 ` Geraldo Nascimento
2021-07-28 1:19 ` Geraldo Nascimento
2021-07-28 1:19 ` Geraldo Nascimento
2021-08-05 7:54 ` chihhao.chen
2021-08-05 7:54 ` chihhao.chen
2021-08-05 7:54 ` chihhao.chen
2021-08-05 7:54 ` chihhao.chen
2021-08-05 15:50 ` Geraldo Nascimento
2021-08-05 15:50 ` Geraldo Nascimento
2021-08-05 15:50 ` Geraldo Nascimento
2021-08-05 15:50 ` Geraldo Nascimento
2021-08-05 23:31 ` Geraldo Nascimento
2021-08-05 22:03 ` Geraldo Nascimento
2021-08-05 22:03 ` Geraldo Nascimento
2021-08-05 22:03 ` Geraldo Nascimento
2021-08-05 22:03 ` Geraldo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwnpehm7y.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=chihhao.chen@mediatek.com \
--cc=damien@zamaudio.com \
--cc=geraldogabriel@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tiwai@suse.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.