All of lore.kernel.org
 help / color / mirror / Atom feed
* How to modify defconfig file - make savedefconfig?
@ 2022-01-27 16:46 Grant Edwards
  2022-01-28 10:26 ` Alexander Dahl
  0 siblings, 1 reply; 2+ messages in thread
From: Grant Edwards @ 2022-01-27 16:46 UTC (permalink / raw)
  To: u-boot

What is the "right" way to modify a defconfig file?

Most sources I've found just say things like "edit the defconfig
file". That seems error-prone -- especially when dealing with settings
that have side effects.

I did stumble across one mention of "make savedefconfig", and this
seems to be the right way to modify a defconfig file:

    make myboard_defconfig
    make menuconfig
    make savedefconfig
    cp defconfig configs/myboard_defconfig

Do people manually edit their defconfig file when they want to make a
change, or do they use "make savedefconfig" like I show above?

One reason I'm asking is that the original defconfig file provided by
the silicon vendor (Renesas) appears to be a manually stripped-down
..config file, because when I do

   make vendors_defconfig
   make savedefconfig

The defconfig file generated by 'make savedefconfig' looks _nothing_
like the starting vendors_defconfig. The new defconfig generates the
same .config file as the vendors_defconfig file. But the
vendors_defconfig file is arranged completely differently with
different/extra comments, extra blank lines, etc.

--
Grant




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: How to modify defconfig file - make savedefconfig?
  2022-01-27 16:46 How to modify defconfig file - make savedefconfig? Grant Edwards
@ 2022-01-28 10:26 ` Alexander Dahl
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Dahl @ 2022-01-28 10:26 UTC (permalink / raw)
  To: Grant Edwards; +Cc: u-boot

Hello Grant,

Am Thu, Jan 27, 2022 at 04:46:48PM -0000 schrieb Grant Edwards:
> What is the "right" way to modify a defconfig file?
> 
> Most sources I've found just say things like "edit the defconfig
> file". That seems error-prone -- especially when dealing with settings
> that have side effects.
> 
> I did stumble across one mention of "make savedefconfig", and this
> seems to be the right way to modify a defconfig file:
> 
>     make myboard_defconfig
>     make menuconfig
>     make savedefconfig
>     cp defconfig configs/myboard_defconfig

That's what I do.

> Do people manually edit their defconfig file when they want to make a
> change, or do they use "make savedefconfig" like I show above?

You can do both.  If you already have a defconfig, this:

1) edit your myboard_defconfig
2) make myboard_defconfig
3) make savedefconfig
4) cp defconfig configs/myboard_defconfig

You might want to `git add configs/myboard_defconfig` in between those
stages if you want to inspect what changed with those calls.

> One reason I'm asking is that the original defconfig file provided by
> the silicon vendor (Renesas) appears to be a manually stripped-down
> ..config file, because when I do
> 
>    make vendors_defconfig
>    make savedefconfig
> 
> The defconfig file generated by 'make savedefconfig' looks _nothing_
> like the starting vendors_defconfig. The new defconfig generates the
> same .config file as the vendors_defconfig file. But the
> vendors_defconfig file is arranged completely differently with
> different/extra comments, extra blank lines, etc.

I think U-Boot expects those files to be created by savedefconfig, 
see all the changesets in Git reading 
'configs: Resync with savedefconfig'.

Greets
Alex


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-28 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 16:46 How to modify defconfig file - make savedefconfig? Grant Edwards
2022-01-28 10:26 ` Alexander Dahl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.