From: tip-bot for Dan Carpenter <dan.carpenter@oracle.com> To: linux-tip-commits@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, fweisbec@gmail.com, rostedt@goodmis.org, eduard.munteanu@linux360.ro, tglx@linutronix.de, dan.carpenter@oracle.com Subject: [tip:perf/core] tracing: Remove an unneeded check in trace_seq_buffer() Date: Wed, 2 May 2012 14:02:20 -0700 [thread overview] Message-ID: <tip-5a26c8f0cf1e95106858bb4e23ca6dd14c9b842f@git.kernel.org> (raw) In-Reply-To: <20120420063145.GA22649@elgon.mountain> Commit-ID: 5a26c8f0cf1e95106858bb4e23ca6dd14c9b842f Gitweb: http://git.kernel.org/tip/5a26c8f0cf1e95106858bb4e23ca6dd14c9b842f Author: Dan Carpenter <dan.carpenter@oracle.com> AuthorDate: Fri, 20 Apr 2012 09:31:45 +0300 Committer: Steven Rostedt <rostedt@goodmis.org> CommitDate: Mon, 23 Apr 2012 21:16:10 -0400 tracing: Remove an unneeded check in trace_seq_buffer() memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or we would already have Oopsed. Link: http://lkml.kernel.org/r/20120420063145.GA22649@elgon.mountain Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/trace/trace.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 1ab8e35..bbcde54 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -629,7 +629,6 @@ ssize_t trace_seq_to_user(struct trace_seq *s, char __user *ubuf, size_t cnt) static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) { int len; - void *ret; if (s->len <= s->readpos) return -EBUSY; @@ -637,9 +636,7 @@ static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) len = s->len - s->readpos; if (cnt > len) cnt = len; - ret = memcpy(buf, s->buffer + s->readpos, cnt); - if (!ret) - return -EFAULT; + memcpy(buf, s->buffer + s->readpos, cnt); s->readpos += cnt; return cnt;
prev parent reply other threads:[~2012-05-02 21:02 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-20 6:31 [patch] tracing: Remove an unneeded check Dan Carpenter 2012-04-20 6:31 ` Dan Carpenter 2012-04-20 13:51 ` Steven Rostedt 2012-04-20 13:51 ` Steven Rostedt 2012-04-20 14:03 ` Dan Carpenter 2012-04-20 14:03 ` Dan Carpenter 2012-04-20 14:26 ` Steven Rostedt 2012-04-20 14:26 ` Steven Rostedt 2012-05-02 21:02 ` tip-bot for Dan Carpenter [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tip-5a26c8f0cf1e95106858bb4e23ca6dd14c9b842f@git.kernel.org \ --to=dan.carpenter@oracle.com \ --cc=eduard.munteanu@linux360.ro \ --cc=fweisbec@gmail.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --subject='Re: [tip:perf/core] tracing: Remove an unneeded check in trace_seq_buffer()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.