[PATCH v2] x86: smpboot: mark array as const

[PATCH v2] x86: smpboot: mark array as const

[Greg Dietsche]

This array is read-only. Make it explicit by marking as const.

Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
 arch/x86/kernel/smpboot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 9fd3137..9f548cb 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -438,7 +438,7 @@ static void impress_friends(void)
 void __inquire_remote_apic(int apicid)
 {
 	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
-	char *names[] = { "ID", "VERSION", "SPIV" };
+	const char * const names[] = { "ID", "VERSION", "SPIV" };
 	int timeout;
 	u32 status;
 
-- 
1.7.2.5

Re: [PATCH v2] x86: smpboot: mark array as const

[Greg Dietsche]

On 06/30/2011 08:10 PM, Greg Dietsche wrote:
> This array is read-only. Make it explicit by marking as const.
>
> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
> ---
>   arch/x86/kernel/smpboot.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 9fd3137..9f548cb 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -438,7 +438,7 @@ static void impress_friends(void)
>   void __inquire_remote_apic(int apicid)
>   {
>   	unsigned i, regs[] = { APIC_ID>>  4, APIC_LVR>>  4, APIC_SPIV>>  4 };
> -	char *names[] = { "ID", "VERSION", "SPIV" };
> +	const char * const names[] = { "ID", "VERSION", "SPIV" };
>   	int timeout;
>   	u32 status;
>
>    
adding trivial@kernel.org to the cc list since this is trivial and no 
one has picked up this patch to date.

Greg

[tip:x86/cleanups] x86, smpboot: Mark the names[] array in __inquire_remote_apic() as const

[tip-bot for Greg Dietsche]

Commit-ID:  a6c23905ff0d6bbddf590ef0838489ee0f6c74ac
Gitweb:     http://git.kernel.org/tip/a6c23905ff0d6bbddf590ef0838489ee0f6c74ac
Author:     Greg Dietsche <Gregory.Dietsche@cuw.edu>
AuthorDate: Thu, 30 Jun 2011 20:10:53 -0500
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 21 Jul 2011 10:04:51 +0200

x86, smpboot: Mark the names[] array in __inquire_remote_apic() as const

This array is read-only. Make it explicit by marking as const.

Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Link: http://lkml.kernel.org/r/1309482653-23648-1-git-send-email-Gregory.Dietsche@cuw.edu
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/smpboot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index a3c430b..e02653a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -425,7 +425,7 @@ static void impress_friends(void)
 void __inquire_remote_apic(int apicid)
 {
 	unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
-	char *names[] = { "ID", "VERSION", "SPIV" };
+	const char * const names[] = { "ID", "VERSION", "SPIV" };
 	int timeout;
 	u32 status;