From: Petr Machata <petrm@mellanox.com> To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, jiri@mellanox.com, idosch@mellanox.com, ivecera@redhat.com, davem@davemloft.net, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com Subject: Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries Date: Thu, 03 May 2018 16:07:18 +0300 [thread overview] Message-ID: <wih4ljosxa1.fsf@dev-r-vrt-156.mtr.labs.mlnx> (raw) In-Reply-To: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> (Nikolay Aleksandrov's message of "Thu, 3 May 2018 15:56:33 +0300") Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes: > On 03/05/18 15:43, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself originates in a notification, to >> avoid sending duplicate notifications. >> >> Signed-off-by: Petr Machata <petrm@mellanox.com> >> --- >> net/bridge/br.c | 4 ++-- >> net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- >> net/bridge/br_private.h | 6 ++++-- >> net/bridge/br_switchdev.c | 2 +- >> 4 files changed, 33 insertions(+), 26 deletions(-) >> > > Thanks, looks good to me! In the future please add the reviewers to the CC list > when sending a v2, I actually missed the v2 set and saw your reply to the cover > letter patch later. Sorry, I'm still tweaking my process for direct submission after going almost exclusively through mlxsw for so long! > Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Thanks, Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Machata <petrm@mellanox.com> To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Cc: ivecera@redhat.com, f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, idosch@mellanox.com, jiri@mellanox.com, vivien.didelot@savoirfairelinux.com, davem@davemloft.net Subject: Re: [Bridge] [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries Date: Thu, 03 May 2018 16:07:18 +0300 [thread overview] Message-ID: <wih4ljosxa1.fsf@dev-r-vrt-156.mtr.labs.mlnx> (raw) In-Reply-To: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> (Nikolay Aleksandrov's message of "Thu, 3 May 2018 15:56:33 +0300") Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes: > On 03/05/18 15:43, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself originates in a notification, to >> avoid sending duplicate notifications. >> >> Signed-off-by: Petr Machata <petrm@mellanox.com> >> --- >> net/bridge/br.c | 4 ++-- >> net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- >> net/bridge/br_private.h | 6 ++++-- >> net/bridge/br_switchdev.c | 2 +- >> 4 files changed, 33 insertions(+), 26 deletions(-) >> > > Thanks, looks good to me! In the future please add the reviewers to the CC list > when sending a v2, I actually missed the v2 set and saw your reply to the cover > letter patch later. Sorry, I'm still tweaking my process for direct submission after going almost exclusively through mlxsw for so long! > Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Thanks, Petr
next prev parent reply other threads:[~2018-05-03 13:07 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-03 12:43 [PATCH net-next mlxsw v2 0/2] bridge: FDB: Notify about removal of non-user-added entries Petr Machata 2018-05-03 12:43 ` [Bridge] " Petr Machata 2018-05-03 12:43 ` [PATCH net-next mlxsw v2 1/2] switchdev: Add fdb.added_by_user to switchdev notifications Petr Machata 2018-05-03 12:43 ` [Bridge] " Petr Machata 2018-05-03 12:59 ` Ivan Vecera 2018-05-03 12:59 ` [Bridge] " Ivan Vecera 2018-05-03 12:43 ` [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries Petr Machata 2018-05-03 12:43 ` [Bridge] " Petr Machata 2018-05-03 12:56 ` Nikolay Aleksandrov 2018-05-03 12:56 ` [Bridge] " Nikolay Aleksandrov 2018-05-03 13:07 ` Petr Machata [this message] 2018-05-03 13:07 ` Petr Machata 2018-05-03 13:00 ` Ivan Vecera 2018-05-03 13:00 ` [Bridge] " Ivan Vecera 2018-05-03 12:48 ` [PATCH net-next mlxsw v2 0/2] bridge: FDB: Notify about removal of non-user-added entries Petr Machata 2018-05-03 12:48 ` [Bridge] " Petr Machata 2018-05-03 17:47 ` David Miller 2018-05-03 17:47 ` [Bridge] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=wih4ljosxa1.fsf@dev-r-vrt-156.mtr.labs.mlnx \ --to=petrm@mellanox.com \ --cc=andrew@lunn.ch \ --cc=bridge@lists.linux-foundation.org \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=idosch@mellanox.com \ --cc=ivecera@redhat.com \ --cc=jiri@mellanox.com \ --cc=netdev@vger.kernel.org \ --cc=nikolay@cumulusnetworks.com \ --cc=stephen@networkplumber.org \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.