All of lore.kernel.org
 help / color / mirror / Atom feed
* What's cooking in git.git (Apr 2012, #08; Fri, 20)
@ 2012-04-21  0:06 Junio C Hamano
  2012-04-21 10:23 ` SZEDER Gábor
  2012-04-22 15:07 ` Johannes Sixt
  0 siblings, 2 replies; 7+ messages in thread
From: Junio C Hamano @ 2012-04-21  0:06 UTC (permalink / raw)
  To: git

Here are the topics that have been cooking.  Commits prefixed with '-' are
only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'.

The third batch of topics in this cycle is now in 'master'.

You can find the changes described here in the integration branches of the
repositories listed at

    http://git-blame.blogspot.com/p/git-public-repositories.html

--------------------------------------------------
[Graduated to "master"]

* bw/submodule-sed-solaris (2012-04-09) 1 commit
  (merged to 'next' on 2012-04-12 at 3bf1d83)
 + Avoid bug in Solaris xpg4/sed as used in submodule

* ct/advise-push-default (2012-04-12) 3 commits
  (merged to 'next' on 2012-04-12 at b0613cd)
 + Fix httpd tests that broke when non-ff push advice changed
 + clean up struct ref's nonfastforward field
 + push: Provide situational hints for non-fast-forward errors
 (this branch is used by mm/push-default-switch-warning.)

Breaks down the cases in which "git push" fails due to non-ff into three
categories, and gives separate advise messages.  This should be a good
change regardless of mm/push-default-switch-warning topic.

* jb/am-include (2012-03-28) 1 commit
  (merged to 'next' on 2012-04-12 at ddbf96d)
 + am: support --include option

"git am" learned the "--include" option, which is an opposite of existing
the "--exclude" option.

* jc/am-report-3way (2012-03-28) 1 commit
  (merged to 'next' on 2012-04-12 at cf5d599)
 + am -3: list the paths that needed 3-way fallback

When "git am -3" needs to fall back to an application to a synthesized
preimage followed by a 3-way merge, the paths that needed such treatment
are now reported to the end user, so that the result in them can be
eyeballed with extra care.

* jc/fmt-merge-msg-people (2012-03-13) 1 commit
  (merged to 'next' on 2012-04-12 at 4c2031c)
 + fmt-merge-msg: show those involved in a merged series

The "fmt-merge-msg" command learns to list the primary contributors
involved in the side topic you are merging.

* jc/push-upstream-sanity (2012-04-05) 1 commit
  (merged to 'next' on 2012-04-12 at 288e1ad)
 + push: error out when the "upstream" semantics does not make sense
 (this branch is used by mm/push-default-switch-warning.)

Fix broken 'push to upstream' implementation.  "git push $there" without
refspec, when the current branch is set to push to a remote different from
$there, used to push to $there using the upstream information to a remote
unreleated to $there.

* jk/run-command-eacces (2012-04-05) 2 commits
  (merged to 'next' on 2012-04-12 at ef3782e)
 + run-command: treat inaccessible directories as ENOENT
 + compat/mingw.[ch]: Change return type of exec functions to int

When PATH contains an unreadable directory, alias expansion code did not
kick in, and failed with an error that said "git-subcmd" was not found.

* js/spawn-via-shell-path-fix (2012-04-17) 1 commit
  (merged to 'next' on 2012-04-19 at 3e04ef6)
 + Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows

Mops up an unfortunate fallout from bw/spawn-via-shell-path topic.

--------------------------------------------------
[New Topics]

* bw/test-fix-grep-gnuism (2012-04-19) 1 commit
  (merged to 'next' on 2012-04-20 at ee7eec4)
 + t9400: fix gnuism in grep

Fix two places that were the only place in the test suite that gave "a\+"
to platform grep and expected it to mean one or more "a", which is a
blatant GNUism.

* rt/cherry-revert-conflict-summary (2012-04-19) 1 commit
 - sequencer: remove additional blank line

In the older days, the header "Conflicts:" in "cherry-pick" and
"merge" was separated by a blank line from the list of paths that
follow for readability, but when "merge" was rewritten in C, we lost
it by mistake. Remove the newline from "cherry-pick" to make them
match again.

* js/fast-import-test-9300 (2012-04-20) 1 commit
 - t9300-fast-import: avoid 'exit' in test_expect_success snippets

--------------------------------------------------
[Stalled]

* jc/split-blob (2012-04-03) 7 commits
 - chunked-object: streaming checkout
 - chunked-object: fallback checkout codepaths
 - bulk-checkin: support chunked-object encoding
 - bulk-checkin: allow the same data to be multiply hashed
 - new representation types in the packstream
 - packfile: use varint functions
 + varint: make it available outside the context of pack
 (this branch is tangled with jc/index-v4.)

Not ready.

I finished the streaming checkout codepath, but as explained in
127b177 (bulk-checkin: support chunked-object encoding, 2011-11-30),
these are still early steps of a long and painful journey. At least
pack-objects and fsck need to learn the new encoding for the series
to be usable locally, and then index-pack/unpack-objects needs to
learn it to be used remotely.

Given that I heard a lot of noise that people want large files, and
that I was asked by somebody at GitTogether'11 privately for an
advice on how to pay developers (not me) to help adding necessary
support, I am somewhat dissapointed that the original patch series
that was sent almost two months ago still remains here without much
comments and updates from the developer community. I even made the
interface to the logic that decides where to split chunks easily
replaceable, and I deliberately made the logic in the original patch
extremely stupid to entice others, especially the "bup" fanboys, to
come up with a better logic, thinking that giving people an easy
target to shoot for, they may be encouraged to help out. The plan is
not working :-(.

--------------------------------------------------
[Cooking]

* jm/maint-strncpy-diff-no-index (2012-04-16) 1 commit
  (merged to 'next' on 2012-04-20 at 638ed9f)
 + diff: avoid stack-buffer-read-overrun for very long name

* lp/diffstat-with-graph (2012-04-18) 6 commits
 - Prevent graph_width of stat width from falling below min
 - t4052: Test diff-stat output with minimum columns
 - t4052: Adjust --graph --stat output for prefixes
 - Adjust stat width calculations to take --graph output into account
 - Add output_prefix_length to diff_options
 - t4052: test --stat output with --graph

Looked reasonable.
Will merge to 'next'.

* jc/merge-reduce-parents-early (2012-04-18) 5 commits
 - fmt-merge-msg: discard needless merge parents
 - builtin/merge.c: reduce parents early
 - builtin/merge.c: collect other parents early
 - builtin/merge.c: remove "remoteheads" global variable
 - merge tests: octopus with redundant parents
 (this branch is tangled with lt/octopus-simplify.)

I based this and Linus's on top of the same test script, but it
turns out that this is more correct way to deal with the issue, so
I'll drop the other one.

* rj/mingw-isguid (2012-04-18) 1 commit
  (merged to 'next' on 2012-04-20 at 9dbebca)
 + compat/mingw.h: Set S_ISUID to prevent a fast-import test failure

* rj/sh-setup-mswin-pwd (2012-04-18) 1 commit
  (merged to 'next' on 2012-04-20 at 6125f8d)
 + git-sh-setup.sh: Add an pwd() function for MinGW

* rj/submodule-mswin-path (2012-04-18) 1 commit
  (merged to 'next' on 2012-04-20 at fd9f8b3)
 + git-submodule.sh: Don't use $path variable in eval_gettext string

* lp/maint-diff-three-dash-with-graph (2012-03-20) 3 commits
  (merged to 'next' on 2012-04-20 at b6cf0ff)
 + t4202: add test for "log --graph --stat -p" separator lines
 + log --graph: fix break in graph lines
 + log --graph --stat: three-dash separator should come after graph lines

* cb/cherry-pick-rev-path-confusion (2012-04-15) 1 commit
 - cherry-pick: do not expect file arguments

The command line parser choked "git cherry-pick $name" when $name can be
both revision name and a pathname, even though $name can never be a path
in the context of the command.

The issue the patch addresses is real, but the way it is implemented felt
unnecessarily invasive a bit.  It may be cleaner for this caller to add
the "--" to the end of the argv_array it passes to setup_revisions().

* cb/daemon-test-race-fix (2012-04-19) 1 commit
 - git-daemon wrapper to wait until daemon is ready

Fix race condition between starting and waiting for git-daemon in the
test.

Re-queued with a fix.

* cb/maint-report-mount-point-correctly-in-setup (2012-04-15) 1 commit
 - properly keep track of current working directory

The filesystem boundary was not correctly reported when .git directory
discovery stopped at a mount point.

Will merge to 'next'.

* jl/maint-submodule-recurse-fetch (2012-04-14) 1 commit
  (merged to 'next' on 2012-04-20 at 2769d39)
 + submodules: recursive fetch also checks new tags for submodule commits

* jn/fast-import-doc (2012-04-15) 1 commit
  (merged to 'next' on 2012-04-20 at b9a7250)
 + fast-import doc: cat-blob and ls responses need to be consumed quickly

* jn/more-i18ncmp (2012-04-14) 3 commits
  (merged to 'next' on 2012-04-20 at b5548a3)
 + test: am of empty patch should not succeed
 + test: use test_i18ncmp for "Patch format detection failed" message
 + test: do not rely on US English tracking-info messages

* rl/maint-stash-i18n-save-error (2012-04-14) 1 commit
 - stash: use eval_gettextln correctly

Will merge to 'next'.

* nd/columns (2012-04-15) 9 commits
 - tag: add --column
 - column: support piping stdout to external git-column process
 - status: add --column
 - branch: add --column
 - help: reuse print_columns() for help -a
 - column: add dense layout support
 - column: add columnar layout
 - Stop starting pager recursively
 - Add column layout skeleton and git-column

Will merge to 'next'.

* nl/http-proxy-more (2012-04-19) 7 commits
 - http: fix proxy password passing
 - http: fix proxy authentication
 - http: rename HTTP_REAUTH to HTTP_AUTH_RETRY
 - http: Avoid limit of retrying request only twice
 - http: handle proxy authentication failure (error 407)
 - http: handle proxy proactive authentication
 - http: try http_proxy env var when http.proxy config option is not set

The code to talk to http proxies learn to use the same credential
API used to talk to the final http destinations.  This still needs
to peek into $ENV{HTTPS_PROXY}.

* mb/fetch-call-a-non-branch-a-ref (2012-04-17) 2 commits
  (merged to 'next' on 2012-04-20 at df2c57e)
 + fetch: describe new refs based on where it came from
 + fetch: Give remote_ref to update_local_ref() as well

* mh/ref-api (2012-04-10) 13 commits
  (merged to 'next' on 2012-04-20 at 94e9384)
 + do_for_each_ref(): only iterate over the subtree that was requested
 + refs: store references hierarchically
 + sort_ref_dir(): simplify logic
 + refs.c: rename ref_array -> ref_dir
 + struct ref_entry: nest the value part in a union
 + check_refname_component(): return 0 for zero-length components
 + free_ref_entry(): new function
 + names_conflict(): simplify implementation
 + repack_without_ref(): reimplement using do_for_each_ref_in_array()
 + do_for_each_ref_in_arrays(): new function
 + do_for_each_ref_in_array(): new function
 + refs: manage current_ref within do_one_ref()
 + refs.c: reorder definitions more logically

Allows walking only a sub-hierarchy in refs/*.

* jc/maint-blame-minimal (2012-04-11) 1 commit
  (merged to 'next' on 2012-04-20 at 2213284)
 + blame: accept --need-minimal

"git blame" started missing quite a few changes from the origin since we
stopped using the diff minimalization by default in v1.7.2 era.

* jk/repack-no-explode-objects-from-old-pack (2012-04-18) 4 commits
  (merged to 'next' on 2012-04-20 at 4eb2534)
 + gc: use argv-array for sub-commands
 + argv-array: add a new "pushl" method
 + argv-array: refactor empty_argv initialization
  (merged to 'next' on 2012-04-15 at 7586e50)
 + gc: do not explode objects which will be immediately pruned

* ld/git-p4-tags-and-labels (2012-04-11) 2 commits
  (merged to 'next' on 2012-04-15 at 1b1e9a1)
 + git p4: import/export of labels to/from p4
 + git p4: Fixing script editor checks
 (this branch uses pw/git-p4.)

A review from Pete Wyckoff needs to be addressed.
Message-ID: <20120418113422.GB19994@padd.com>

* nh/empty-rebase (2012-04-20) 7 commits
 - fixup! git-rebase: add keep_empty flag
 - git-rebase: add keep_empty flag
 - fixup! git-cherry-pick: Add test to validate new options
 - git-cherry-pick: Add test to validate new options
 - fixup! git-cherry-pick: Add keep-redundant-commits option
 - git-cherry-pick: Add keep-redundant-commits option
 - git-cherry-pick: add allow-empty option

* sl/test-wc-l-line-count (2012-04-11) 1 commit
  (merged to 'next' on 2012-04-15 at 40797d9)
 + tests: modernise style: more uses of test_line_count

Will merge to 'master'.

* zj/upstream-error-message (2012-04-15) 5 commits
  (merged to 'next' on 2012-04-20 at 1ed9682)
 + i18n: mark @{upstream} error messages for translation
 + Be more specific if upstream branch is not tracked
 + Provide better message for barnhc_wiht_tpyo@{u}
 + Provide branch name in error message when using @{u}
 + t1507: add tests to document @{upstream} behaviour

* fc/completion-tests (2012-04-18) 7 commits
 - tests: add tests for the __gitcomp() completion helper function
 - completion: fix completion after 'git --option <TAB>'
 - completion: avoid trailing space for --exec-path
 - completion: add missing general options
 - completion: simplify by using $prev
 - completion: simplify __gitcomp_1
 - tests: add initial bash completion tests

Will merge to 'next'.

* jh/apply-free-patch (2012-04-11) 9 commits
  (merged to 'next' on 2012-04-15 at 8cccf57)
 + apply: document buffer ownership rules across functions
 + apply: tighten constness of line buffer
 + apply: drop unused macro
 + apply: free unused fragments for submodule patch
 + apply: free patch->result
 + apply: release memory for fn_table
 + apply: free patch->{def,old,new}_name fields
 + apply: rename free_patch() to free_patch_list()
 + apply: do not leak patches and fragments

Valgrind reports quite a lot of discarded memory inside apply.

* nd/threaded-index-pack (2012-04-19) 4 commits
 - index-pack: disable threading if NO_PREAD is defined
 - index-pack: support multithreaded delta resolving
 - index-pack: split second pass obj handling into own function
 - compat/win32/pthread.h: Add an pthread_key_delete() implementation

* cb/http-multi-curl-auth (2012-04-14) 4 commits
 - http: use newer curl options for setting credentials
 - http: clean up leak in init_curl_http_auth
 - fix http auth with multiple curl handles
 - http auth fails with multiple curl handles

Fixes http authentication breakage when we keep multiple HTTP requests in
flight using curl-multi.

Will merge to 'next'.

* jk/rebase-i-submodule-conflict-only (2012-04-09) 1 commit
  (merged to 'next' on 2012-04-15 at 94367a8)
 + rebase -i continue: don't skip commits that only change submodules

Giving "--continue" to a conflicted "rebase -i" session skipped a commit
that only results in changes to submodules.

Will merge to 'master'.

* ms/remote-usage-string (2012-04-09) 1 commit
  (merged to 'next' on 2012-04-15 at 704be8f)
 + remote: update builtin usage

As an independent follow-up, we may want to rethink how the overall usage
string and subcommand usage strings are maintained.

Will merge to 'master'.

* pw/fast-import-dataref-parsing (2012-04-10) 1 commit
  (merged to 'next' on 2012-04-20 at c299a63)
 + fast-import: tighten parsing of datarefs

* pw/git-p4 (2012-04-09) 3 commits
  (merged to 'next' on 2012-04-15 at 81ea41a)
 + git p4: use "git p4" directly in tests
 + git p4: update name in script
 + git-p4: move to toplevel
 (this branch is used by ld/git-p4-tags-and-labels.)

Will merge to 'master'.

* rl/show-empty-prefix (2012-04-10) 1 commit
  (merged to 'next' on 2012-04-15 at b2e5938)
 + rev-parse --show-prefix: add in trailing newline

Will merge to 'master'.

* tr/xdiff-fast-hash (2012-04-09) 1 commit
 - xdiff: load full words in the inner loop of xdl_hash_record

Will merge to 'next'.

* jc/index-v4 (2012-04-04) 10 commits
  (merged to 'next' on 2012-04-19 at 5e4b029)
 + update-index: upgrade/downgrade on-disk index version
 + read-cache.c: write prefix-compressed names in the index
 + read-cache.c: read prefix-compressed names in index on-disk version v4
 + read-cache.c: move code to copy incore to ondisk cache to a helper function
 + read-cache.c: move code to copy ondisk to incore cache to a helper function
 + read-cache.c: report the header version we do not understand
 + read-cache.c: make create_from_disk() report number of bytes it consumed
 + read-cache.c: allow unaligned mapping of the index file
 + cache.h: hide on-disk index details
 + varint: make it available outside the context of pack
 (this branch is tangled with jc/split-blob.)

Trivially shrinks the on-disk size of the index file to save both I/O and
checksum overhead.  The "v4" format represented here may not be what we
eventually want to have, but the preparatory refactoring steps and the way
how backward compatibility is retained should give plenty to learn to GSoC
student-hopefuls.

The bottom one makes use of "varint" encoding from the stalled
jc/split-blob topic.

* mk/gitweb-diff-hl (2012-04-11) 8 commits
  (merged to 'next' on 2012-04-20 at 54179a2)
 + gitweb: Refinement highlightning in combined diffs
 + gitweb: Highlight interesting parts of diff
 + gitweb: Push formatting diff lines to print_diff_chunk()
 + gitweb: Use print_diff_chunk() for both side-by-side and inline diffs
 + gitweb: Extract print_sidebyside_diff_lines()
 + gitweb: Pass esc_html_hl_regions() options to esc_html()
 + gitweb: esc_html_hl_regions(): Don't create empty <span> elements
 + gitweb: Use descriptive names in esc_html_hl_regions()

* it/fetch-pack-many-refs (2012-04-10) 4 commits
  (merged to 'next' on 2012-04-20 at e2126d7)
 + remote-curl: main test case for the OS command line overflow
 + fetch-pack: test cases for the new --stdin option
 + remote-curl: send the refs to fetch-pack on stdin
 + fetch-pack: new --stdin option to read refs from stdin

* jn/debian-customizes-default-editor (2012-04-10) 2 commits
  (merged to 'next' on 2012-04-15 at 0fc85c3)
 + var doc: advertise current DEFAULT_PAGER and DEFAULT_EDITOR settings
 + var doc: default editor and pager are configurable at build time

Will merge to 'master'.

* rs/commit-list-sort-in-batch (2012-04-17) 4 commits
  (merged to 'next' on 2012-04-17 at 21208e9)
 + mergesort: rename it to llist_mergesort()
  (merged to 'next' on 2012-04-15 at 39fe527)
 + revision: insert unsorted, then sort in prepare_revision_walk()
 + commit: use mergesort() in commit_list_sort_by_date()
 + add mergesort() for linked lists

* hv/submodule-recurse-push (2012-03-30) 3 commits
  (merged to 'next' on 2012-04-20 at fe99e3d)
 + push: teach --recurse-submodules the on-demand option
 + Refactor submodule push check to use string list instead of integer
 + Teach revision walking machinery to walk multiple times sequencially

* th/difftool-diffall (2012-04-14) 8 commits
 - difftool: print list of valid tools with '--tool-help'
 - difftool: teach difftool to handle directory diffs
 - difftool: eliminate setup_environment function
 - difftool: stop appending '.exe' to git
 - difftool: remove explicit change of PATH
 - difftool: exit(0) when usage is printed
 - difftool: add '--no-gui' option
 - difftool: parse options using Getopt::Long

Rolls the two-directory-diff logic from diffall script (in contrib/) into
"git difftool" framework. 

Still being reworked.

* jc/run-hook-env-1 (2012-03-11) 1 commit
 - run_hook(): enhance the interface to pass arbitrary environment

Not urgent.

Updates run_hook() API to be much less specific to "commit".  It would
only be useful if people start doing more interesting things with hooks.

* mm/push-default-switch-warning (2012-04-20) 4 commits
 - push: start warning upcoming default change for push.default
 - t5570: use explicit push refspec
 - push: introduce new push.default mode "simple"
 - Documentation: explain push.default option a bit more

This resurrects an ancient patch I wrote during a discussion we had in the
1.6.3-1.6.4 era.  This should probably come after ct/advise-push-default
topic and at that point the advise messages need to be rephrased, taking
the future default change into account.

--------------------------------------------------
[Discarded]

* cn/apply-fix-ws-can-lengthen-lines (2012-03-11) 1 commit
 . apply: reallocate the postimage buffer when needed

Attempts to address an ancient bug that dates back to the addition
of an oddball "tab-in-indent" whitespace breakage class that wants
to have longer lines than the original when fixing things up; broken
and results in double-frees.

* ss/git-svn-prompt-sans-terminal (2012-01-04) 3 commits
 . fixup! 15eaaf4
 . git-svn, perl/Git.pm: extend Git::prompt helper for querying users
 . perl/Git.pm: "prompt" helper to honor GIT_ASKPASS and SSH_ASKPASS

Has been stalled for too long.

* lt/octopus-simplify (2012-04-17) 3 commits
 . git-merge: Reduce heads before trying to merge them
 . Make 'git merge' simplify parents earlier
 - merge tests: octopus with redundant parents
 (this branch is tangled with jc/merge-reduce-parents-early.)

Octopus merge strategy did not reduce heads that are recorded in the final
commit, but follow-up broke badly.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-21  0:06 What's cooking in git.git (Apr 2012, #08; Fri, 20) Junio C Hamano
@ 2012-04-21 10:23 ` SZEDER Gábor
  2012-04-22  5:25   ` Junio C Hamano
  2012-04-22 15:07 ` Johannes Sixt
  1 sibling, 1 reply; 7+ messages in thread
From: SZEDER Gábor @ 2012-04-21 10:23 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Hi,

On Fri, Apr 20, 2012 at 05:06:20PM -0700, Junio C Hamano wrote:
> * fc/completion-tests (2012-04-18) 7 commits
>  - tests: add tests for the __gitcomp() completion helper function
>  - completion: fix completion after 'git --option <TAB>'
>  - completion: avoid trailing space for --exec-path
>  - completion: add missing general options
>  - completion: simplify by using $prev
>  - completion: simplify __gitcomp_1
>  - tests: add initial bash completion tests

Perhaps you could move 'tests: add tests for the __gitcomp()
completion helper function' from the top after 'tests: add initial
bash completion tests', to show that Felipe's 'completion: simplify
__gitcomp_1' doesn't break any of the tests.


Best,
Gábor

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-21 10:23 ` SZEDER Gábor
@ 2012-04-22  5:25   ` Junio C Hamano
  2012-04-22 15:05     ` Felipe Contreras
  0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2012-04-22  5:25 UTC (permalink / raw)
  To: SZEDER Gábor, Felipe Contreras; +Cc: git

SZEDER Gábor <szeder@ira.uka.de> writes:

> On Fri, Apr 20, 2012 at 05:06:20PM -0700, Junio C Hamano wrote:
>> * fc/completion-tests (2012-04-18) 7 commits
>>  - tests: add tests for the __gitcomp() completion helper function
>>  - completion: fix completion after 'git --option <TAB>'
>>  - completion: avoid trailing space for --exec-path
>>  - completion: add missing general options
>>  - completion: simplify by using $prev
>>  - completion: simplify __gitcomp_1
>>  - tests: add initial bash completion tests
>
> Perhaps you could move 'tests: add tests for the __gitcomp()
> completion helper function' from the top after 'tests: add initial
> bash completion tests', to show that Felipe's 'completion: simplify
> __gitcomp_1' doesn't break any of the tests.

I don't mind.  Felipe, what do you think?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-22  5:25   ` Junio C Hamano
@ 2012-04-22 15:05     ` Felipe Contreras
  0 siblings, 0 replies; 7+ messages in thread
From: Felipe Contreras @ 2012-04-22 15:05 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: SZEDER Gábor, git

On Sun, Apr 22, 2012 at 8:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> On Fri, Apr 20, 2012 at 05:06:20PM -0700, Junio C Hamano wrote:
>>> * fc/completion-tests (2012-04-18) 7 commits
>>>  - tests: add tests for the __gitcomp() completion helper function
>>>  - completion: fix completion after 'git --option <TAB>'
>>>  - completion: avoid trailing space for --exec-path
>>>  - completion: add missing general options
>>>  - completion: simplify by using $prev
>>>  - completion: simplify __gitcomp_1
>>>  - tests: add initial bash completion tests
>>
>> Perhaps you could move 'tests: add tests for the __gitcomp()
>> completion helper function' from the top after 'tests: add initial
>> bash completion tests', to show that Felipe's 'completion: simplify
>> __gitcomp_1' doesn't break any of the tests.
>
> I don't mind.  Felipe, what do you think?

Fine by me.

-- 
Felipe Contreras

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-21  0:06 What's cooking in git.git (Apr 2012, #08; Fri, 20) Junio C Hamano
  2012-04-21 10:23 ` SZEDER Gábor
@ 2012-04-22 15:07 ` Johannes Sixt
  2012-04-25 18:14   ` Tim Henigan
  1 sibling, 1 reply; 7+ messages in thread
From: Johannes Sixt @ 2012-04-22 15:07 UTC (permalink / raw)
  To: Tim Henigan; +Cc: Junio C Hamano, git

Am 21.04.2012 02:06, schrieb Junio C Hamano:
> * th/difftool-diffall (2012-04-14) 8 commits
>   - difftool: print list of valid tools with '--tool-help'
>   - difftool: teach difftool to handle directory diffs
>   - difftool: eliminate setup_environment function
>   - difftool: stop appending '.exe' to git
>   - difftool: remove explicit change of PATH
>   - difftool: exit(0) when usage is printed
>   - difftool: add '--no-gui' option
>   - difftool: parse options using Getopt::Long
> 
> Rolls the two-directory-diff logic from diffall script (in contrib/) into
> "git difftool" framework.

This does not pass test 33 (the last one) on Windows:

+++ git difftool --dir-diff --extcmd ls branch
Use of uninitialized value in length at d:/Src/mingw-git/git-difftool line 55.
Use of uninitialized value in length at d:/Src/mingw-git/git-difftool line 55.
exiting now at d:/Src/mingw-git/git-difftool line 120.
usage: git diff [--no-index] <path> <path>
diff --raw --no-abbrev -z branch: command returned error: 129

("exiting now" is a debugging "warn" call that I inserted)

I don't know what's going on. One possibility is that an old Git.pm is
being used, because I haven't 'make install' yet.

I'm not going to look into this, but I can run tests if you tell me what
to do.

-- Hannes

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-22 15:07 ` Johannes Sixt
@ 2012-04-25 18:14   ` Tim Henigan
  2012-04-26  6:31     ` Johannes Sixt
  0 siblings, 1 reply; 7+ messages in thread
From: Tim Henigan @ 2012-04-25 18:14 UTC (permalink / raw)
  To: Johannes Sixt; +Cc: Junio C Hamano, git, Ramsay Jones

On Sun, Apr 22, 2012 at 11:07 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 21.04.2012 02:06, schrieb Junio C Hamano:
>> * th/difftool-diffall (2012-04-14) 8 commits
>>   - difftool: print list of valid tools with '--tool-help'
>>   - difftool: teach difftool to handle directory diffs
>>   - difftool: eliminate setup_environment function
>>   - difftool: stop appending '.exe' to git
>>   - difftool: remove explicit change of PATH
>>   - difftool: exit(0) when usage is printed
>>   - difftool: add '--no-gui' option
>>   - difftool: parse options using Getopt::Long
>>
>> Rolls the two-directory-diff logic from diffall script (in contrib/) into
>> "git difftool" framework.
>
> This does not pass test 33 (the last one) on Windows:

I now have a working test environment using msysgit on Windows 7
32-bit.  I updated to the tip of 'pu' (on my clone this is commit
5224ba8) and was able to run all 33 tests in t7800 without error.


> +++ git difftool --dir-diff --extcmd ls branch
> Use of uninitialized value in length at d:/Src/mingw-git/git-difftool line 55.
> Use of uninitialized value in length at d:/Src/mingw-git/git-difftool line 55.

The above 2 warnings were fixed in a later version of patch series.


> exiting now at d:/Src/mingw-git/git-difftool line 120.
> usage: git diff [--no-index] <path> <path>
> diff --raw --no-abbrev -z branch: command returned error: 129
>
> ("exiting now" is a debugging "warn" call that I inserted)
>
> I don't know what's going on. One possibility is that an old Git.pm is
> being used, because I haven't 'make install' yet.
>
> I'm not going to look into this, but I can run tests if you tell me what
> to do.

I have run into issues in the past on Linux where testing without
running 'make install' causes trouble, but never had time to track it
down.

Would it be possible for you to update to the latest tip of 'pu' and
then 'make install && (cd t && sh t7800-difftool.sh)'?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: What's cooking in git.git (Apr 2012, #08; Fri, 20)
  2012-04-25 18:14   ` Tim Henigan
@ 2012-04-26  6:31     ` Johannes Sixt
  0 siblings, 0 replies; 7+ messages in thread
From: Johannes Sixt @ 2012-04-26  6:31 UTC (permalink / raw)
  To: Tim Henigan; +Cc: Junio C Hamano, git, Ramsay Jones

Am 25.04.2012 20:14, schrieb Tim Henigan:
> I now have a working test environment using msysgit on Windows 7
> 32-bit.  I updated to the tip of 'pu' (on my clone this is commit
> 5224ba8) and was able to run all 33 tests in t7800 without error.

pu passes for me as well, but I'm carrying around this change

-                       $opts{Repository} = abs_path($dir);
+                       $opts{Repository} = $dir;

in my local git repository. No surprise that "difftool --dir-diff from 
subdirectory" fails with this patch.

So, all is well, and sorry for the noise and confusion.

-- Hannes

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-04-26  6:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-21  0:06 What's cooking in git.git (Apr 2012, #08; Fri, 20) Junio C Hamano
2012-04-21 10:23 ` SZEDER Gábor
2012-04-22  5:25   ` Junio C Hamano
2012-04-22 15:05     ` Felipe Contreras
2012-04-22 15:07 ` Johannes Sixt
2012-04-25 18:14   ` Tim Henigan
2012-04-26  6:31     ` Johannes Sixt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.