* [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB
@ 2017-09-05 7:49 Arnd Bergmann
2017-09-05 11:20 ` Christoph Hellwig
2017-09-05 12:24 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-09-05 7:49 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Christoph Hellwig, Johannes Thumshirn, Arnd Bergmann,
Hannes Reinicke, Finn Thain, linux-scsi, linux-kernel
Without CONFIG_BLK_DEV_BSGLIB, we get a link error here:
drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize':
scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue'
scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue'
drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch':
scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done'
This modifies the Kconfig 'select' statement accordingly, and matching
what we do for the other two scsi_transport implementations that use
bsglib.
Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index d145e0d90227..41366339b950 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -283,7 +283,7 @@ config SCSI_ISCSI_ATTRS
config SCSI_SAS_ATTRS
tristate "SAS Transport Attributes"
depends on SCSI
- select BLK_DEV_BSG
+ select BLK_DEV_BSGLIB
help
If you wish to export transport-specific information about
each attached SAS device to sysfs, say Y.
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB
2017-09-05 7:49 [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Arnd Bergmann
@ 2017-09-05 11:20 ` Christoph Hellwig
2017-09-05 12:24 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-09-05 11:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Christoph Hellwig,
Johannes Thumshirn, Hannes Reinicke, Finn Thain, linux-scsi,
linux-kernel
Thanks, this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB
2017-09-05 7:49 [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Arnd Bergmann
2017-09-05 11:20 ` Christoph Hellwig
@ 2017-09-05 12:24 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-09-05 12:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Christoph Hellwig,
Johannes Thumshirn, Hannes Reinicke, Finn Thain, linux-scsi,
linux-kernel
Arnd,
> Without CONFIG_BLK_DEV_BSGLIB, we get a link error here:
>
> drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize':
> scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue'
> scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue'
> drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch':
> scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done'
>
> This modifies the Kconfig 'select' statement accordingly, and matching
> what we do for the other two scsi_transport implementations that use
> bsglib.
>
> Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-05 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 7:49 [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Arnd Bergmann
2017-09-05 11:20 ` Christoph Hellwig
2017-09-05 12:24 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.