* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-19 22:04 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2015-11-19 22:04 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi
Cc: Don Brace, iss_storagedev, storagedev, linux-kernel,
martin.petersen, linux-arm-kernel
The hpsa driver recently started using the sas transport class, but it
does not ensure that the corresponding code is actually built, which
may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference to `sas_port_delete_phy'
(.text+0x1ce87c): undefined reference to `sas_phy_free'
drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
(.text+0x1ceba8): undefined reference to `sas_port_add'
drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference to `sas_attach_transport'
(.init.text+0x8868): undefined reference to `sas_release_transport
This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
for all other drivers using those functions.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
---
This showed up on the ARM randconfig builds today for the first time.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 04a720686516..64eed87d34a8 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -364,6 +364,7 @@ config SCSI_HPSA
tristate "HP Smart Array SCSI driver"
depends on PCI && SCSI
select CHECK_SIGNATURE
+ select SCSI_SAS_ATTRS
help
This driver supports HP Smart Array Controllers (circa 2009).
It is a SCSI alternative to the cciss driver, which is a block
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-19 22:04 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2015-11-19 22:04 UTC (permalink / raw)
To: linux-arm-kernel
The hpsa driver recently started using the sas transport class, but it
does not ensure that the corresponding code is actually built, which
may lead to a link error:
drivers/built-in.o: In function `hpsa_free_sas_phy':
(.text+0x1ce874): undefined reference to `sas_port_delete_phy'
(.text+0x1ce87c): undefined reference to `sas_phy_free'
drivers/built-in.o: In function `hpsa_alloc_sas_port':
(.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
(.text+0x1ceba8): undefined reference to `sas_port_add'
drivers/built-in.o: In function `hpsa_init':
(.init.text+0x8838): undefined reference to `sas_attach_transport'
(.init.text+0x8868): undefined reference to `sas_release_transport
This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
for all other drivers using those functions.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
---
This showed up on the ARM randconfig builds today for the first time.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 04a720686516..64eed87d34a8 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -364,6 +364,7 @@ config SCSI_HPSA
tristate "HP Smart Array SCSI driver"
depends on PCI && SCSI
select CHECK_SIGNATURE
+ select SCSI_SAS_ATTRS
help
This driver supports HP Smart Array Controllers (circa 2009).
It is a SCSI alternative to the cciss driver, which is a block
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
2015-11-19 22:04 ` Arnd Bergmann
@ 2015-11-20 10:37 ` Christoph Hellwig
-1 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2015-11-20 10:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, linux-scsi, Don Brace, iss_storagedev,
storagedev, linux-kernel, martin.petersen, linux-arm-kernel
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-20 10:37 ` Christoph Hellwig
0 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2015-11-20 10:37 UTC (permalink / raw)
To: linux-arm-kernel
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
2015-11-19 22:04 ` Arnd Bergmann
@ 2015-11-20 16:09 ` Don Brace
-1 siblings, 0 replies; 10+ messages in thread
From: Don Brace @ 2015-11-20 16:09 UTC (permalink / raw)
To: Arnd Bergmann, James E.J. Bottomley, linux-scsi
Cc: iss_storagedev, storagedev, linux-kernel, martin.petersen,
linux-arm-kernel
Signed-off-by: Don Brace <don.brace@pmcs.com>
And...Thanks!
On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> The hpsa driver recently started using the sas transport class, but it
> does not ensure that the corresponding code is actually built, which
> may lead to a link error:
>
> drivers/built-in.o: In function `hpsa_free_sas_phy':
> (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> (.text+0x1ce87c): undefined reference to `sas_phy_free'
> drivers/built-in.o: In function `hpsa_alloc_sas_port':
> (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> (.text+0x1ceba8): undefined reference to `sas_port_add'
> drivers/built-in.o: In function `hpsa_init':
> (.init.text+0x8838): undefined reference to `sas_attach_transport'
> (.init.text+0x8868): undefined reference to `sas_release_transport
>
> This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> for all other drivers using those functions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> ---
> This showed up on the ARM randconfig builds today for the first time.
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 04a720686516..64eed87d34a8 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -364,6 +364,7 @@ config SCSI_HPSA
> tristate "HP Smart Array SCSI driver"
> depends on PCI && SCSI
> select CHECK_SIGNATURE
> + select SCSI_SAS_ATTRS
> help
> This driver supports HP Smart Array Controllers (circa 2009).
> It is a SCSI alternative to the cciss driver, which is a block
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-20 16:09 ` Don Brace
0 siblings, 0 replies; 10+ messages in thread
From: Don Brace @ 2015-11-20 16:09 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Don Brace <don.brace@pmcs.com>
And...Thanks!
On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> The hpsa driver recently started using the sas transport class, but it
> does not ensure that the corresponding code is actually built, which
> may lead to a link error:
>
> drivers/built-in.o: In function `hpsa_free_sas_phy':
> (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> (.text+0x1ce87c): undefined reference to `sas_phy_free'
> drivers/built-in.o: In function `hpsa_alloc_sas_port':
> (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> (.text+0x1ceba8): undefined reference to `sas_port_add'
> drivers/built-in.o: In function `hpsa_init':
> (.init.text+0x8838): undefined reference to `sas_attach_transport'
> (.init.text+0x8868): undefined reference to `sas_release_transport
>
> This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> for all other drivers using those functions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> ---
> This showed up on the ARM randconfig builds today for the first time.
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 04a720686516..64eed87d34a8 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -364,6 +364,7 @@ config SCSI_HPSA
> tristate "HP Smart Array SCSI driver"
> depends on PCI && SCSI
> select CHECK_SIGNATURE
> + select SCSI_SAS_ATTRS
> help
> This driver supports HP Smart Array Controllers (circa 2009).
> It is a SCSI alternative to the cciss driver, which is a block
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
2015-11-20 16:09 ` Don Brace
@ 2015-11-20 16:21 ` James Bottomley
-1 siblings, 0 replies; 10+ messages in thread
From: James Bottomley @ 2015-11-20 16:21 UTC (permalink / raw)
To: Don Brace
Cc: Arnd Bergmann, linux-scsi, iss_storagedev, storagedev,
linux-kernel, martin.petersen, linux-arm-kernel
On Fri, 2015-11-20 at 10:09 -0600, Don Brace wrote:
> Signed-off-by: Don Brace <don.brace@pmcs.com>
You mean acked-by ... it can only be signed-off-by if *you* resend the
patch because signoffs track the patch transmission path.
James
> And...Thanks!
>
>
> On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> > The hpsa driver recently started using the sas transport class, but it
> > does not ensure that the corresponding code is actually built, which
> > may lead to a link error:
> >
> > drivers/built-in.o: In function `hpsa_free_sas_phy':
> > (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> > (.text+0x1ce87c): undefined reference to `sas_phy_free'
> > drivers/built-in.o: In function `hpsa_alloc_sas_port':
> > (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> > (.text+0x1ceba8): undefined reference to `sas_port_add'
> > drivers/built-in.o: In function `hpsa_init':
> > (.init.text+0x8838): undefined reference to `sas_attach_transport'
> > (.init.text+0x8868): undefined reference to `sas_release_transport
> >
> > This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> > for all other drivers using those functions.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> > ---
> > This showed up on the ARM randconfig builds today for the first time.
> >
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index 04a720686516..64eed87d34a8 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -364,6 +364,7 @@ config SCSI_HPSA
> > tristate "HP Smart Array SCSI driver"
> > depends on PCI && SCSI
> > select CHECK_SIGNATURE
> > + select SCSI_SAS_ATTRS
> > help
> > This driver supports HP Smart Array Controllers (circa 2009).
> > It is a SCSI alternative to the cciss driver, which is a block
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-20 16:21 ` James Bottomley
0 siblings, 0 replies; 10+ messages in thread
From: James Bottomley @ 2015-11-20 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2015-11-20 at 10:09 -0600, Don Brace wrote:
> Signed-off-by: Don Brace <don.brace@pmcs.com>
You mean acked-by ... it can only be signed-off-by if *you* resend the
patch because signoffs track the patch transmission path.
James
> And...Thanks!
>
>
> On 11/19/2015 04:04 PM, Arnd Bergmann wrote:
> > The hpsa driver recently started using the sas transport class, but it
> > does not ensure that the corresponding code is actually built, which
> > may lead to a link error:
> >
> > drivers/built-in.o: In function `hpsa_free_sas_phy':
> > (.text+0x1ce874): undefined reference to `sas_port_delete_phy'
> > (.text+0x1ce87c): undefined reference to `sas_phy_free'
> > drivers/built-in.o: In function `hpsa_alloc_sas_port':
> > (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num'
> > (.text+0x1ceba8): undefined reference to `sas_port_add'
> > drivers/built-in.o: In function `hpsa_init':
> > (.init.text+0x8838): undefined reference to `sas_attach_transport'
> > (.init.text+0x8868): undefined reference to `sas_release_transport
> >
> > This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
> > for all other drivers using those functions.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
> > ---
> > This showed up on the ARM randconfig builds today for the first time.
> >
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index 04a720686516..64eed87d34a8 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b/drivers/scsi/Kconfig
> > @@ -364,6 +364,7 @@ config SCSI_HPSA
> > tristate "HP Smart Array SCSI driver"
> > depends on PCI && SCSI
> > select CHECK_SIGNATURE
> > + select SCSI_SAS_ATTRS
> > help
> > This driver supports HP Smart Array Controllers (circa 2009).
> > It is a SCSI alternative to the cciss driver, which is a block
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
2015-11-19 22:04 ` Arnd Bergmann
@ 2015-11-20 16:42 ` Martin K. Petersen
-1 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2015-11-20 16:42 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, linux-scsi, Don Brace, iss_storagedev,
storagedev, linux-kernel, martin.petersen, linux-arm-kernel
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> The hpsa driver recently started using the sas transport class,
Arnd> but it does not ensure that the corresponding code is actually
Arnd> built, which may lead to a link error:
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR
@ 2015-11-20 16:42 ` Martin K. Petersen
0 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2015-11-20 16:42 UTC (permalink / raw)
To: linux-arm-kernel
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> The hpsa driver recently started using the sas transport class,
Arnd> but it does not ensure that the corresponding code is actually
Arnd> built, which may lead to a link error:
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-11-20 16:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 22:04 [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR Arnd Bergmann
2015-11-19 22:04 ` Arnd Bergmann
2015-11-20 10:37 ` Christoph Hellwig
2015-11-20 10:37 ` Christoph Hellwig
2015-11-20 16:09 ` Don Brace
2015-11-20 16:09 ` Don Brace
2015-11-20 16:21 ` James Bottomley
2015-11-20 16:21 ` James Bottomley
2015-11-20 16:42 ` Martin K. Petersen
2015-11-20 16:42 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.