* [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
@ 2018-03-26 13:56 ` Ross Lagerwall
0 siblings, 0 replies; 9+ messages in thread
From: Ross Lagerwall @ 2018-03-26 13:56 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Ross Lagerwall
The Windows Server 2016 iSCSI target doesn't work with the Linux kernel
initiator since the kernel started sending larger requests by default,
nor does it implement the block limits VPD page. Apply the sector limit
workaround for these targets.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
drivers/scsi/scsi_devinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b1172..5cb748a 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -213,7 +213,7 @@ static struct {
{"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
{"MICROP", "4110", NULL, BLIST_NOTQ},
- {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
+ {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
--
2.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
@ 2018-03-26 13:56 ` Ross Lagerwall
0 siblings, 0 replies; 9+ messages in thread
From: Ross Lagerwall @ 2018-03-26 13:56 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Ross Lagerwall
The Windows Server 2016 iSCSI target doesn't work with the Linux kernel
initiator since the kernel started sending larger requests by default,
nor does it implement the block limits VPD page. Apply the sector limit
workaround for these targets.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
drivers/scsi/scsi_devinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b1172..5cb748a 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -213,7 +213,7 @@ static struct {
{"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
{"MICROP", "4110", NULL, BLIST_NOTQ},
- {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
+ {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
--
2.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
2018-03-26 13:56 ` Ross Lagerwall
@ 2018-03-28 21:49 ` Martin K. Petersen
-1 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2018-03-28 21:49 UTC (permalink / raw)
To: Long Li, KY Srinivasan
Cc: Ross Lagerwall, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Long, KY: Please confirm.
> The Windows Server 2016 iSCSI target doesn't work with the Linux kernel
> initiator since the kernel started sending larger requests by default,
> nor does it implement the block limits VPD page. Apply the sector limit
> workaround for these targets.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
> drivers/scsi/scsi_devinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index f3b1172..5cb748a 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -213,7 +213,7 @@ static struct {
> {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
> {"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> {"MICROP", "4110", NULL, BLIST_NOTQ},
> - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
> {"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> {"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> {"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
@ 2018-03-28 21:49 ` Martin K. Petersen
0 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2018-03-28 21:49 UTC (permalink / raw)
To: Long Li, KY Srinivasan
Cc: Ross Lagerwall, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Long, KY: Please confirm.
> The Windows Server 2016 iSCSI target doesn't work with the Linux kernel
> initiator since the kernel started sending larger requests by default,
> nor does it implement the block limits VPD page. Apply the sector limit
> workaround for these targets.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
> drivers/scsi/scsi_devinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index f3b1172..5cb748a 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -213,7 +213,7 @@ static struct {
> {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
> {"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> {"MICROP", "4110", NULL, BLIST_NOTQ},
> - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
> {"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> {"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> {"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
2018-03-28 21:49 ` Martin K. Petersen
(?)
@ 2018-03-28 22:33 ` Long Li
2018-04-05 16:58 ` Ross Lagerwall
-1 siblings, 1 reply; 9+ messages in thread
From: Long Li @ 2018-03-28 22:33 UTC (permalink / raw)
To: Martin K. Petersen, KY Srinivasan
Cc: Ross Lagerwall, James E.J. Bottomley, linux-scsi, linux-kernel
> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
>
>
> Long, KY: Please confirm.
>
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it implement the block limits VPD page. Apply the
> > sector limit workaround for these targets.
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> > ---
> > drivers/scsi/scsi_devinfo.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> > index f3b1172..5cb748a 100644
> > --- a/drivers/scsi/scsi_devinfo.c
> > +++ b/drivers/scsi/scsi_devinfo.c
> > @@ -213,7 +213,7 @@ static struct {
> > {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
> > {"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> > {"MICROP", "4110", NULL, BLIST_NOTQ},
> > - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> > + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
Ross,
What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())
Does it return correctly the maximum transfer size for iSCSI?
Long
> > {"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> > {"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> > {"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN |
> BLIST_SINGLELUN},
>
> --
> Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
2018-03-28 22:33 ` Long Li
@ 2018-04-05 16:58 ` Ross Lagerwall
2018-04-05 19:52 ` KY Srinivasan
0 siblings, 1 reply; 9+ messages in thread
From: Ross Lagerwall @ 2018-04-05 16:58 UTC (permalink / raw)
To: Long Li, Martin K. Petersen, KY Srinivasan
Cc: James E.J. Bottomley, linux-scsi, linux-kernel
On 03/28/2018 11:33 PM, Long Li wrote:
>> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
>> blacklist
>>
>>
>> Long, KY: Please confirm.
>>
>>> The Windows Server 2016 iSCSI target doesn't work with the Linux
>>> kernel initiator since the kernel started sending larger requests by
>>> default, nor does it implement the block limits VPD page. Apply the
>>> sector limit workaround for these targets.
>>>
>>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>>> ---
>>> drivers/scsi/scsi_devinfo.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
>>> index f3b1172..5cb748a 100644
>>> --- a/drivers/scsi/scsi_devinfo.c
>>> +++ b/drivers/scsi/scsi_devinfo.c
>>> @@ -213,7 +213,7 @@ static struct {
>>> {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
>>> {"MegaRAID", "LD", NULL, BLIST_FORCELUN},
>>> {"MICROP", "4110", NULL, BLIST_NOTQ},
>>> - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
>>> + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
>
> Ross,
>
> What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())
>
> Does it return correctly the maximum transfer size for iSCSI?
>
I presume you're referring to the Hyper-V virtual storage driver? This
has nothing to do with that module -- I don't even have it compiled in.
It's just simply the Linux kernel initiator connecting over plain
software iSCSI to a Windows Server 2016 iSCSI target.
This is easy enough to reproduce. Just set up a Windows Server 2016
target and try and use it from Linux. You get I/O errors as soon as you
try and format the disk.
Cheers,
--
Ross Lagerwall
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
2018-04-05 16:58 ` Ross Lagerwall
@ 2018-04-05 19:52 ` KY Srinivasan
0 siblings, 0 replies; 9+ messages in thread
From: KY Srinivasan @ 2018-04-05 19:52 UTC (permalink / raw)
To: Ross Lagerwall, Long Li, Martin K. Petersen, Matt Kurjanowicz
Cc: James E.J. Bottomley, linux-scsi, linux-kernel
+Matt
> -----Original Message-----
> From: Ross Lagerwall <ross.lagerwall@citrix.com>
> Sent: Thursday, April 5, 2018 9:58 AM
> To: Long Li <longli@microsoft.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; KY Srinivasan <kys@microsoft.com>
> Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
>
> On 03/28/2018 11:33 PM, Long Li wrote:
> >> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024
> sector
> >> blacklist
> >>
> >>
> >> Long, KY: Please confirm.
> >>
> >>> The Windows Server 2016 iSCSI target doesn't work with the Linux
> >>> kernel initiator since the kernel started sending larger requests by
> >>> default, nor does it implement the block limits VPD page. Apply the
> >>> sector limit workaround for these targets.
> >>>
> >>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> >>> ---
> >>> drivers/scsi/scsi_devinfo.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> >>> index f3b1172..5cb748a 100644
> >>> --- a/drivers/scsi/scsi_devinfo.c
> >>> +++ b/drivers/scsi/scsi_devinfo.c
> >>> @@ -213,7 +213,7 @@ static struct {
> >>> {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN},
> >>> {"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> >>> {"MICROP", "4110", NULL, BLIST_NOTQ},
> >>> - {"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> >>> + {"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
> >
> > Ross,
> >
> > What about storage_channel_properties.max_transfer_bytes returned
> from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())
> >
> > Does it return correctly the maximum transfer size for iSCSI?
> >
>
> I presume you're referring to the Hyper-V virtual storage driver? This
> has nothing to do with that module -- I don't even have it compiled in.
> It's just simply the Linux kernel initiator connecting over plain
> software iSCSI to a Windows Server 2016 iSCSI target.
>
> This is easy enough to reproduce. Just set up a Windows Server 2016
> target and try and use it from Linux. You get I/O errors as soon as you
> try and format the disk.
Adding Matt for visibility. Ross, we are fine with blacklisting for now.
K. Y
>
> Cheers,
> --
> Ross Lagerwall
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
2018-03-26 13:56 ` Ross Lagerwall
@ 2018-04-10 2:07 ` Martin K. Petersen
-1 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2018-04-10 2:07 UTC (permalink / raw)
To: Ross Lagerwall
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Ross,
> The Windows Server 2016 iSCSI target doesn't work with the Linux
> kernel initiator since the kernel started sending larger requests by
> default, nor does it implement the block limits VPD page. Apply the
> sector limit workaround for these targets.
Applied to 4.17/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
@ 2018-04-10 2:07 ` Martin K. Petersen
0 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2018-04-10 2:07 UTC (permalink / raw)
To: Ross Lagerwall
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Ross,
> The Windows Server 2016 iSCSI target doesn't work with the Linux
> kernel initiator since the kernel started sending larger requests by
> default, nor does it implement the block limits VPD page. Apply the
> sector limit workaround for these targets.
Applied to 4.17/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-04-10 2:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 13:56 [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist Ross Lagerwall
2018-03-26 13:56 ` Ross Lagerwall
2018-03-28 21:49 ` Martin K. Petersen
2018-03-28 21:49 ` Martin K. Petersen
2018-03-28 22:33 ` Long Li
2018-04-05 16:58 ` Ross Lagerwall
2018-04-05 19:52 ` KY Srinivasan
2018-04-10 2:07 ` Martin K. Petersen
2018-04-10 2:07 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.