* [PATCH] scsi: qla2xxx: remove unnecessary NULL check
@ 2021-01-21 6:08 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2021-01-21 6:08 UTC (permalink / raw)
To: Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
The list iterator can't be NULL so this check is not required. Removing
the check silences a Smatch warning about inconsistent NULL checking.
drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
error: we previously assumed 'fcport' could be null (see line 372)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/qla2xxx/qla_dfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index ccce0eab844e..85bd0e468d43 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -369,7 +369,7 @@ qla_dfs_tgt_counters_show(struct seq_file *s, void *unused)
seq_puts(s, "\n");
list_for_each_entry(fcport, &vha->vp_fcports, list) {
- if (!fcport || !fcport->rport)
+ if (!fcport->rport)
continue;
seq_printf(s, "Target Num = %7d Link Down Count = %14lld\n",
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* RE: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
2021-01-21 6:08 ` Dan Carpenter
(?)
@ 2021-01-21 6:20 ` Saurav Kashyap
-1 siblings, 0 replies; 7+ messages in thread
From: Saurav Kashyap @ 2021-01-21 6:20 UTC (permalink / raw)
To: Dan Carpenter, Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Hi Dan,
Thanks for a patch.
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Thursday, January 21, 2021 11:39 AM
> To: Nilesh Javali <njavali@marvell.com>
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>; Martin
> K. Petersen <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
>
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/qla2xxx/qla_dfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
> index ccce0eab844e..85bd0e468d43 100644
> --- a/drivers/scsi/qla2xxx/qla_dfs.c
> +++ b/drivers/scsi/qla2xxx/qla_dfs.c
> @@ -369,7 +369,7 @@ qla_dfs_tgt_counters_show(struct seq_file *s, void
> *unused)
> seq_puts(s, "\n");
>
> list_for_each_entry(fcport, &vha->vp_fcports, list) {
> - if (!fcport || !fcport->rport)
> + if (!fcport->rport)
> continue;
>
> seq_printf(s, "Target Num = %7d Link Down Count = %14lld\n",
Acked-by: Saurav Kashyap <skashyap@marvell.com"
Thanks,
~Saurav
> --
> 2.29.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
2021-01-21 6:08 ` Dan Carpenter
@ 2021-01-23 3:04 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-23 3:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
@ 2021-01-23 3:04 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-23 3:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
2021-01-21 6:08 ` Dan Carpenter
@ 2021-01-27 4:54 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-27 4:54 UTC (permalink / raw)
To: Dan Carpenter, Nilesh Javali
Cc: Martin K . Petersen, James E.J. Bottomley,
GR-QLogic-Storage-Upstream, linux-scsi, kernel-janitors
On Thu, 21 Jan 2021 09:08:41 +0300, Dan Carpenter wrote:
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/c750a9c9c59a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
@ 2021-01-27 4:54 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-27 4:54 UTC (permalink / raw)
To: Dan Carpenter, Nilesh Javali
Cc: Martin K . Petersen, James E.J. Bottomley,
GR-QLogic-Storage-Upstream, linux-scsi, kernel-janitors
On Thu, 21 Jan 2021 09:08:41 +0300, Dan Carpenter wrote:
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/c750a9c9c59a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread