* [PATCH v3] scsi: advansys needs ISA dma api for ISA support
@ 2015-11-19 14:22 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2015-11-19 14:22 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Hannes Reinecke, linux-scsi, linux-arm-kernel, linux-kernel
The advansys drvier uses the request_dma function that is used on ISA
machines for the internal DMA controller, which causes build errors
on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
The problem now showed up in ARM randconfig builds after commit
6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
warning") made it possible to build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This is identical to v1 of the patch. We had gone through several iterations
of this in October before concluding that everything else was more problematic.
Please apply.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 5f692ae40749..04a720686516 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -499,6 +499,7 @@ config SCSI_ADVANSYS
tristate "AdvanSys SCSI support"
depends on SCSI
depends on ISA || EISA || PCI
+ depends on ISA_DMA_API || !ISA
help
This is a driver for all SCSI host adapters manufactured by
AdvanSys. It is documented in the kernel source in
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3] scsi: advansys needs ISA dma api for ISA support
@ 2015-11-19 14:22 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2015-11-19 14:22 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: linux-arm-kernel, Hannes Reinecke, linux-scsi, linux-kernel
The advansys drvier uses the request_dma function that is used on ISA
machines for the internal DMA controller, which causes build errors
on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
The problem now showed up in ARM randconfig builds after commit
6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
warning") made it possible to build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This is identical to v1 of the patch. We had gone through several iterations
of this in October before concluding that everything else was more problematic.
Please apply.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 5f692ae40749..04a720686516 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -499,6 +499,7 @@ config SCSI_ADVANSYS
tristate "AdvanSys SCSI support"
depends on SCSI
depends on ISA || EISA || PCI
+ depends on ISA_DMA_API || !ISA
help
This is a driver for all SCSI host adapters manufactured by
AdvanSys. It is documented in the kernel source in
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3] scsi: advansys needs ISA dma api for ISA support
@ 2015-11-19 14:22 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2015-11-19 14:22 UTC (permalink / raw)
To: linux-arm-kernel
The advansys drvier uses the request_dma function that is used on ISA
machines for the internal DMA controller, which causes build errors
on platforms that have ISA slots but do not provide the ISA DMA API:
drivers/scsi/advansys.c: In function 'advansys_board_found':
drivers/scsi/advansys.c:11300:10: error: implicit declaration of function 'request_dma' [-Werror=implicit-function-declaration]
The problem now showed up in ARM randconfig builds after commit
6571fb3f8b7f ("advansys: Update to version 3.5 and remove compilation
warning") made it possible to build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds the missing dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This is identical to v1 of the patch. We had gone through several iterations
of this in October before concluding that everything else was more problematic.
Please apply.
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 5f692ae40749..04a720686516 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -499,6 +499,7 @@ config SCSI_ADVANSYS
tristate "AdvanSys SCSI support"
depends on SCSI
depends on ISA || EISA || PCI
+ depends on ISA_DMA_API || !ISA
help
This is a driver for all SCSI host adapters manufactured by
AdvanSys. It is documented in the kernel source in
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] scsi: advansys needs ISA dma api for ISA support
2015-11-19 14:22 ` Arnd Bergmann
@ 2015-11-20 10:37 ` Christoph Hellwig
-1 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2015-11-20 10:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Hannes Reinecke,
linux-scsi, linux-arm-kernel, linux-kernel
Loosk good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] scsi: advansys needs ISA dma api for ISA support
@ 2015-11-20 10:37 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2015-11-20 10:37 UTC (permalink / raw)
To: linux-arm-kernel
Loosk good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3] scsi: advansys needs ISA dma api for ISA support
2015-11-19 14:22 ` Arnd Bergmann
@ 2015-11-20 16:38 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2015-11-20 16:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen, Hannes Reinecke,
linux-scsi, linux-arm-kernel, linux-kernel
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> The advansys drvier uses the request_dma function that is used on
Arnd> ISA machines for the internal DMA controller, which causes build
Arnd> errors on platforms that have ISA slots but do not provide the ISA
Arnd> DMA API:
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] scsi: advansys needs ISA dma api for ISA support
@ 2015-11-20 16:38 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2015-11-20 16:38 UTC (permalink / raw)
To: linux-arm-kernel
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes:
Arnd> The advansys drvier uses the request_dma function that is used on
Arnd> ISA machines for the internal DMA controller, which causes build
Arnd> errors on platforms that have ISA slots but do not provide the ISA
Arnd> DMA API:
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-20 16:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 14:22 [PATCH v3] scsi: advansys needs ISA dma api for ISA support Arnd Bergmann
2015-11-19 14:22 ` Arnd Bergmann
2015-11-19 14:22 ` Arnd Bergmann
2015-11-20 10:37 ` Christoph Hellwig
2015-11-20 10:37 ` Christoph Hellwig
2015-11-20 16:38 ` Martin K. Petersen
2015-11-20 16:38 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.