[PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative

[PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative

[Jiapeng Chong]

The variable 'rv' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of rv to int.
if (rv < 0) {
	dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
		%d\n", rv);
	goto err_unlock;
}

./sound/soc/codecs/cs35l56.c:333:5-7: WARNING: Unsigned expression compared with zero: rv < 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4599
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 sound/soc/codecs/cs35l56.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
index 90fc79b5666d..d97b465f0d3c 100644
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -321,7 +321,9 @@ irqreturn_t cs35l56_irq(int irq, void *data)
 	struct cs35l56_private *cs35l56 = data;
 	unsigned int status1 = 0, status8 = 0, status20 = 0;
 	unsigned int mask1, mask8, mask20;
-	unsigned int rv, val;
+	unsigned int val;
+	int rv;
+
 	irqreturn_t ret = IRQ_NONE;
 
 	if (!cs35l56->init_done)
-- 
2.20.1.7.g153144c

Re: [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative

[Richard Fitzgerald via Alsa-devel]

[-- Attachment #0: Type: message/rfc822, Size: 6060 bytes --]

From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, <broonie@kernel.org>
Cc: tiwai@suse.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative
Date: Fri, 24 Mar 2023 10:29:15 +0000
Message-ID: <ceac5217-2fae-7d56-341f-6527ef3f538e@opensource.cirrus.com>

On 24/03/2023 02:23, Jiapeng Chong wrote:
> The variable 'rv' is defined as unsigned type, so the following if
> statement is invalid, we can modify the type of rv to int.
> if (rv < 0) {
> 	dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
> 		%d\n", rv);
> 	goto err_unlock;
> }
> 
> ./sound/soc/codecs/cs35l56.c:333:5-7: WARNING: Unsigned expression compared with zero: rv < 0.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4599
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   sound/soc/codecs/cs35l56.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
> index 90fc79b5666d..d97b465f0d3c 100644
> --- a/sound/soc/codecs/cs35l56.c
> +++ b/sound/soc/codecs/cs35l56.c
> @@ -321,7 +321,9 @@ irqreturn_t cs35l56_irq(int irq, void *data)
>   	struct cs35l56_private *cs35l56 = data;
>   	unsigned int status1 = 0, status8 = 0, status20 = 0;
>   	unsigned int mask1, mask8, mask20;
> -	unsigned int rv, val;
> +	unsigned int val;
> +	int rv;
> +
>   	irqreturn_t ret = IRQ_NONE;
>   
>   	if (!cs35l56->init_done)

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Re: [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative

[Mark Brown]

On Fri, 24 Mar 2023 10:23:03 +0800, Jiapeng Chong wrote:
> The variable 'rv' is defined as unsigned type, so the following if
> statement is invalid, we can modify the type of rv to int.
> if (rv < 0) {
> 	dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
> 		%d\n", rv);
> 	goto err_unlock;
> }
> 
> [...]

Applied to

   broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l56: Fix an unsigned comparison which can never be negative
      commit: ab76c891a687ae871f7e76dbf9bc3a0e32b53423

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark