alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [alsa-devel] [PATCH 09/17] fireface: register the size of PCM period to AMDTP domain
Date: Mon,  7 Oct 2019 20:05:24 +0900	[thread overview]
Message-ID: <20191007110532.30270-10-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20191007110532.30270-1-o-takashi@sakamocchi.jp>

This commit is a preparation to share the size of PCM period between
PCM substreams on AMDTP streams in the same domain. At this time,
the size of PCM period in PCM substream which starts AMDTP streams in the
same domain is recorded.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/fireface/ff-pcm.c    |  3 ++-
 sound/firewire/fireface/ff-stream.c | 11 ++++++++++-
 sound/firewire/fireface/ff.h        |  3 ++-
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/sound/firewire/fireface/ff-pcm.c b/sound/firewire/fireface/ff-pcm.c
index 9eab3ad283ce..4f2208202494 100644
--- a/sound/firewire/fireface/ff-pcm.c
+++ b/sound/firewire/fireface/ff-pcm.c
@@ -211,9 +211,10 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
 
 	if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN) {
 		unsigned int rate = params_rate(hw_params);
+		unsigned int frames_per_period = params_period_size(hw_params);
 
 		mutex_lock(&ff->mutex);
-		err = snd_ff_stream_reserve_duplex(ff, rate);
+		err = snd_ff_stream_reserve_duplex(ff, rate, frames_per_period);
 		if (err >= 0)
 			++ff->substreams_counter;
 		mutex_unlock(&ff->mutex);
diff --git a/sound/firewire/fireface/ff-stream.c b/sound/firewire/fireface/ff-stream.c
index e8e6f9fd6433..d05e7d3055e1 100644
--- a/sound/firewire/fireface/ff-stream.c
+++ b/sound/firewire/fireface/ff-stream.c
@@ -106,7 +106,8 @@ void snd_ff_stream_destroy_duplex(struct snd_ff *ff)
 	destroy_stream(ff, &ff->tx_stream);
 }
 
-int snd_ff_stream_reserve_duplex(struct snd_ff *ff, unsigned int rate)
+int snd_ff_stream_reserve_duplex(struct snd_ff *ff, unsigned int rate,
+				 unsigned int frames_per_period)
 {
 	unsigned int curr_rate;
 	enum snd_ff_clock_src src;
@@ -150,6 +151,14 @@ int snd_ff_stream_reserve_duplex(struct snd_ff *ff, unsigned int rate)
 		err = ff->spec->protocol->allocate_resources(ff, rate);
 		if (err < 0)
 			return err;
+
+		err = amdtp_domain_set_events_per_period(&ff->domain,
+							 frames_per_period);
+		if (err < 0) {
+			fw_iso_resources_free(&ff->tx_resources);
+			fw_iso_resources_free(&ff->rx_resources);
+			return err;
+		}
 	}
 
 	return 0;
diff --git a/sound/firewire/fireface/ff.h b/sound/firewire/fireface/ff.h
index b4c22ca6079e..970d4ae571ee 100644
--- a/sound/firewire/fireface/ff.h
+++ b/sound/firewire/fireface/ff.h
@@ -139,7 +139,8 @@ int snd_ff_stream_get_multiplier_mode(enum cip_sfc sfc,
 				      enum snd_ff_stream_mode *mode);
 int snd_ff_stream_init_duplex(struct snd_ff *ff);
 void snd_ff_stream_destroy_duplex(struct snd_ff *ff);
-int snd_ff_stream_reserve_duplex(struct snd_ff *ff, unsigned int rate);
+int snd_ff_stream_reserve_duplex(struct snd_ff *ff, unsigned int rate,
+				 unsigned int frames_per_period);
 int snd_ff_stream_start_duplex(struct snd_ff *ff, unsigned int rate);
 void snd_ff_stream_stop_duplex(struct snd_ff *ff);
 void snd_ff_stream_update_duplex(struct snd_ff *ff);
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-07 11:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 11:05 [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 01/17] firewire-lib: add a member into AMDTP domain for events per period Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 02/17] bebob: register the size of PCM period to AMDTP domain Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 03/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 04/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 05/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 06/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 07/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 08/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` Takashi Sakamoto [this message]
2019-10-07 11:05 ` [alsa-devel] [PATCH 10/17] bebob: use the same size of period for PCM substream in AMDTP streams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 11/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 12/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 13/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 14/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 15/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 16/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 17/17] fireface: use the same size of period for PCM substreams " Takashi Sakamoto
2019-10-17  7:41 ` [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007110532.30270-10-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).