alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [alsa-devel] [PATCH 02/17] bebob: register the size of PCM period to AMDTP domain
Date: Mon,  7 Oct 2019 20:05:17 +0900	[thread overview]
Message-ID: <20191007110532.30270-3-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20191007110532.30270-1-o-takashi@sakamocchi.jp>

This commit is a preparation to share the size of PCM period between
PCM substreams on AMDTP streams in the same domain. At this time,
the size of PCM period in PCM substream which starts AMDTP streams in the
same domain is recorded.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/bebob/bebob.h        |  3 ++-
 sound/firewire/bebob/bebob_midi.c   |  2 +-
 sound/firewire/bebob/bebob_pcm.c    |  4 +++-
 sound/firewire/bebob/bebob_stream.c | 11 ++++++++++-
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
index 356d6ba60959..8738c1d8abf7 100644
--- a/sound/firewire/bebob/bebob.h
+++ b/sound/firewire/bebob/bebob.h
@@ -217,7 +217,8 @@ int snd_bebob_stream_get_clock_src(struct snd_bebob *bebob,
 				   enum snd_bebob_clock_type *src);
 int snd_bebob_stream_discover(struct snd_bebob *bebob);
 int snd_bebob_stream_init_duplex(struct snd_bebob *bebob);
-int snd_bebob_stream_reserve_duplex(struct snd_bebob *bebob, unsigned int rate);
+int snd_bebob_stream_reserve_duplex(struct snd_bebob *bebob, unsigned int rate,
+				    unsigned int frames_per_period);
 int snd_bebob_stream_start_duplex(struct snd_bebob *bebob);
 void snd_bebob_stream_stop_duplex(struct snd_bebob *bebob);
 void snd_bebob_stream_destroy_duplex(struct snd_bebob *bebob);
diff --git a/sound/firewire/bebob/bebob_midi.c b/sound/firewire/bebob/bebob_midi.c
index 4d8805fa8a00..e8f9edf50be5 100644
--- a/sound/firewire/bebob/bebob_midi.c
+++ b/sound/firewire/bebob/bebob_midi.c
@@ -17,7 +17,7 @@ static int midi_open(struct snd_rawmidi_substream *substream)
 		return err;
 
 	mutex_lock(&bebob->mutex);
-	err = snd_bebob_stream_reserve_duplex(bebob, 0);
+	err = snd_bebob_stream_reserve_duplex(bebob, 0, 0);
 	if (err >= 0) {
 		++bebob->substreams_counter;
 		err = snd_bebob_stream_start_duplex(bebob);
diff --git a/sound/firewire/bebob/bebob_pcm.c b/sound/firewire/bebob/bebob_pcm.c
index 0fb9eed46837..3b2227abf8a9 100644
--- a/sound/firewire/bebob/bebob_pcm.c
+++ b/sound/firewire/bebob/bebob_pcm.c
@@ -197,9 +197,11 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
 
 	if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN) {
 		unsigned int rate = params_rate(hw_params);
+		unsigned int frames_per_period = params_period_size(hw_params);
 
 		mutex_lock(&bebob->mutex);
-		err = snd_bebob_stream_reserve_duplex(bebob, rate);
+		err = snd_bebob_stream_reserve_duplex(bebob, rate,
+						      frames_per_period);
 		if (err >= 0)
 			++bebob->substreams_counter;
 		mutex_unlock(&bebob->mutex);
diff --git a/sound/firewire/bebob/bebob_stream.c b/sound/firewire/bebob/bebob_stream.c
index 73fee991bd75..f1db3ddc3e00 100644
--- a/sound/firewire/bebob/bebob_stream.c
+++ b/sound/firewire/bebob/bebob_stream.c
@@ -554,7 +554,8 @@ static int keep_resources(struct snd_bebob *bebob, struct amdtp_stream *stream,
 	return cmp_connection_reserve(conn, amdtp_stream_get_max_payload(stream));
 }
 
-int snd_bebob_stream_reserve_duplex(struct snd_bebob *bebob, unsigned int rate)
+int snd_bebob_stream_reserve_duplex(struct snd_bebob *bebob, unsigned int rate,
+				    unsigned int frames_per_period)
 {
 	unsigned int curr_rate;
 	int err;
@@ -607,6 +608,14 @@ int snd_bebob_stream_reserve_duplex(struct snd_bebob *bebob, unsigned int rate)
 			cmp_connection_release(&bebob->out_conn);
 			return err;
 		}
+
+		err = amdtp_domain_set_events_per_period(&bebob->domain,
+							 frames_per_period);
+		if (err < 0) {
+			cmp_connection_release(&bebob->out_conn);
+			cmp_connection_release(&bebob->in_conn);
+			return err;
+		}
 	}
 
 	return 0;
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-07 11:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 11:05 [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 01/17] firewire-lib: add a member into AMDTP domain for events per period Takashi Sakamoto
2019-10-07 11:05 ` Takashi Sakamoto [this message]
2019-10-07 11:05 ` [alsa-devel] [PATCH 03/17] fireworks: register the size of PCM period to AMDTP domain Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 04/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 05/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 06/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 07/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 08/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 09/17] fireface: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 10/17] bebob: use the same size of period for PCM substream in AMDTP streams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 11/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 12/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 13/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 14/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 15/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 16/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 17/17] fireface: use the same size of period for PCM substreams " Takashi Sakamoto
2019-10-17  7:41 ` [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007110532.30270-3-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).