alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [alsa-devel] [PATCH 03/17] fireworks: register the size of PCM period to AMDTP domain
Date: Mon,  7 Oct 2019 20:05:18 +0900	[thread overview]
Message-ID: <20191007110532.30270-4-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20191007110532.30270-1-o-takashi@sakamocchi.jp>

This commit is a preparation to share the size of PCM period between
PCM substreams on AMDTP streams in the same domain. At this time,
the size of PCM period in PCM substream which starts AMDTP streams in the
same domain is recorded.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/fireworks/fireworks.h        |  3 ++-
 sound/firewire/fireworks/fireworks_midi.c   |  2 +-
 sound/firewire/fireworks/fireworks_pcm.c    |  4 +++-
 sound/firewire/fireworks/fireworks_stream.c | 11 ++++++++++-
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h
index 4cda297f8438..fc5f945a49ff 100644
--- a/sound/firewire/fireworks/fireworks.h
+++ b/sound/firewire/fireworks/fireworks.h
@@ -207,7 +207,8 @@ int snd_efw_command_get_sampling_rate(struct snd_efw *efw, unsigned int *rate);
 int snd_efw_command_set_sampling_rate(struct snd_efw *efw, unsigned int rate);
 
 int snd_efw_stream_init_duplex(struct snd_efw *efw);
-int snd_efw_stream_reserve_duplex(struct snd_efw *efw, unsigned int rate);
+int snd_efw_stream_reserve_duplex(struct snd_efw *efw, unsigned int rate,
+				  unsigned int frames_per_period);
 int snd_efw_stream_start_duplex(struct snd_efw *efw);
 void snd_efw_stream_stop_duplex(struct snd_efw *efw);
 void snd_efw_stream_update_duplex(struct snd_efw *efw);
diff --git a/sound/firewire/fireworks/fireworks_midi.c b/sound/firewire/fireworks/fireworks_midi.c
index a9f4a9630d15..e593f842ee8f 100644
--- a/sound/firewire/fireworks/fireworks_midi.c
+++ b/sound/firewire/fireworks/fireworks_midi.c
@@ -17,7 +17,7 @@ static int midi_open(struct snd_rawmidi_substream *substream)
 		goto end;
 
 	mutex_lock(&efw->mutex);
-	err = snd_efw_stream_reserve_duplex(efw, 0);
+	err = snd_efw_stream_reserve_duplex(efw, 0, 0);
 	if (err >= 0) {
 		++efw->substreams_counter;
 		err = snd_efw_stream_start_duplex(efw);
diff --git a/sound/firewire/fireworks/fireworks_pcm.c b/sound/firewire/fireworks/fireworks_pcm.c
index a7025dccc754..35fc95283423 100644
--- a/sound/firewire/fireworks/fireworks_pcm.c
+++ b/sound/firewire/fireworks/fireworks_pcm.c
@@ -231,9 +231,11 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
 
 	if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN) {
 		unsigned int rate = params_rate(hw_params);
+		unsigned int frames_per_period = params_period_size(hw_params);
 
 		mutex_lock(&efw->mutex);
-		err = snd_efw_stream_reserve_duplex(efw, rate);
+		err = snd_efw_stream_reserve_duplex(efw, rate,
+						    frames_per_period);
 		if (err >= 0)
 			++efw->substreams_counter;
 		mutex_unlock(&efw->mutex);
diff --git a/sound/firewire/fireworks/fireworks_stream.c b/sound/firewire/fireworks/fireworks_stream.c
index f2de304d2f26..0787d5c3b01b 100644
--- a/sound/firewire/fireworks/fireworks_stream.c
+++ b/sound/firewire/fireworks/fireworks_stream.c
@@ -181,7 +181,8 @@ static int keep_resources(struct snd_efw *efw, struct amdtp_stream *stream,
 	return cmp_connection_reserve(conn, amdtp_stream_get_max_payload(stream));
 }
 
-int snd_efw_stream_reserve_duplex(struct snd_efw *efw, unsigned int rate)
+int snd_efw_stream_reserve_duplex(struct snd_efw *efw, unsigned int rate,
+				  unsigned int frames_per_period)
 {
 	unsigned int curr_rate;
 	int err;
@@ -228,6 +229,14 @@ int snd_efw_stream_reserve_duplex(struct snd_efw *efw, unsigned int rate)
 			cmp_connection_release(&efw->in_conn);
 			return err;
 		}
+
+		err = amdtp_domain_set_events_per_period(&efw->domain,
+							 frames_per_period);
+		if (err < 0) {
+			cmp_connection_release(&efw->in_conn);
+			cmp_connection_release(&efw->out_conn);
+			return err;
+		}
 	}
 
 	return 0;
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-07 11:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 11:05 [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 01/17] firewire-lib: add a member into AMDTP domain for events per period Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 02/17] bebob: register the size of PCM period to AMDTP domain Takashi Sakamoto
2019-10-07 11:05 ` Takashi Sakamoto [this message]
2019-10-07 11:05 ` [alsa-devel] [PATCH 04/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 05/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 06/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 07/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 08/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 09/17] fireface: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 10/17] bebob: use the same size of period for PCM substream in AMDTP streams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 11/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 12/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 13/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 14/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 15/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 16/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 17/17] fireface: use the same size of period for PCM substreams " Takashi Sakamoto
2019-10-17  7:41 ` [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007110532.30270-4-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).