Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control

Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

On Wed, Feb 12, 2020 at 01:59:49AM +0000, Jack Yu wrote:
> Fix typo for "Bypass Boost" control.

This doesn't apply against current code, please check and resend.  Also
this is more of a cut'n'paste error than a typo.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control

[Jack Yu]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Hi Mark,

I've generated the patch again from latest "for-next" branch but still get the same patch like attached file,
not sure what's wrong with this patch? Could you please help specify what's wrong with this patch?
Thank you very much!

Regards,
Jack



> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Friday, February 14, 2020 5:04 AM
> To: Jack Yu
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu); 陳昶志; kent_chen@realtek.com [陳建宏]; Mingjane Hsieh;
> Oder Chiou; Shuming [范書銘]; Derek [方德義]
> Subject: Re: [PATCH] ASoC: rt1015: fix typo for bypass boost control
> 
> On Wed, Feb 12, 2020 at 01:59:49AM +0000, Jack Yu wrote:
> > Fix typo for "Bypass Boost" control.
> 
> This doesn't apply against current code, please check and resend.  Also
> this is more of a cut'n'paste error than a typo.
> 
> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0001-ASoC-rt1015-fix-typo-for-bypass-boost-control.patch --]
[-- Type: application/octet-stream, Size: 1638 bytes --]

From 69d66cd098bef69e12ffc39669fd1c806838162c Mon Sep 17 00:00:00 2001
From: Jack Yu <jack.yu@realtek.com>
Date: Fri, 14 Feb 2020 17:04:40 +0800
Subject: [PATCH v2] ASoC: rt1015: fix typo for bypass boost control

Fix typo for "Bypass Boost" control.

Signed-off-by: Jack Yu <jack.yu@realtek.com>
---
 sound/soc/codecs/rt1015.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c
index 6d490e2dbc25..d300b417dd50 100644
--- a/sound/soc/codecs/rt1015.c
+++ b/sound/soc/codecs/rt1015.c
@@ -444,7 +444,7 @@ static int rt1015_boost_mode_put(struct snd_kcontrol *kcontrol,
 	return 0;
 }
 
-static int rt5518_bypass_boost_get(struct snd_kcontrol *kcontrol,
+static int rt1015_bypass_boost_get(struct snd_kcontrol *kcontrol,
 		struct snd_ctl_elem_value *ucontrol)
 {
 	struct snd_soc_component *component =
@@ -457,7 +457,7 @@ static int rt5518_bypass_boost_get(struct snd_kcontrol *kcontrol,
 	return 0;
 }
 
-static int rt5518_bypass_boost_put(struct snd_kcontrol *kcontrol,
+static int rt1015_bypass_boost_put(struct snd_kcontrol *kcontrol,
 		struct snd_ctl_elem_value *ucontrol)
 {
 	struct snd_soc_component *component =
@@ -497,7 +497,7 @@ static const struct snd_kcontrol_new rt1015_snd_controls[] = {
 		rt1015_boost_mode_get, rt1015_boost_mode_put),
 	SOC_ENUM("Mono LR Select", rt1015_mono_lr_sel),
 	SOC_SINGLE_EXT("Bypass Boost", SND_SOC_NOPM, 0, 1, 0,
-		rt5518_bypass_boost_get, rt5518_bypass_boost_put),
+		rt1015_bypass_boost_get, rt1015_bypass_boost_put),
 };
 
 static int rt1015_is_sys_clk_from_pll(struct snd_soc_dapm_widget *source,
-- 
2.25.0


[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 944 bytes --]

On Fri, Feb 14, 2020 at 09:28:19AM +0000, Jack Yu wrote:

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> I've generated the patch again from latest "for-next" branch but still get the same patch like attached file,
> not sure what's wrong with this patch? Could you please help specify what's wrong with this patch?
> Thank you very much!

Applying: ASoC: rt1015: fix typo for bypass boost control
Using index info to reconstruct a base tree...
error: patch failed: sound/soc/codecs/rt1015.c:444
error: sound/soc/codecs/rt1015.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 ASoC: rt1015: fix typo for bypass boost control

Is your mail client corrupting patches?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 219 bytes --]

On Thu, Jan 30, 2020 at 10:18:11AM +0000, Jack Yu wrote:
> Fix typo for "Bypass Boost" control.
> 
> Signed-off-by: Jack Yu <jack.yu@realtek.com>

This doesn't apply against current code, please check and resend.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel