alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] ucm2: Add support to SDM845 based platforms
@ 2020-03-05 13:44 Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences Srinivas Kandagatla
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-05 13:44 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Srinivas Kandagatla

This patchset adds UCM support for WSA881x, WCD934x codec and two platforms,
DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs.

Tested on Ubuntu 20.04 with pulseaudio 13 along with
with this fix
 https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa

Thanks,
srini

Srinivas Kandagatla (4):
  ucm2: codecs: wcd934x: Add Codec sequences.
  ucm2: codecs: wsa881x: add codec sequences
  ucm2: DB845c: Add ucm for DB845c board
  ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop

 ucm2/DB845c/DB845c.conf                       | 11 +++
 ucm2/DB845c/HDMI.conf                         | 33 +++++++
 ucm2/DB845c/HiFi.conf                         | 46 +++++++++
 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf         | 98 +++++++++++++++++++
 .../Lenovo-YOGA-C630-13Q50.conf               |  6 ++
 ucm2/codecs/wcd934x/DefaultDisableSeq.conf    |  5 +
 ucm2/codecs/wcd934x/DefaultEnableSeq.conf     | 14 +++
 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf  |  6 ++
 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf   |  6 ++
 .../wcd934x/HeadphoneMicDisableSeq.conf       |  2 +
 .../codecs/wcd934x/HeadphoneMicEnableSeq.conf |  3 +
 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf    |  4 +
 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf     |  4 +
 ucm2/codecs/wsa881x/DefaultEnableSeq.conf     |  8 ++
 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf    |  8 ++
 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf     |  8 ++
 16 files changed, 262 insertions(+)
 create mode 100644 ucm2/DB845c/DB845c.conf
 create mode 100644 ucm2/DB845c/HDMI.conf
 create mode 100644 ucm2/DB845c/HiFi.conf
 create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf
 create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf
 create mode 100644 ucm2/codecs/wcd934x/DefaultDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/DefaultEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf
 create mode 100644 ucm2/codecs/wsa881x/DefaultEnableSeq.conf
 create mode 100644 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf
 create mode 100644 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf

-- 
2.21.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences.
  2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
@ 2020-03-05 13:44 ` Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 2/4] ucm2: codecs: wsa881x: add codec sequences Srinivas Kandagatla
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-05 13:44 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Srinivas Kandagatla

Add WCD934x codec sequences to be used by other platforms like DB845c
and Lenovo YOGA C630

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 ucm2/codecs/wcd934x/DefaultDisableSeq.conf      |  5 +++++
 ucm2/codecs/wcd934x/DefaultEnableSeq.conf       | 14 ++++++++++++++
 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf    |  6 ++++++
 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf     |  6 ++++++
 ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf |  2 ++
 ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf  |  3 +++
 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf      |  4 ++++
 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf       |  4 ++++
 8 files changed, 44 insertions(+)
 create mode 100644 ucm2/codecs/wcd934x/DefaultDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/DefaultEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf
 create mode 100644 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf

diff --git a/ucm2/codecs/wcd934x/DefaultDisableSeq.conf b/ucm2/codecs/wcd934x/DefaultDisableSeq.conf
new file mode 100644
index 0000000..88d82a3
--- /dev/null
+++ b/ucm2/codecs/wcd934x/DefaultDisableSeq.conf
@@ -0,0 +1,5 @@
+cset "name='RX INT7_1 MIX1 INP0' ZERO"
+cset "name='RX INT8_1 MIX1 INP0' ZERO"
+cset "name='RX INT1_2 MUX' ZERO"
+cset "name='RX INT2_2 MUX' ZERO"
+cset "name='CDC_IF TX0 MUX' ZERO"
diff --git a/ucm2/codecs/wcd934x/DefaultEnableSeq.conf b/ucm2/codecs/wcd934x/DefaultEnableSeq.conf
new file mode 100644
index 0000000..e5bdbbd
--- /dev/null
+++ b/ucm2/codecs/wcd934x/DefaultEnableSeq.conf
@@ -0,0 +1,14 @@
+cset "name='SLIM RX1 MUX' AIF1_PB"
+cset "name='SLIM RX2 MUX' AIF1_PB"
+cset "name='SLIM RX6 MUX' ZERO"
+cset "name='SLIM RX7 MUX' ZERO"
+cset "name='SLIM RX3 MUX' ZERO"
+cset "name='SLIM RX4 MUX' ZERO"
+cset "name='SLIM RX5 MUX' ZERO"
+cset "name='AIF1_CAP Mixer SLIM TX0' 1"
+
+cset "name='RX INT7_1 MIX1 INP0' RX1"
+cset "name='RX INT8_1 MIX1 INP0' RX2"
+cset "name='RX INT1_2 MUX' RX1"
+cset "name='RX INT2_2 MUX' RX2"
+cset "name='CDC_IF TX0 MUX' DEC0"
diff --git a/ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf b/ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf
new file mode 100644
index 0000000..0206e87
--- /dev/null
+++ b/ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf
@@ -0,0 +1,6 @@
+cset "name='COMP1 Switch' 0"
+cset "name='COMP2 Switch' 0"
+cset "name='RX1 Digital Volume' 0"
+cset "name='RX2 Digital Volume' 0"
+cset "name='RX INT1 DEM MUX' ZERO"
+cset "name='RX INT2 DEM MUX' ZERO"
diff --git a/ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf b/ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf
new file mode 100644
index 0000000..5ce7950
--- /dev/null
+++ b/ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf
@@ -0,0 +1,6 @@
+cset "name='COMP1 Switch' 1"
+cset "name='COMP2 Switch' 1"
+cset "name='RX INT1 DEM MUX' CLSH_DSM_OUT"
+cset "name='RX INT2 DEM MUX' CLSH_DSM_OUT"
+cset "name='RX1 Digital Volume' 68"
+cset "name='RX2 Digital Volume' 68"
diff --git a/ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf b/ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf
new file mode 100644
index 0000000..5558446
--- /dev/null
+++ b/ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf
@@ -0,0 +1,2 @@
+cset "name='AMIC MUX0' ZERO"
+cset "name='ADC2 Volume' 0"
diff --git a/ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf b/ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf
new file mode 100644
index 0000000..ad43830
--- /dev/null
+++ b/ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf
@@ -0,0 +1,3 @@
+cset "name='AMIC MUX0' ADC2"
+cset "name='ADC2 Volume' 12"
+cset "name='ADC MUX0' AMIC"
diff --git a/ucm2/codecs/wcd934x/SpeakerDisableSeq.conf b/ucm2/codecs/wcd934x/SpeakerDisableSeq.conf
new file mode 100644
index 0000000..3c977c8
--- /dev/null
+++ b/ucm2/codecs/wcd934x/SpeakerDisableSeq.conf
@@ -0,0 +1,4 @@
+cset "name='RX7 Digital Volume' 0"
+cset "name='RX8 Digital Volume' 0"
+cset "name='COMP7 Switch' 0"
+cset "name='COMP8 Switch' 0"
diff --git a/ucm2/codecs/wcd934x/SpeakerEnableSeq.conf b/ucm2/codecs/wcd934x/SpeakerEnableSeq.conf
new file mode 100644
index 0000000..2d9a3d8
--- /dev/null
+++ b/ucm2/codecs/wcd934x/SpeakerEnableSeq.conf
@@ -0,0 +1,4 @@
+cset "name='COMP7 Switch' 1"
+cset "name='COMP8 Switch' 1"
+cset "name='RX7 Digital Volume' 80"
+cset "name='RX8 Digital Volume' 80"
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/4] ucm2: codecs: wsa881x: add codec sequences
  2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences Srinivas Kandagatla
@ 2020-03-05 13:44 ` Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 3/4] ucm2: DB845c: Add ucm for DB845c board Srinivas Kandagatla
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-05 13:44 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Srinivas Kandagatla

Add default, enable/disable codec sequence for wsa881x codec

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 ucm2/codecs/wsa881x/DefaultEnableSeq.conf  | 8 ++++++++
 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf | 8 ++++++++
 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf  | 8 ++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 ucm2/codecs/wsa881x/DefaultEnableSeq.conf
 create mode 100644 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf
 create mode 100644 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf

diff --git a/ucm2/codecs/wsa881x/DefaultEnableSeq.conf b/ucm2/codecs/wsa881x/DefaultEnableSeq.conf
new file mode 100644
index 0000000..499342b
--- /dev/null
+++ b/ucm2/codecs/wsa881x/DefaultEnableSeq.conf
@@ -0,0 +1,8 @@
+cset "name='SpkrLeft COMP Switch' 1"
+cset "name='SpkrLeft BOOST Switch' 1"
+cset "name='SpkrLeft DAC Switch' 1"
+cset "name='SpkrLeft VISENSE Switch' 0"
+cset "name='SpkrRight COMP Switch' 1"
+cset "name='SpkrRight BOOST Switch' 1"
+cset "name='SpkrRight DAC Switch' 1"
+cset "name='SpkrRight VISENSE Switch' 0"
diff --git a/ucm2/codecs/wsa881x/SpeakerDisableSeq.conf b/ucm2/codecs/wsa881x/SpeakerDisableSeq.conf
new file mode 100644
index 0000000..9614422
--- /dev/null
+++ b/ucm2/codecs/wsa881x/SpeakerDisableSeq.conf
@@ -0,0 +1,8 @@
+cset "name='SpkrLeft COMP Switch' 0"
+cset "name='SpkrLeft BOOST Switch' 0"
+cset "name='SpkrLeft DAC Switch' 0"
+cset "name='SpkrLeft VISENSE Switch' 0"
+cset "name='SpkrRight COMP Switch' 0"
+cset "name='SpkrRight BOOST Switch' 0"
+cset "name='SpkrRight DAC Switch' 0"
+cset "name='SpkrRight VISENSE Switch' 0"
diff --git a/ucm2/codecs/wsa881x/SpeakerEnableSeq.conf b/ucm2/codecs/wsa881x/SpeakerEnableSeq.conf
new file mode 100644
index 0000000..499342b
--- /dev/null
+++ b/ucm2/codecs/wsa881x/SpeakerEnableSeq.conf
@@ -0,0 +1,8 @@
+cset "name='SpkrLeft COMP Switch' 1"
+cset "name='SpkrLeft BOOST Switch' 1"
+cset "name='SpkrLeft DAC Switch' 1"
+cset "name='SpkrLeft VISENSE Switch' 0"
+cset "name='SpkrRight COMP Switch' 1"
+cset "name='SpkrRight BOOST Switch' 1"
+cset "name='SpkrRight DAC Switch' 1"
+cset "name='SpkrRight VISENSE Switch' 0"
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/4] ucm2: DB845c: Add ucm for DB845c board
  2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 2/4] ucm2: codecs: wsa881x: add codec sequences Srinivas Kandagatla
@ 2020-03-05 13:44 ` Srinivas Kandagatla
  2020-03-05 13:44 ` [PATCH 4/4] ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop Srinivas Kandagatla
  2020-03-30 14:10 ` [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
  4 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-05 13:44 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Srinivas Kandagatla

DB845c board by default has two WSA881x speakers and HDMI
audio connections.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 ucm2/DB845c/DB845c.conf | 11 ++++++++++
 ucm2/DB845c/HDMI.conf   | 33 +++++++++++++++++++++++++++++
 ucm2/DB845c/HiFi.conf   | 46 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 90 insertions(+)
 create mode 100644 ucm2/DB845c/DB845c.conf
 create mode 100644 ucm2/DB845c/HDMI.conf
 create mode 100644 ucm2/DB845c/HiFi.conf

diff --git a/ucm2/DB845c/DB845c.conf b/ucm2/DB845c/DB845c.conf
new file mode 100644
index 0000000..bfd1ee5
--- /dev/null
+++ b/ucm2/DB845c/DB845c.conf
@@ -0,0 +1,11 @@
+Syntax 2
+
+SectionUseCase."HiFi" {
+	File "HiFi.conf"
+	Comment "HiFi quality Music."
+}
+
+SectionUseCase."HDMI" {
+	File "HDMI.conf"
+	Comment "HDMI output."
+}
diff --git a/ucm2/DB845c/HDMI.conf b/ucm2/DB845c/HDMI.conf
new file mode 100644
index 0000000..0a17f68
--- /dev/null
+++ b/ucm2/DB845c/HDMI.conf
@@ -0,0 +1,33 @@
+# Use case configuration for DB845c board.
+# Author: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+SectionVerb {
+        EnableSequence [
+		cdev "hw:DB845c"
+		cset "name='QUAT_MI2S_RX Audio Mixer MultiMedia1' 1"
+        ]
+
+        DisableSequence [
+		cdev "hw:DB845c"
+		cset "name='QUAT_MI2S_RX Audio Mixer MultiMedia1' 0"
+	]
+       Value {
+                TQ "HiFi"
+                PlaybackPCM "hw:DB845c,0"
+        }
+}
+
+SectionDevice."HDMI-stereo" {
+        #Name "HDMI-stereo"
+        Comment "HDMI Digital Stereo Output"
+
+        EnableSequence [
+        ]
+
+        DisableSequence [
+        ]
+
+        Value {
+                PlaybackChannels "2"
+        }
+}
diff --git a/ucm2/DB845c/HiFi.conf b/ucm2/DB845c/HiFi.conf
new file mode 100644
index 0000000..a169bfd
--- /dev/null
+++ b/ucm2/DB845c/HiFi.conf
@@ -0,0 +1,46 @@
+# Use case configuration for DB845c.
+# Author: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+SectionVerb {
+
+	EnableSequence [
+		cdev "hw:DB845c"
+		cset "name='SLIMBUS_0_RX Audio Mixer MultiMedia2' 1"
+
+		<codecs/wcd934x/DefaultEnableSeq.conf>
+		<codecs/wsa881x/DefaultEnableSeq.conf>
+	]
+
+	DisableSequence [
+                cdev "hw:DB845c"
+		<codecs/wcd934x/DefaultDisableSeq.conf>
+		cset "name='SLIMBUS_0_RX Audio Mixer MultiMedia2' 0"
+	]
+
+	Value {
+		TQ "HiFi"
+	}
+}
+
+SectionDevice."Speakers" {
+	Comment "Speakers playback"
+
+	EnableSequence [
+		cdev "hw:DB845c"
+		<codecs/wcd934x/SpeakerEnableSeq.conf>
+		<codecs/wsa881x/SpeakerEnableSeq.conf>
+	]
+
+	DisableSequence [
+		cdev "hw:DB845c"
+		<codecs/wsa881x/SpeakerDisableSeq.conf>
+		<codecs/wcd934x/SpeakerDisableSeq.conf>
+	]
+
+	Value {
+		PlaybackPCM "hw:DB845c,1"
+		PlaybackChannels "2"
+                PlaybackVolume "RX1 Digital Volume"
+                PlaybackVolume "RX2 Digital Volume"
+	}
+}
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/4] ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop
  2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
                   ` (2 preceding siblings ...)
  2020-03-05 13:44 ` [PATCH 3/4] ucm2: DB845c: Add ucm for DB845c board Srinivas Kandagatla
@ 2020-03-05 13:44 ` Srinivas Kandagatla
  2020-03-30 14:10 ` [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
  4 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-05 13:44 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Srinivas Kandagatla

This laptop has by 2 WSA Smart speakers over Soundwire and 3.5mm
headset audio connection.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf         | 98 +++++++++++++++++++
 .../Lenovo-YOGA-C630-13Q50.conf               |  6 ++
 2 files changed, 104 insertions(+)
 create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf
 create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf

diff --git a/ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf b/ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf
new file mode 100644
index 0000000..bc4f914
--- /dev/null
+++ b/ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf
@@ -0,0 +1,98 @@
+# Use case configuration for LenovoYOGAC6301.
+# Author: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+SectionVerb {
+
+	EnableSequence [
+		cdev "hw:LenovoYOGAC6301"
+		cset "name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 1"
+		cset "name='MultiMedia2 Mixer SLIMBUS_0_TX' 1"
+
+		<codecs/wcd934x/DefaultEnableSeq.conf>
+		<codecs/wsa881x/DefaultEnableSeq.conf>
+	]
+
+	DisableSequence [
+                cdev "hw:LenovoYOGAC6301"
+		<codecs/wcd934x/DefaultDisableSeq.conf>
+		cset "name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 0"
+		cset "name='MultiMedia2 Mixer SLIMBUS_0_TX' 0"
+	]
+
+	Value {
+		TQ "HiFi"
+	}
+}
+
+SectionDevice."Speakers" {
+	Comment "Speakers playback"
+
+	ConflictingDevice [
+		"HeadPhones"
+	]
+
+
+	EnableSequence [
+		cdev "hw:LenovoYOGAC6301"
+		<codecs/wcd934x/SpeakerEnableSeq.conf>
+		<codecs/wsa881x/SpeakerEnableSeq.conf>
+	]
+
+	DisableSequence [
+		cdev "hw:LenovoYOGAC6301"
+		<codecs/wsa881x/SpeakerDisableSeq.conf>
+		<codecs/wcd934x/SpeakerDisableSeq.conf>
+	]
+
+	Value {
+		PlaybackPCM "hw:LenovoYOGAC6301,0"
+		PlaybackChannels "2"
+                PlaybackVolume "RX1 Digital Volume"
+                PlaybackVolume "RX2 Digital Volume"
+	}
+}
+
+SectionDevice."HeadPhones" {
+	Comment "HeadPhones playback"
+
+	ConflictingDevice [
+		"Speakers"
+	]
+
+	EnableSequence [
+		cdev "hw:LenovoYOGAC6301"
+		<codecs/wcd934x/HeadphoneEnableSeq.conf>
+	]
+
+	DisableSequence [
+		cdev "hw:LenovoYOGAC6301"
+		<codecs/wcd934x/HeadphoneDisableSeq.conf>
+	]
+
+	Value {
+		PlaybackPCM "hw:LenovoYOGAC6301,0"
+		PlaybackChannels "2"
+                PlaybackVolume "RX1 Digital Volume"
+                PlaybackVolume "RX2 Digital Volume"
+	}
+}
+
+SectionDevice."HeadPhonesMic" {
+	Comment "HeadPhones Mic"
+
+	EnableSequence [
+		<codecs/wcd934x/HeadphoneMicEnableSeq.conf>
+	]
+
+	DisableSequence [
+		<codecs/wcd934x/HeadphoneMicDisableSeq.conf>
+		cset "name='AMIC MUX0' ZERO"
+                cset "name='ADC2 Volume' 0"
+	]
+	
+	Value {
+		CapturePCM "hw:LenovoYOGAC6301,1"
+		CaptureChannels "2"
+		CaptureVolume "ADC2 Volume"
+	}
+}
diff --git a/ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf b/ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf
new file mode 100644
index 0000000..114466a
--- /dev/null
+++ b/ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf
@@ -0,0 +1,6 @@
+Syntax 2
+
+SectionUseCase."HiFi" {
+	File "HiFi.conf"
+	Comment "HiFi Music."
+}
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ucm2: Add support to SDM845 based platforms
  2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
                   ` (3 preceding siblings ...)
  2020-03-05 13:44 ` [PATCH 4/4] ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop Srinivas Kandagatla
@ 2020-03-30 14:10 ` Srinivas Kandagatla
  2020-03-30 14:19   ` Jaroslav Kysela
  4 siblings, 1 reply; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-30 14:10 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel

Hi Jaroslav,

On 05/03/2020 13:44, Srinivas Kandagatla wrote:
> This patchset adds UCM support for WSA881x, WCD934x codec and two platforms,
> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs.
> 
> Tested on Ubuntu 20.04 with pulseaudio 13 along with
> with this fix
>   https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa
> 

Are you okay to pick these ucm2 patches?


thanks,
srini


> Thanks,
> srini
> 
> Srinivas Kandagatla (4):
>    ucm2: codecs: wcd934x: Add Codec sequences.
>    ucm2: codecs: wsa881x: add codec sequences
>    ucm2: DB845c: Add ucm for DB845c board
>    ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop
> 
>   ucm2/DB845c/DB845c.conf                       | 11 +++
>   ucm2/DB845c/HDMI.conf                         | 33 +++++++
>   ucm2/DB845c/HiFi.conf                         | 46 +++++++++
>   ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf         | 98 +++++++++++++++++++
>   .../Lenovo-YOGA-C630-13Q50.conf               |  6 ++
>   ucm2/codecs/wcd934x/DefaultDisableSeq.conf    |  5 +
>   ucm2/codecs/wcd934x/DefaultEnableSeq.conf     | 14 +++
>   ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf  |  6 ++
>   ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf   |  6 ++
>   .../wcd934x/HeadphoneMicDisableSeq.conf       |  2 +
>   .../codecs/wcd934x/HeadphoneMicEnableSeq.conf |  3 +
>   ucm2/codecs/wcd934x/SpeakerDisableSeq.conf    |  4 +
>   ucm2/codecs/wcd934x/SpeakerEnableSeq.conf     |  4 +
>   ucm2/codecs/wsa881x/DefaultEnableSeq.conf     |  8 ++
>   ucm2/codecs/wsa881x/SpeakerDisableSeq.conf    |  8 ++
>   ucm2/codecs/wsa881x/SpeakerEnableSeq.conf     |  8 ++
>   16 files changed, 262 insertions(+)
>   create mode 100644 ucm2/DB845c/DB845c.conf
>   create mode 100644 ucm2/DB845c/HDMI.conf
>   create mode 100644 ucm2/DB845c/HiFi.conf
>   create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf
>   create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf
>   create mode 100644 ucm2/codecs/wcd934x/DefaultDisableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/DefaultEnableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf
>   create mode 100644 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf
>   create mode 100644 ucm2/codecs/wsa881x/DefaultEnableSeq.conf
>   create mode 100644 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf
>   create mode 100644 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ucm2: Add support to SDM845 based platforms
  2020-03-30 14:10 ` [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
@ 2020-03-30 14:19   ` Jaroslav Kysela
  2020-03-30 14:25     ` Srinivas Kandagatla
  0 siblings, 1 reply; 8+ messages in thread
From: Jaroslav Kysela @ 2020-03-30 14:19 UTC (permalink / raw)
  To: Srinivas Kandagatla; +Cc: ALSA development

Dne 30. 03. 20 v 16:10 Srinivas Kandagatla napsal(a):
> Hi Jaroslav,
> 
> On 05/03/2020 13:44, Srinivas Kandagatla wrote:
>> This patchset adds UCM support for WSA881x, WCD934x codec and two platforms,
>> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs.
>>
>> Tested on Ubuntu 20.04 with pulseaudio 13 along with
>> with this fix
>>    https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa
>>
> 
> Are you okay to pick these ucm2 patches?

Hi,

   it seems that those changes does not pass through the ucm validator 
(https://github.com/alsa-project/alsa-tests - python/ucm-validator directory).

   I have also some comments, but I would probably prefer to create a pull 
request on github to do the review for all files with history.

				Thank you,
					Jaroslav
-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ucm2: Add support to SDM845 based platforms
  2020-03-30 14:19   ` Jaroslav Kysela
@ 2020-03-30 14:25     ` Srinivas Kandagatla
  0 siblings, 0 replies; 8+ messages in thread
From: Srinivas Kandagatla @ 2020-03-30 14:25 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: ALSA development



On 30/03/2020 15:19, Jaroslav Kysela wrote:
> Dne 30. 03. 20 v 16:10 Srinivas Kandagatla napsal(a):
>> Hi Jaroslav,
>>
>> On 05/03/2020 13:44, Srinivas Kandagatla wrote:
>>> This patchset adds UCM support for WSA881x, WCD934x codec and two 
>>> platforms,
>>> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs.
>>>
>>> Tested on Ubuntu 20.04 with pulseaudio 13 along with
>>> with this fix
>>>    
>>> https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa 
>>>
>>>
>>
>> Are you okay to pick these ucm2 patches?
> 
> Hi,
> 
>    it seems that those changes does not pass through the ucm validator 
> (https://github.com/alsa-project/alsa-tests - python/ucm-validator 
> directory).

Thanks, I did not knew that there was an ucm-validator, I try run it and 
fix those issues before sending a pull request!

--srini

> 
>    I have also some comments, but I would probably prefer to create a 
> pull request on github to do the review for all files with history.
> 
>                  Thank you,
>                      Jaroslav

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-30 14:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 2/4] ucm2: codecs: wsa881x: add codec sequences Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 3/4] ucm2: DB845c: Add ucm for DB845c board Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 4/4] ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop Srinivas Kandagatla
2020-03-30 14:10 ` [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
2020-03-30 14:19   ` Jaroslav Kysela
2020-03-30 14:25     ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).