[PATCH] ASoC: Intel: Enable coredump in kconfig

[PATCH] ASoC: Intel: Enable coredump in kconfig

[Gustaw Lewandowski]

From: Piotr Maziarz <piotrx.maziarz@linux.intel.com>

WANT_DEV_COREDUMP flag is needed here if this driver is only one
using dev_coredump feature.

Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
Signed-off-by: Gustaw Lewandowski <gustaw.lewandowski@linux.intel.com>
---
 sound/soc/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index a5b446d5af19..c215156e2e18 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -4,6 +4,7 @@ config SND_SOC_INTEL_SST_TOPLEVEL
 	default y
 	depends on X86 || COMPILE_TEST
 	select SND_SOC_INTEL_MACH
+	select WANT_DEV_COREDUMP
 	help
 	  Intel ASoC SST Platform Drivers. If you have a Intel machine that
 	  has an audio controller with a DSP and I2S or DMIC port, then
-- 
2.29.0

Re: [PATCH] ASoC: Intel: Enable coredump in kconfig

[Pierre-Louis Bossart]

On 10/23/20 5:57 AM, Gustaw Lewandowski wrote:
> From: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
> 
> WANT_DEV_COREDUMP flag is needed here if this driver is only one
> using dev_coredump feature.
> 
> Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
> Signed-off-by: Gustaw Lewandowski <gustaw.lewandowski@linux.intel.com>
> ---
>   sound/soc/intel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index a5b446d5af19..c215156e2e18 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -4,6 +4,7 @@ config SND_SOC_INTEL_SST_TOPLEVEL
>   	default y
>   	depends on X86 || COMPILE_TEST
>   	select SND_SOC_INTEL_MACH
> +	select WANT_DEV_COREDUMP
>   	help
>   	  Intel ASoC SST Platform Drivers. If you have a Intel machine that
>   	  has an audio controller with a DSP and I2S or DMIC port, then


to the best of my knowledge the only user of device coredump is:

intel/catpt/dsp.c:      dev_coredumpv(cdev->dev, dump, dump_size, 
GFP_KERNEL);

so shouldn't this change be added to catpt only?