* [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk
@ 2020-01-06 11:39 Hans de Goede
2020-01-06 14:23 ` Pierre-Louis Bossart
2020-01-06 20:50 ` [alsa-devel] Applied "ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk" to the asoc tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2020-01-06 11:39 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown
Cc: Hans de Goede, alsa-devel, stable, russianneuromancer
When a quirk for the Irbis NB41 netbook was added, to override the defaults
for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the
defaults, completely breaking audio on this netbook.
This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook
quirk, making audio work again.
Cc: stable@vger.kernel.org
Cc: russianneuromancer@ya.ru
Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook")
Reported-and-tested-by: russianneuromancer@ya.ru
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/soc/intel/boards/bytcht_es8316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
index 46612331f5ea..54e97455d7f6 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"),
DMI_MATCH(DMI_PRODUCT_NAME, "NB41"),
},
- .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP
+ .driver_data = (void *)(BYT_CHT_ES8316_SSP0
+ | BYT_CHT_ES8316_INTMIC_IN2_MAP
| BYT_CHT_ES8316_JD_INVERTED),
},
{ /* Teclast X98 Plus II */
--
2.24.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk
2020-01-06 11:39 [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk Hans de Goede
@ 2020-01-06 14:23 ` Pierre-Louis Bossart
2020-01-06 20:50 ` [alsa-devel] Applied "ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk" to the asoc tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-06 14:23 UTC (permalink / raw)
To: Hans de Goede, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown
Cc: russianneuromancer, alsa-devel, stable
On 1/6/20 5:39 AM, Hans de Goede wrote:
> When a quirk for the Irbis NB41 netbook was added, to override the defaults
> for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the
> defaults, completely breaking audio on this netbook.
>
> This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook
> quirk, making audio work again.
>
> Cc: stable@vger.kernel.org
> Cc: russianneuromancer@ya.ru
> Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook")
> Reported-and-tested-by: russianneuromancer@ya.ru
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/bytcht_es8316.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index 46612331f5ea..54e97455d7f6 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"),
> DMI_MATCH(DMI_PRODUCT_NAME, "NB41"),
> },
> - .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP
> + .driver_data = (void *)(BYT_CHT_ES8316_SSP0
> + | BYT_CHT_ES8316_INTMIC_IN2_MAP
> | BYT_CHT_ES8316_JD_INVERTED),
> },
> { /* Teclast X98 Plus II */
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [alsa-devel] Applied "ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk" to the asoc tree
2020-01-06 11:39 [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk Hans de Goede
2020-01-06 14:23 ` Pierre-Louis Bossart
@ 2020-01-06 20:50 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-01-06 20:50 UTC (permalink / raw)
To: Hans de Goede
Cc: alsa-devel, russianneuromancer, Jie Yang, Cezary Rojewski,
stable, Pierre-Louis Bossart, Liam Girdwood, Mark Brown
The patch
ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 869bced7a055665e3ddb1ba671a441ce6f997bf1 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 6 Jan 2020 12:39:03 +0100
Subject: [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk
When a quirk for the Irbis NB41 netbook was added, to override the defaults
for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the
defaults, completely breaking audio on this netbook.
This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook
quirk, making audio work again.
Cc: stable@vger.kernel.org
Cc: russianneuromancer@ya.ru
Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook")
Reported-and-tested-by: russianneuromancer@ya.ru
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200106113903.279394-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/bytcht_es8316.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
index 46612331f5ea..54e97455d7f6 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"),
DMI_MATCH(DMI_PRODUCT_NAME, "NB41"),
},
- .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP
+ .driver_data = (void *)(BYT_CHT_ES8316_SSP0
+ | BYT_CHT_ES8316_INTMIC_IN2_MAP
| BYT_CHT_ES8316_JD_INVERTED),
},
{ /* Teclast X98 Plus II */
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-06 11:39 [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk Hans de Goede
2020-01-06 14:23 ` Pierre-Louis Bossart
2020-01-06 20:50 ` [alsa-devel] Applied "ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).