[PATCH] drm/amdgpu: Initialize umc ras callback

[PATCH] drm/amdgpu: Initialize umc ras callback

[Hawking Zhang]

Fix a coding error which results to null interrupt
handler for umc ras.

Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
index da68ceaa024c..9e2e97207e53 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
@@ -232,7 +232,7 @@ int amdgpu_umc_ras_sw_init(struct amdgpu_device *adev)
 	if (!ras->ras_block.ras_late_init)
 		ras->ras_block.ras_late_init = amdgpu_umc_ras_late_init;
 
-	if (ras->ras_block.ras_cb)
+	if (!ras->ras_block.ras_cb)
 		ras->ras_block.ras_cb = amdgpu_umc_process_ras_data_cb;
 
 	return 0;
-- 
2.17.1

RE: [PATCH] drm/amdgpu: Initialize umc ras callback

[Yang, Stanley]

[AMD Official Use Only - General]

Reviewed-by: Stanley Yang <Stanley.Yang@amd.com>

Regards,
Stanley
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Hawking Zhang
> Sent: Monday, March 20, 2023 5:37 PM
> To: amd-gfx@lists.freedesktop.org; Zhou1, Tao <Tao.Zhou1@amd.com>
> Cc: Zhang, Hawking <Hawking.Zhang@amd.com>
> Subject: [PATCH] drm/amdgpu: Initialize umc ras callback
> 
> Fix a coding error which results to null interrupt handler for umc ras.
> 
> Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> index da68ceaa024c..9e2e97207e53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> @@ -232,7 +232,7 @@ int amdgpu_umc_ras_sw_init(struct amdgpu_device
> *adev)
>  	if (!ras->ras_block.ras_late_init)
>  		ras->ras_block.ras_late_init = amdgpu_umc_ras_late_init;
> 
> -	if (ras->ras_block.ras_cb)
> +	if (!ras->ras_block.ras_cb)
>  		ras->ras_block.ras_cb = amdgpu_umc_process_ras_data_cb;
> 
>  	return 0;
> --
> 2.17.1