Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Guilherme G. Piccoli]

Hi Wenyou Yang, first of all thanks for the improvement!

I'd like to ask you (and all CCed) if it would be possible to explain a
bit the goal / functionality behind these patches.

By reading the commit descriptions and code, I can understand code-wise
what's going on and how this will message the FW on SMT changes. What I
couldn't parse is the purpose of this, or in other words, what does it
gain for us? Also, why only on Vangogh?

Since I don't have the spec I couldn't read and learn myself - apologies
if this is somewhat a silly question. Also, if for some reason you
cannot respond (like a HW "NDA"), it's fine too.

Thanks in advance,


Guilherme

RE: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Yang, WenYou]

[AMD Official Use Only - General]

Hi Guilherme,

Thank you for your attention on the patch set.

The purpose of the patch set is to improve the performance when playing the game.

Best Regards,
Wenyou

> -----Original Message-----
> From: Guilherme G. Piccoli <gpiccoli@igalia.com>
> Sent: Friday, March 24, 2023 5:44 AM
> To: Yang, WenYou <WenYou.Yang@amd.com>; amd-gfx list <amd-
> gfx@lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Liu, Kun
> <Kun.Liu2@amd.com>; Liang, Richard qi <Richardqi.Liang@amd.com>; Yuan,
> Perry <Perry.Yuan@amd.com>; Li, Ying <YING.LI@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>; kernel-dev@igalia.com
> Subject: Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> Hi Wenyou Yang, first of all thanks for the improvement!
> 
> I'd like to ask you (and all CCed) if it would be possible to explain a bit the goal /
> functionality behind these patches.
> 
> By reading the commit descriptions and code, I can understand code-wise
> what's going on and how this will message the FW on SMT changes. What I
> couldn't parse is the purpose of this, or in other words, what does it gain for us?
> Also, why only on Vangogh?
> 
> Since I don't have the spec I couldn't read and learn myself - apologies if this is
> somewhat a silly question. Also, if for some reason you cannot respond (like a
> HW "NDA"), it's fine too.
> 
> Thanks in advance,
> 
> 
> Guilherme

Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Guilherme G. Piccoli]

On 26/03/2023 23:49, Yang, WenYou wrote:
> Hi Guilherme,
> 
> Thank you for your attention on the patch set.
> The purpose of the patch set is to improve the performance when playing the game.
> 
> Best Regards,
> Wenyou

Hi Wenyou, thank you for the clarification and for the interesting patch
set!

So, just so I can understand: is it expected that gamers disable SMT? I
heard some games got their performance improved, but not sure the
reason...if you have thoughts on that, I'm pretty interested!

Cheers,


Guilherme

RE: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Yang, WenYou]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Guilherme G. Piccoli <gpiccoli@igalia.com>
> Sent: Monday, March 27, 2023 10:09 PM
> To: Yang, WenYou <WenYou.Yang@amd.com>; amd-gfx list <amd-
> gfx@lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Liu, Kun
> <Kun.Liu2@amd.com>; Liang, Richard qi <Richardqi.Liang@amd.com>; Yuan,
> Perry <Perry.Yuan@amd.com>; Li, Ying <YING.LI@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>; kernel-dev@igalia.com
> Subject: Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> On 26/03/2023 23:49, Yang, WenYou wrote:
> > Hi Guilherme,
> >
> > Thank you for your attention on the patch set.
> > The purpose of the patch set is to improve the performance when playing the
> game.
> >
> > Best Regards,
> > Wenyou
> 
> Hi Wenyou, thank you for the clarification and for the interesting patch set!
> 
> So, just so I can understand: is it expected that gamers disable SMT? I heard
> some games got their performance improved, but not sure the reason...if you
> have thoughts on that, I'm pretty interested!
Hi Guilherme,

No, it not. It is not to disable SMT.

Yes, there is a commit to get performance improved.
https://github.com/torvalds/linux/commit/a8fb40966f19ff81520d9ccf8f7e2b95201368b8

Best Regards,
Wenyou



> 
> Cheers,
> 
> 
> Guilherme

Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Guilherme G. Piccoli]

On 28/03/2023 03:07, Yang, WenYou wrote:
> [AMD Official Use Only - General]
> [...]
>> Hi Wenyou, thank you for the clarification and for the interesting patch set!
>>
>> So, just so I can understand: is it expected that gamers disable SMT? I heard
>> some games got their performance improved, but not sure the reason...if you
>> have thoughts on that, I'm pretty interested!
> Hi Guilherme,
> 
> No, it not. It is not to disable SMT.
> 
> Yes, there is a commit to get performance improved.
> https://github.com/torvalds/linux/commit/a8fb40966f19ff81520d9ccf8f7e2b95201368b8
> 
> Best Regards,
> Wenyou

Thanks, this one is present in Deck's kernel for a while.
Cheers,


Guilherme

[Resend PATCH v1 0/3] send message to pmfw when SMT changes

[Wenyou Yang]

When the CPU SMT changes on the fly, send the message to pmfw
to notify the SMT status changed.

Wenyou Yang (3):
  cpu/smt: add a notifier to notify the SMT changes
  drm/amd/pm: send the SMT-enable message to pmfw
  drm/amd/pm: vangogh: support to send SMT enable message

 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     | 41 +++++++++++++++++++
 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |  5 +++
 .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h    |  3 +-
 drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h  |  3 +-
 .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c  | 19 +++++++++
 include/linux/cpu.h                           |  5 +++
 kernel/cpu.c                                  | 11 ++++-
 7 files changed, 84 insertions(+), 3 deletions(-)

-- 
2.39.2