* Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
@ 2023-03-23 21:43 Guilherme G. Piccoli
2023-03-27 2:49 ` Yang, WenYou
0 siblings, 1 reply; 6+ messages in thread
From: Guilherme G. Piccoli @ 2023-03-23 21:43 UTC (permalink / raw)
To: wenyou.yang, amd-gfx list
Cc: weiyuan2, ying.li, xinhui pan, Mario Limonciello, kernel-dev,
Deucher, Alexander, kunliu13, Christian Koenig, Liang,
Richard qi
Hi Wenyou Yang, first of all thanks for the improvement!
I'd like to ask you (and all CCed) if it would be possible to explain a
bit the goal / functionality behind these patches.
By reading the commit descriptions and code, I can understand code-wise
what's going on and how this will message the FW on SMT changes. What I
couldn't parse is the purpose of this, or in other words, what does it
gain for us? Also, why only on Vangogh?
Since I don't have the spec I couldn't read and learn myself - apologies
if this is somewhat a silly question. Also, if for some reason you
cannot respond (like a HW "NDA"), it's fine too.
Thanks in advance,
Guilherme
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
2023-03-23 21:43 [Resend PATCH v1 0/3] send message to pmfw when SMT changes Guilherme G. Piccoli
@ 2023-03-27 2:49 ` Yang, WenYou
2023-03-27 14:08 ` Guilherme G. Piccoli
0 siblings, 1 reply; 6+ messages in thread
From: Yang, WenYou @ 2023-03-27 2:49 UTC (permalink / raw)
To: Guilherme G. Piccoli, amd-gfx list
Cc: Li, Ying, Pan, Xinhui, Yuan, Perry, Limonciello, Mario,
kernel-dev, Deucher, Alexander, Koenig, Christian, Liang,
Richard qi, Liu, Kun
[AMD Official Use Only - General]
Hi Guilherme,
Thank you for your attention on the patch set.
The purpose of the patch set is to improve the performance when playing the game.
Best Regards,
Wenyou
> -----Original Message-----
> From: Guilherme G. Piccoli <gpiccoli@igalia.com>
> Sent: Friday, March 24, 2023 5:44 AM
> To: Yang, WenYou <WenYou.Yang@amd.com>; amd-gfx list <amd-
> gfx@lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Liu, Kun
> <Kun.Liu2@amd.com>; Liang, Richard qi <Richardqi.Liang@amd.com>; Yuan,
> Perry <Perry.Yuan@amd.com>; Li, Ying <YING.LI@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>; kernel-dev@igalia.com
> Subject: Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Wenyou Yang, first of all thanks for the improvement!
>
> I'd like to ask you (and all CCed) if it would be possible to explain a bit the goal /
> functionality behind these patches.
>
> By reading the commit descriptions and code, I can understand code-wise
> what's going on and how this will message the FW on SMT changes. What I
> couldn't parse is the purpose of this, or in other words, what does it gain for us?
> Also, why only on Vangogh?
>
> Since I don't have the spec I couldn't read and learn myself - apologies if this is
> somewhat a silly question. Also, if for some reason you cannot respond (like a
> HW "NDA"), it's fine too.
>
> Thanks in advance,
>
>
> Guilherme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
2023-03-27 2:49 ` Yang, WenYou
@ 2023-03-27 14:08 ` Guilherme G. Piccoli
2023-03-28 6:07 ` Yang, WenYou
0 siblings, 1 reply; 6+ messages in thread
From: Guilherme G. Piccoli @ 2023-03-27 14:08 UTC (permalink / raw)
To: Yang, WenYou, amd-gfx list
Cc: Li, Ying, Pan, Xinhui, Yuan, Perry, Limonciello, Mario,
kernel-dev, Deucher, Alexander, Koenig, Christian, Liang,
Richard qi, Liu, Kun
On 26/03/2023 23:49, Yang, WenYou wrote:
> Hi Guilherme,
>
> Thank you for your attention on the patch set.
> The purpose of the patch set is to improve the performance when playing the game.
>
> Best Regards,
> Wenyou
Hi Wenyou, thank you for the clarification and for the interesting patch
set!
So, just so I can understand: is it expected that gamers disable SMT? I
heard some games got their performance improved, but not sure the
reason...if you have thoughts on that, I'm pretty interested!
Cheers,
Guilherme
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
2023-03-27 14:08 ` Guilherme G. Piccoli
@ 2023-03-28 6:07 ` Yang, WenYou
2023-03-28 12:09 ` Guilherme G. Piccoli
0 siblings, 1 reply; 6+ messages in thread
From: Yang, WenYou @ 2023-03-28 6:07 UTC (permalink / raw)
To: Guilherme G. Piccoli, amd-gfx list
Cc: Li, Ying, Pan, Xinhui, Yuan, Perry, Limonciello, Mario,
kernel-dev, Deucher, Alexander, Koenig, Christian, Liang,
Richard qi, Liu, Kun
[AMD Official Use Only - General]
> -----Original Message-----
> From: Guilherme G. Piccoli <gpiccoli@igalia.com>
> Sent: Monday, March 27, 2023 10:09 PM
> To: Yang, WenYou <WenYou.Yang@amd.com>; amd-gfx list <amd-
> gfx@lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Liu, Kun
> <Kun.Liu2@amd.com>; Liang, Richard qi <Richardqi.Liang@amd.com>; Yuan,
> Perry <Perry.Yuan@amd.com>; Li, Ying <YING.LI@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>; kernel-dev@igalia.com
> Subject: Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 26/03/2023 23:49, Yang, WenYou wrote:
> > Hi Guilherme,
> >
> > Thank you for your attention on the patch set.
> > The purpose of the patch set is to improve the performance when playing the
> game.
> >
> > Best Regards,
> > Wenyou
>
> Hi Wenyou, thank you for the clarification and for the interesting patch set!
>
> So, just so I can understand: is it expected that gamers disable SMT? I heard
> some games got their performance improved, but not sure the reason...if you
> have thoughts on that, I'm pretty interested!
Hi Guilherme,
No, it not. It is not to disable SMT.
Yes, there is a commit to get performance improved.
https://github.com/torvalds/linux/commit/a8fb40966f19ff81520d9ccf8f7e2b95201368b8
Best Regards,
Wenyou
>
> Cheers,
>
>
> Guilherme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Resend PATCH v1 0/3] send message to pmfw when SMT changes
2023-03-28 6:07 ` Yang, WenYou
@ 2023-03-28 12:09 ` Guilherme G. Piccoli
0 siblings, 0 replies; 6+ messages in thread
From: Guilherme G. Piccoli @ 2023-03-28 12:09 UTC (permalink / raw)
To: Yang, WenYou, amd-gfx list
Cc: Li, Ying, Pan, Xinhui, Yuan, Perry, Limonciello, Mario,
kernel-dev, Deucher, Alexander, Koenig, Christian, Liang,
Richard qi, Liu, Kun
On 28/03/2023 03:07, Yang, WenYou wrote:
> [AMD Official Use Only - General]
> [...]
>> Hi Wenyou, thank you for the clarification and for the interesting patch set!
>>
>> So, just so I can understand: is it expected that gamers disable SMT? I heard
>> some games got their performance improved, but not sure the reason...if you
>> have thoughts on that, I'm pretty interested!
> Hi Guilherme,
>
> No, it not. It is not to disable SMT.
>
> Yes, there is a commit to get performance improved.
> https://github.com/torvalds/linux/commit/a8fb40966f19ff81520d9ccf8f7e2b95201368b8
>
> Best Regards,
> Wenyou
Thanks, this one is present in Deck's kernel for a while.
Cheers,
Guilherme
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Resend PATCH v1 0/3] send message to pmfw when SMT changes
@ 2023-03-22 9:16 Wenyou Yang
0 siblings, 0 replies; 6+ messages in thread
From: Wenyou Yang @ 2023-03-22 9:16 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan
Cc: weiyuan2, ying.li, amd-gfx, Wenyou Yang, kunliu13, richardqi.liang
When the CPU SMT changes on the fly, send the message to pmfw
to notify the SMT status changed.
Wenyou Yang (3):
cpu/smt: add a notifier to notify the SMT changes
drm/amd/pm: send the SMT-enable message to pmfw
drm/amd/pm: vangogh: support to send SMT enable message
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41 +++++++++++++++++++
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 5 +++
.../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h | 3 +-
drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +-
.../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 19 +++++++++
include/linux/cpu.h | 5 +++
kernel/cpu.c | 11 ++++-
7 files changed, 84 insertions(+), 3 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-28 14:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 21:43 [Resend PATCH v1 0/3] send message to pmfw when SMT changes Guilherme G. Piccoli
2023-03-27 2:49 ` Yang, WenYou
2023-03-27 14:08 ` Guilherme G. Piccoli
2023-03-28 6:07 ` Yang, WenYou
2023-03-28 12:09 ` Guilherme G. Piccoli
-- strict thread matches above, loose matches on Subject: below --
2023-03-22 9:16 Wenyou Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).