From: Alex Deucher <alexdeucher@gmail.com>
To: "Maíra Canal" <mairacanal@riseup.net>
Cc: Magali Lemes <magalilemes00@gmail.com>,
Leo Li <sunpeng.li@amd.com>,
Tales Lelo da Aparecida <tales.aparecida@gmail.com>,
xinhui pan <Xinhui.Pan@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Melissa Wen <mwen@igalia.com>, David Airlie <airlied@linux.ie>,
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Daniel Vetter <daniel@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>,
Isabella Basso <isabbasso@riseup.net>,
andrealmeid@riseup.net, Harry Wentland <harry.wentland@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH 10/12] drm/amd/display: Remove parameters from dml30_CalculateWriteBackDISPCLK
Date: Mon, 18 Jul 2022 15:02:40 -0400 [thread overview]
Message-ID: <CADnq5_Ot2ecb=D7M2fznBWuZiC-OwPPAnfPfwFXbnrWcevAtzA@mail.gmail.com> (raw)
In-Reply-To: <20220714164507.561751-10-mairacanal@riseup.net>
On Thu, Jul 14, 2022 at 12:46 PM Maíra Canal <mairacanal@riseup.net> wrote:
>
> The parameters WritebackPixelFormat and WritebackVRatio are removed as
> they are not used on the function dml30_CalculateWriteBackDISPCLK.
Maybe this is done for consistency with other dml code for other DCN blocks?
Alex
>
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c | 2 --
> .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ------
> .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.h | 2 --
> 3 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c
> index a8db1306750e..746bb93ade6c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c
> @@ -322,10 +322,8 @@ void dcn30_fpu_populate_dml_writeback_from_context(
> * parameters per pipe
> */
> writeback_dispclk = dml30_CalculateWriteBackDISPCLK(
> - dout_wb.wb_pixel_format,
> pipes[pipe_cnt].pipe.dest.pixel_rate_mhz,
> dout_wb.wb_hratio,
> - dout_wb.wb_vratio,
> dout_wb.wb_htaps_luma,
> dout_wb.wb_vtaps_luma,
> dout_wb.wb_src_width,
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> index 876b321b30ca..37049daaab4c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
> @@ -1938,10 +1938,8 @@ static void DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerforman
> if (v->WritebackEnable[k]) {
> v->WritebackDISPCLK = dml_max(v->WritebackDISPCLK,
> dml30_CalculateWriteBackDISPCLK(
> - v->WritebackPixelFormat[k],
> v->PixelClock[k],
> v->WritebackHRatio[k],
> - v->WritebackVRatio[k],
> v->WritebackHTaps[k],
> v->WritebackVTaps[k],
> v->WritebackSourceWidth[k],
> @@ -3284,10 +3282,8 @@ static double CalculateTWait(
> }
>
> double dml30_CalculateWriteBackDISPCLK(
> - enum source_format_class WritebackPixelFormat,
> double PixelClock,
> double WritebackHRatio,
> - double WritebackVRatio,
> unsigned int WritebackHTaps,
> unsigned int WritebackVTaps,
> long WritebackSourceWidth,
> @@ -3794,10 +3790,8 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> if (v->WritebackEnable[k] == true) {
> v->WritebackRequiredDISPCLK = dml_max(v->WritebackRequiredDISPCLK,
> dml30_CalculateWriteBackDISPCLK(
> - v->WritebackPixelFormat[k],
> v->PixelClock[k],
> v->WritebackHRatio[k],
> - v->WritebackVRatio[k],
> v->WritebackHTaps[k],
> v->WritebackVTaps[k],
> v->WritebackSourceWidth[k],
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.h b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.h
> index daaf0883b84d..12c070434eee 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.h
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.h
> @@ -29,10 +29,8 @@
> void dml30_recalculate(struct display_mode_lib *mode_lib);
> void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib);
> double dml30_CalculateWriteBackDISPCLK(
> - enum source_format_class WritebackPixelFormat,
> double PixelClock,
> double WritebackHRatio,
> - double WritebackVRatio,
> unsigned int WritebackHTaps,
> unsigned int WritebackVTaps,
> long WritebackSourceWidth,
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-07-18 19:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 16:44 [PATCH 01/12] drm/amdgpu: Write masked value to control register Maíra Canal
2022-07-14 16:44 ` [PATCH 02/12] drm/amd/display: Change get_pipe_idx function scope Maíra Canal
2022-07-18 18:52 ` Alex Deucher
2022-07-14 16:44 ` [PATCH 03/12] drm/amd/display: Remove unused clk_src variable Maíra Canal
2022-07-18 18:53 ` Alex Deucher
2022-07-14 16:44 ` [PATCH 04/12] drm/amd/display: Remove unused dml32_CalculatedoublePipeDPPCLKAndSCLThroughput function Maíra Canal
2022-07-18 18:54 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 05/12] drm/amd/display: Remove unused NumberOfStates variable Maíra Canal
2022-07-18 18:55 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 06/12] drm/amd/display: Remove unused variables from dml_rq_dlg_get_dlg_params Maíra Canal
2022-07-18 18:56 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 07/12] drm/amd/display: Remove unused value0 variable Maíra Canal
2022-07-18 18:58 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 08/12] drm/amd/display: Remove unused variables from dcn10_stream_encoder Maíra Canal
2022-07-18 18:59 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 09/12] drm/amd/display: Remove unused MaxUsedBW variable Maíra Canal
2022-07-18 19:00 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 10/12] drm/amd/display: Remove parameters from dml30_CalculateWriteBackDISPCLK Maíra Canal
2022-07-18 19:02 ` Alex Deucher [this message]
2022-07-19 10:49 ` Maíra Canal
2022-07-19 13:03 ` Alex Deucher
2022-07-14 16:45 ` [PATCH 11/12] drm/amd/display: Remove duplicated CalculateWriteBackDISPCLK Maíra Canal
2022-07-14 16:45 ` [PATCH 12/12] drm/amd/display: Rewrite CalculateWriteBackDISPCLK function Maíra Canal
2022-07-15 1:53 ` André Almeida
2022-07-14 19:04 ` [PATCH 01/12] drm/amdgpu: Write masked value to control register André Almeida
2022-07-14 19:14 ` Alex Deucher
2022-07-14 19:20 ` André Almeida
2022-07-15 1:56 ` André Almeida
2022-07-18 19:07 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_Ot2ecb=D7M2fznBWuZiC-OwPPAnfPfwFXbnrWcevAtzA@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@riseup.net \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=harry.wentland@amd.com \
--cc=isabbasso@riseup.net \
--cc=linux-kernel@vger.kernel.org \
--cc=magalilemes00@gmail.com \
--cc=mairacanal@riseup.net \
--cc=mwen@igalia.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tales.aparecida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).