* [PATCH] amdgpu/pm: Disallow managing power profiles on SRIOV for Sienna Cichlid
@ 2022-05-09 11:47 Danijel Slivka
2022-05-10 3:16 ` Quan, Evan
0 siblings, 1 reply; 2+ messages in thread
From: Danijel Slivka @ 2022-05-09 11:47 UTC (permalink / raw)
To: amd-gfx; +Cc: Danijel Slivka
Managing power profiles mode is not allowed in SRIOV mode for Sienna Cichlid.
This patch is adjusting the "pp_power_profile_mode" and
"power_dpm_force_performance_level" accordingly.
Signed-off-by: Danijel Slivka <danijel.slivka@amd.com>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 70a0aad05426..59a662aeaaf3 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2025,6 +2025,8 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
} else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {
if (amdgpu_dpm_get_power_profile_mode(adev, NULL) == -EOPNOTSUPP)
*states = ATTR_STATE_UNSUPPORTED;
+ else if (gc_ver == IP_VERSION(10, 3, 0) && amdgpu_sriov_vf(adev))
+ *states = ATTR_STATE_UNSUPPORTED;
}
switch (gc_ver) {
@@ -2038,6 +2040,13 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
dev_attr->store = NULL;
}
break;
+ case IP_VERSION(10, 3, 0):
+ if (DEVICE_ATTR_IS(power_dpm_force_performance_level) &&
+ amdgpu_sriov_vf(adev)) {
+ dev_attr->attr.mode &= ~S_IWUGO;
+ dev_attr->store = NULL;
+ }
+ break;
default:
break;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] amdgpu/pm: Disallow managing power profiles on SRIOV for Sienna Cichlid
2022-05-09 11:47 [PATCH] amdgpu/pm: Disallow managing power profiles on SRIOV for Sienna Cichlid Danijel Slivka
@ 2022-05-10 3:16 ` Quan, Evan
0 siblings, 0 replies; 2+ messages in thread
From: Quan, Evan @ 2022-05-10 3:16 UTC (permalink / raw)
To: Slivka, Danijel, amd-gfx; +Cc: Slivka, Danijel
[AMD Official Use Only - General]
Reviewed-by: Evan Quan <evan.quan@amd.com>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Danijel Slivka
> Sent: Monday, May 9, 2022 7:47 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Slivka, Danijel <Danijel.Slivka@amd.com>
> Subject: [PATCH] amdgpu/pm: Disallow managing power profiles on SRIOV
> for Sienna Cichlid
>
> Managing power profiles mode is not allowed in SRIOV mode for Sienna
> Cichlid.
> This patch is adjusting the "pp_power_profile_mode" and
> "power_dpm_force_performance_level" accordingly.
>
> Signed-off-by: Danijel Slivka <danijel.slivka@amd.com>
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 70a0aad05426..59a662aeaaf3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2025,6 +2025,8 @@ static int default_attr_update(struct
> amdgpu_device *adev, struct amdgpu_device_
> } else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {
> if (amdgpu_dpm_get_power_profile_mode(adev, NULL) ==
> -EOPNOTSUPP)
> *states = ATTR_STATE_UNSUPPORTED;
> + else if (gc_ver == IP_VERSION(10, 3, 0) &&
> amdgpu_sriov_vf(adev))
> + *states = ATTR_STATE_UNSUPPORTED;
> }
>
> switch (gc_ver) {
> @@ -2038,6 +2040,13 @@ static int default_attr_update(struct
> amdgpu_device *adev, struct amdgpu_device_
> dev_attr->store = NULL;
> }
> break;
> + case IP_VERSION(10, 3, 0):
> + if (DEVICE_ATTR_IS(power_dpm_force_performance_level)
> &&
> + amdgpu_sriov_vf(adev)) {
> + dev_attr->attr.mode &= ~S_IWUGO;
> + dev_attr->store = NULL;
> + }
> + break;
> default:
> break;
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-10 3:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 11:47 [PATCH] amdgpu/pm: Disallow managing power profiles on SRIOV for Sienna Cichlid Danijel Slivka
2022-05-10 3:16 ` Quan, Evan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).