From: Krzysztof Kozlowski <krzk@kernel.org> To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>, Hans Verkuil <hverkuil@xs4all.nl>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Date: Tue, 10 Jan 2023 20:31:13 +0100 [thread overview] Message-ID: <b0245b64-a3eb-a242-8824-9effe0c63f0e@kernel.org> (raw) In-Reply-To: <20230110014143.18684-2-yuji2.ishikawa@toshiba.co.jp> On 10/01/2023 02:41, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed few of them, so clearly this was not sent correctly. Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > --- > Changelog v2: > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > --- > .../bindings/media/toshiba,visconti-viif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > new file mode 100644 > index 00000000000..71442724d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti-viif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC Video Input Interface Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: > + Toshiba Visconti5 SoC Video Input Interface (VIIF) > + receives MIPI CSI2 video stream, > + processes the stream with embedded image signal processor (L1ISP, L2ISP), > + then stores pictures to main memory. Fix wrapping. > + > +properties: > + compatible: > + const: toshiba,visconti-viif Compatible must be specific. You called your SoC visconti5, didn't you? > + > + reg: > + items: > + - description: registers for capture control > + - description: registers for CSI2 receiver control > + > + interrupts: > + items: > + - description: Sync Interrupt > + - description: Status (Error) Interrupt > + - description: CSI2 Receiver Interrupt > + - description: L1ISP Interrupt > + Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>, Hans Verkuil <hverkuil@xs4all.nl>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Date: Tue, 10 Jan 2023 20:31:13 +0100 [thread overview] Message-ID: <b0245b64-a3eb-a242-8824-9effe0c63f0e@kernel.org> (raw) In-Reply-To: <20230110014143.18684-2-yuji2.ishikawa@toshiba.co.jp> On 10/01/2023 02:41, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the Video Input Interface found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed few of them, so clearly this was not sent correctly. Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > --- > Changelog v2: > - no change > > Changelog v3: > - no change > > Changelog v4: > - fix style problems at the v3 patch > - remove "index" member > - update example > --- > .../bindings/media/toshiba,visconti-viif.yaml | 98 +++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > new file mode 100644 > index 00000000000..71442724d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml > @@ -0,0 +1,98 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti-viif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC Video Input Interface Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: > + Toshiba Visconti5 SoC Video Input Interface (VIIF) > + receives MIPI CSI2 video stream, > + processes the stream with embedded image signal processor (L1ISP, L2ISP), > + then stores pictures to main memory. Fix wrapping. > + > +properties: > + compatible: > + const: toshiba,visconti-viif Compatible must be specific. You called your SoC visconti5, didn't you? > + > + reg: > + items: > + - description: registers for capture control > + - description: registers for CSI2 receiver control > + > + interrupts: > + items: > + - description: Sync Interrupt > + - description: Status (Error) Interrupt > + - description: CSI2 Receiver Interrupt > + - description: L1ISP Interrupt > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-10 19:31 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-10 1:41 [PATCH v4 0/6] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa 2023-01-10 1:41 ` Yuji Ishikawa 2023-01-10 1:41 ` [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Yuji Ishikawa 2023-01-10 1:41 ` Yuji Ishikawa 2023-01-10 19:31 ` Krzysztof Kozlowski [this message] 2023-01-10 19:31 ` Krzysztof Kozlowski 2023-01-11 2:19 ` yuji2.ishikawa 2023-01-11 2:19 ` yuji2.ishikawa 2023-01-11 7:56 ` Krzysztof Kozlowski 2023-01-11 7:56 ` Krzysztof Kozlowski 2023-01-11 13:21 ` yuji2.ishikawa 2023-01-11 13:21 ` yuji2.ishikawa 2023-01-11 13:28 ` Krzysztof Kozlowski 2023-01-11 13:28 ` Krzysztof Kozlowski 2023-01-12 2:05 ` yuji2.ishikawa 2023-01-12 2:05 ` yuji2.ishikawa 2023-01-12 8:11 ` Krzysztof Kozlowski 2023-01-12 8:11 ` Krzysztof Kozlowski 2023-01-17 12:29 ` yuji2.ishikawa 2023-01-17 12:29 ` yuji2.ishikawa 2023-01-10 1:41 ` [PATCH v4 2/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa 2023-01-10 1:41 ` [PATCH v4 3/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver user interace Yuji Ishikawa 2023-01-10 1:41 ` Yuji Ishikawa 2023-01-10 1:41 ` [PATCH v4 4/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver v4l2 controls handler Yuji Ishikawa 2023-01-10 1:41 ` [PATCH v4 5/6] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa 2023-01-10 1:41 ` Yuji Ishikawa 2023-01-10 1:41 ` [PATCH v4 6/6] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa 2023-01-10 1:41 ` Yuji Ishikawa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b0245b64-a3eb-a242-8824-9effe0c63f0e@kernel.org \ --to=krzk@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=hverkuil@xs4all.nl \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=yuji2.ishikawa@toshiba.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.