From: Krzysztof Kozlowski <krzk@kernel.org>
To: yuji2.ishikawa@toshiba.co.jp, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
nobuhiro1.iwamatsu@toshiba.co.jp
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings
Date: Thu, 12 Jan 2023 09:11:13 +0100 [thread overview]
Message-ID: <f92ff708-add2-44c3-8e51-33a1279cecbf@kernel.org> (raw)
In-Reply-To: <TYAPR01MB62014698C65E5ADFBD07C65F92FD9@TYAPR01MB6201.jpnprd01.prod.outlook.com>
On 12/01/2023 03:05, yuji2.ishikawa@toshiba.co.jp wrote:
>>>> Compatible must be specific. You called your SoC visconti5, didn't you?
>>>>
>>>
>>> The Video Input Interface hardware is likely to be used at future SoCs
>>> of Visconti Architecture.
>>> Does compatible have to be specific to SoC's model name rather than
>>> architecture name?
>>
>> Compatibles should always be specific to SoC model name. Adding more generic
>> family fallback is also good idea when it is applicable.
>>
>
> I'll update the compatible to "toshiba,visconti5-viif".
> I'll consider adding generic version "toshiba,visconti-viif" when a successor SoC gets available.
Are you sure? You will have to wait at least one cycle between DTS and
driver change, due to ABI break of DTB users.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: yuji2.ishikawa@toshiba.co.jp, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
nobuhiro1.iwamatsu@toshiba.co.jp
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings
Date: Thu, 12 Jan 2023 09:11:13 +0100 [thread overview]
Message-ID: <f92ff708-add2-44c3-8e51-33a1279cecbf@kernel.org> (raw)
In-Reply-To: <TYAPR01MB62014698C65E5ADFBD07C65F92FD9@TYAPR01MB6201.jpnprd01.prod.outlook.com>
On 12/01/2023 03:05, yuji2.ishikawa@toshiba.co.jp wrote:
>>>> Compatible must be specific. You called your SoC visconti5, didn't you?
>>>>
>>>
>>> The Video Input Interface hardware is likely to be used at future SoCs
>>> of Visconti Architecture.
>>> Does compatible have to be specific to SoC's model name rather than
>>> architecture name?
>>
>> Compatibles should always be specific to SoC model name. Adding more generic
>> family fallback is also good idea when it is applicable.
>>
>
> I'll update the compatible to "toshiba,visconti5-viif".
> I'll consider adding generic version "toshiba,visconti-viif" when a successor SoC gets available.
Are you sure? You will have to wait at least one cycle between DTS and
driver change, due to ABI break of DTB users.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-12 8:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 1:41 [PATCH v4 0/6] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-01-10 1:41 ` Yuji Ishikawa
2023-01-10 1:41 ` [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings Yuji Ishikawa
2023-01-10 1:41 ` Yuji Ishikawa
2023-01-10 19:31 ` Krzysztof Kozlowski
2023-01-10 19:31 ` Krzysztof Kozlowski
2023-01-11 2:19 ` yuji2.ishikawa
2023-01-11 2:19 ` yuji2.ishikawa
2023-01-11 7:56 ` Krzysztof Kozlowski
2023-01-11 7:56 ` Krzysztof Kozlowski
2023-01-11 13:21 ` yuji2.ishikawa
2023-01-11 13:21 ` yuji2.ishikawa
2023-01-11 13:28 ` Krzysztof Kozlowski
2023-01-11 13:28 ` Krzysztof Kozlowski
2023-01-12 2:05 ` yuji2.ishikawa
2023-01-12 2:05 ` yuji2.ishikawa
2023-01-12 8:11 ` Krzysztof Kozlowski [this message]
2023-01-12 8:11 ` Krzysztof Kozlowski
2023-01-17 12:29 ` yuji2.ishikawa
2023-01-17 12:29 ` yuji2.ishikawa
2023-01-10 1:41 ` [PATCH v4 2/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-01-10 1:41 ` [PATCH v4 3/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver user interace Yuji Ishikawa
2023-01-10 1:41 ` Yuji Ishikawa
2023-01-10 1:41 ` [PATCH v4 4/6] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver v4l2 controls handler Yuji Ishikawa
2023-01-10 1:41 ` [PATCH v4 5/6] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-01-10 1:41 ` Yuji Ishikawa
2023-01-10 1:41 ` [PATCH v4 6/6] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-01-10 1:41 ` Yuji Ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92ff708-add2-44c3-8e51-33a1279cecbf@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.