From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, linux-pm@vger.kernel.org Cc: "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@kernel.org>, Lina Iyer <ilina@codeaurora.org>, Viresh Kumar <viresh.kumar@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 15/27] drivers: firmware: psci: Announce support for OS initiated suspend mode Date: Thu, 20 Dec 2018 14:11:00 +0100 [thread overview] Message-ID: <b333c9db-9ef0-cdba-093e-6735a23ec5f6@linaro.org> (raw) In-Reply-To: <20181129174700.16585-16-ulf.hansson@linaro.org> On 29/11/2018 18:46, Ulf Hansson wrote: > PSCI firmware v1.0+, supports two different modes for CPU_SUSPEND. The > Platform Coordinated mode, which is the default and mandatory mode, while > support for the OS initiated mode is optional. > > This change introduces initial support for the OS initiated mode, in way > that it adds the related PSCI bits from the spec and prints a message in > the log to inform whether the mode is supported by the PSCI FW. > > Cc: Lina Iyer <ilina@codeaurora.org> > Co-developed-by: Lina Iyer <lina.iyer@linaro.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > > Changes in v10: > - None. > > --- > drivers/firmware/psci/psci.c | 21 ++++++++++++++++++++- > include/uapi/linux/psci.h | 5 +++++ > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 6bfa47cbd174..4f0cbc95e41b 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -95,6 +95,11 @@ static inline bool psci_has_ext_power_state(void) > PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; > } > > +static inline bool psci_has_osi_support(void) > +{ > + return psci_cpu_suspend_feature & PSCI_1_0_OS_INITIATED; > +} > + > static inline bool psci_power_state_loses_context(u32 state) > { > const u32 mask = psci_has_ext_power_state() ? > @@ -659,10 +664,24 @@ static int __init psci_0_1_init(struct device_node *np) > return 0; > } > > +static int __init psci_1_0_init(struct device_node *np) > +{ > + int err; > + > + err = psci_0_2_init(np); > + if (err) > + return err; > + > + if (psci_has_osi_support()) > + pr_info("OSI mode supported.\n"); > + > + return 0; > +} > + > static const struct of_device_id psci_of_match[] __initconst = { > { .compatible = "arm,psci", .data = psci_0_1_init}, > { .compatible = "arm,psci-0.2", .data = psci_0_2_init}, > - { .compatible = "arm,psci-1.0", .data = psci_0_2_init}, > + { .compatible = "arm,psci-1.0", .data = psci_1_0_init}, > {}, > }; > > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h > index b3bcabe380da..581f72085c33 100644 > --- a/include/uapi/linux/psci.h > +++ b/include/uapi/linux/psci.h > @@ -49,6 +49,7 @@ > > #define PSCI_1_0_FN_PSCI_FEATURES PSCI_0_2_FN(10) > #define PSCI_1_0_FN_SYSTEM_SUSPEND PSCI_0_2_FN(14) > +#define PSCI_1_0_FN_SET_SUSPEND_MODE PSCI_0_2_FN(15) > > #define PSCI_1_0_FN64_SYSTEM_SUSPEND PSCI_0_2_FN64(14) > > @@ -97,6 +98,10 @@ > #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \ > (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT) > > +#define PSCI_1_0_OS_INITIATED BIT(0) > +#define PSCI_1_0_SUSPEND_MODE_PC 0 > +#define PSCI_1_0_SUSPEND_MODE_OSI 1 > + > /* PSCI return values (inclusive of all PSCI versions) */ > #define PSCI_RET_SUCCESS 0 > #define PSCI_RET_NOT_SUPPORTED -1 > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, linux-pm@vger.kernel.org Cc: Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Kevin Hilman <khilman@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-kernel@vger.kernel.org, Lina Iyer <ilina@codeaurora.org>, Tony Lindgren <tony@atomide.com>, linux-arm-msm@vger.kernel.org, "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v10 15/27] drivers: firmware: psci: Announce support for OS initiated suspend mode Date: Thu, 20 Dec 2018 14:11:00 +0100 [thread overview] Message-ID: <b333c9db-9ef0-cdba-093e-6735a23ec5f6@linaro.org> (raw) In-Reply-To: <20181129174700.16585-16-ulf.hansson@linaro.org> On 29/11/2018 18:46, Ulf Hansson wrote: > PSCI firmware v1.0+, supports two different modes for CPU_SUSPEND. The > Platform Coordinated mode, which is the default and mandatory mode, while > support for the OS initiated mode is optional. > > This change introduces initial support for the OS initiated mode, in way > that it adds the related PSCI bits from the spec and prints a message in > the log to inform whether the mode is supported by the PSCI FW. > > Cc: Lina Iyer <ilina@codeaurora.org> > Co-developed-by: Lina Iyer <lina.iyer@linaro.org> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > > Changes in v10: > - None. > > --- > drivers/firmware/psci/psci.c | 21 ++++++++++++++++++++- > include/uapi/linux/psci.h | 5 +++++ > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 6bfa47cbd174..4f0cbc95e41b 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -95,6 +95,11 @@ static inline bool psci_has_ext_power_state(void) > PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; > } > > +static inline bool psci_has_osi_support(void) > +{ > + return psci_cpu_suspend_feature & PSCI_1_0_OS_INITIATED; > +} > + > static inline bool psci_power_state_loses_context(u32 state) > { > const u32 mask = psci_has_ext_power_state() ? > @@ -659,10 +664,24 @@ static int __init psci_0_1_init(struct device_node *np) > return 0; > } > > +static int __init psci_1_0_init(struct device_node *np) > +{ > + int err; > + > + err = psci_0_2_init(np); > + if (err) > + return err; > + > + if (psci_has_osi_support()) > + pr_info("OSI mode supported.\n"); > + > + return 0; > +} > + > static const struct of_device_id psci_of_match[] __initconst = { > { .compatible = "arm,psci", .data = psci_0_1_init}, > { .compatible = "arm,psci-0.2", .data = psci_0_2_init}, > - { .compatible = "arm,psci-1.0", .data = psci_0_2_init}, > + { .compatible = "arm,psci-1.0", .data = psci_1_0_init}, > {}, > }; > > diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h > index b3bcabe380da..581f72085c33 100644 > --- a/include/uapi/linux/psci.h > +++ b/include/uapi/linux/psci.h > @@ -49,6 +49,7 @@ > > #define PSCI_1_0_FN_PSCI_FEATURES PSCI_0_2_FN(10) > #define PSCI_1_0_FN_SYSTEM_SUSPEND PSCI_0_2_FN(14) > +#define PSCI_1_0_FN_SET_SUSPEND_MODE PSCI_0_2_FN(15) > > #define PSCI_1_0_FN64_SYSTEM_SUSPEND PSCI_0_2_FN64(14) > > @@ -97,6 +98,10 @@ > #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK \ > (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT) > > +#define PSCI_1_0_OS_INITIATED BIT(0) > +#define PSCI_1_0_SUSPEND_MODE_PC 0 > +#define PSCI_1_0_SUSPEND_MODE_OSI 1 > + > /* PSCI return values (inclusive of all PSCI versions) */ > #define PSCI_RET_SUCCESS 0 > #define PSCI_RET_NOT_SUPPORTED -1 > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-20 13:11 UTC|newest] Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 17:46 [PATCH v10 00/27] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 01/27] PM / Domains: Add generic data pointer to genpd_power_state struct Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-18 10:39 ` Daniel Lezcano 2018-12-18 10:39 ` Daniel Lezcano 2018-12-18 11:53 ` Ulf Hansson 2018-12-18 11:53 ` Ulf Hansson 2019-01-11 10:52 ` Rafael J. Wysocki 2019-01-11 10:52 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 02/27] PM / Domains: Add support for CPU devices to genpd Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 9:53 ` Daniel Lezcano 2018-12-19 9:53 ` Daniel Lezcano 2018-12-19 10:02 ` Ulf Hansson 2018-12-19 10:02 ` Ulf Hansson 2019-01-11 10:54 ` Rafael J. Wysocki 2019-01-11 10:54 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 03/27] timer: Export next wakeup time of a CPU Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 12:00 ` Ulf Hansson 2019-01-16 12:00 ` Ulf Hansson 2019-01-16 12:00 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:18 ` Rafael J. Wysocki 2019-01-25 10:18 ` Rafael J. Wysocki 2019-01-25 10:18 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 04/27] PM / Domains: Add genpd governor for CPUs Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 9:54 ` Daniel Lezcano 2018-12-19 9:54 ` Daniel Lezcano 2018-12-19 10:09 ` Ulf Hansson 2018-12-19 10:09 ` Ulf Hansson 2018-12-19 10:09 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 05/27] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 06/27] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 11:05 ` Daniel Lezcano 2018-12-19 11:05 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 07/27] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 11:20 ` Daniel Lezcano 2018-12-19 11:20 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 08/27] ARM/ARM64: cpuidle: Let back-end init ops take the driver as input Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 09/27] drivers: firmware: psci: Move psci to separate directory Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 10/27] MAINTAINERS: Update files for PSCI Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 11/27] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 12/27] drivers: firmware: psci: Simplify state node parsing Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 13/27] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 12:11 ` Daniel Lezcano 2018-12-19 12:11 ` Daniel Lezcano 2018-12-19 12:53 ` Ulf Hansson 2018-12-19 12:53 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 14/27] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 12:08 ` Daniel Lezcano 2018-12-19 12:08 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 15/27] drivers: firmware: psci: Announce support for OS initiated suspend mode Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 13:11 ` Daniel Lezcano [this message] 2018-12-20 13:11 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 16/27] drivers: firmware: psci: Prepare to use " Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 14:08 ` Daniel Lezcano 2018-12-20 14:08 ` Daniel Lezcano 2018-12-20 15:41 ` Ulf Hansson 2018-12-20 15:41 ` Ulf Hansson 2018-12-20 17:16 ` Daniel Lezcano 2018-12-20 17:16 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 17/27] drivers: firmware: psci: Prepare to support PM domains Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 14:19 ` Daniel Lezcano 2018-12-20 14:19 ` Daniel Lezcano 2018-12-20 15:49 ` Ulf Hansson 2018-12-20 15:49 ` Ulf Hansson 2018-12-20 18:06 ` Daniel Lezcano 2018-12-20 18:06 ` Daniel Lezcano 2018-12-20 21:37 ` Ulf Hansson 2018-12-20 21:37 ` Ulf Hansson 2018-12-21 7:15 ` Daniel Lezcano 2018-12-21 7:15 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 18/27] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-03 16:37 ` Lina Iyer 2018-12-03 16:37 ` Lina Iyer 2018-12-03 20:03 ` Ulf Hansson 2018-12-03 20:03 ` Ulf Hansson 2018-12-20 14:35 ` Daniel Lezcano 2018-12-20 14:35 ` Daniel Lezcano 2018-12-20 21:09 ` Ulf Hansson 2018-12-20 21:09 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 19/27] drivers: firmware: psci: Add hierarchical domain idle states converter Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 20/27] drivers: firmware: psci: Introduce psci_dt_topology_init() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 21/27] drivers: firmware: psci: Add a helper to attach a CPU to its PM domain Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-04 18:45 ` Lina Iyer 2018-12-04 18:45 ` Lina Iyer 2018-12-06 9:15 ` Ulf Hansson 2018-12-06 9:15 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 22/27] drivers: firmware: psci: Attach the CPU's device " Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 23/27] drivers: firmware: psci: Manage runtime PM in the idle path for CPUs Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 24/27] drivers: firmware: psci: Support CPU hotplug for the hierarchical model Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 22:31 ` Lina Iyer 2018-11-29 22:31 ` Lina Iyer 2018-11-30 8:25 ` Ulf Hansson 2018-11-30 8:25 ` Ulf Hansson 2018-11-30 20:57 ` Lina Iyer 2018-11-30 20:57 ` Lina Iyer 2018-12-19 11:17 ` Lorenzo Pieralisi 2018-12-19 11:17 ` Lorenzo Pieralisi 2018-12-19 11:47 ` Ulf Hansson 2018-12-19 11:47 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 25/27] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 26/27] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:47 ` [PATCH v10 27/27] arm64: dts: hikey: Convert to the hierarchical CPU topology layout Ulf Hansson 2018-11-29 17:47 ` Ulf Hansson 2018-12-17 16:12 ` [PATCH v10 00/27] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson 2018-12-17 16:12 ` Ulf Hansson 2019-01-11 11:08 ` Rafael J. Wysocki 2019-01-11 11:08 ` Rafael J. Wysocki 2019-01-03 12:06 ` Sudeep Holla 2019-01-03 12:06 ` Sudeep Holla 2019-01-03 12:06 ` Sudeep Holla 2019-01-16 9:10 ` Ulf Hansson 2019-01-16 9:10 ` Ulf Hansson 2019-01-17 17:44 ` Sudeep Holla 2019-01-17 17:44 ` Sudeep Holla 2019-01-17 17:44 ` Sudeep Holla 2019-01-18 11:56 ` Ulf Hansson 2019-01-18 11:56 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b333c9db-9ef0-cdba-093e-6735a23ec5f6@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=geert+renesas@glider.be \ --cc=ilina@codeaurora.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rjw@rjwysocki.net \ --cc=rplsssn@codeaurora.org \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.