From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, Linux PM <linux-pm@vger.kernel.org>, "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@kernel.org>, Lina Iyer <ilina@codeaurora.org>, Viresh Kumar <viresh.kumar@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v10 16/27] drivers: firmware: psci: Prepare to use OS initiated suspend mode Date: Thu, 20 Dec 2018 18:16:43 +0100 [thread overview] Message-ID: <fe405425-9d94-9f14-b599-63a709e004cf@linaro.org> (raw) In-Reply-To: <CAPDyKFqwB0X6DwamGqYgYKsGRcZRzStT=o_AL2wGExuOkQ2rgw@mail.gmail.com> On 20/12/2018 16:41, Ulf Hansson wrote: > On Thu, 20 Dec 2018 at 15:09, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> >> On 29/11/2018 18:46, Ulf Hansson wrote: >>> To enable the OS initiated mode, the CPU topology needs to be described >>> using the hierarchical model in DT. When used, the idle state bits for the >>> CPU are created by ORing the bits for PM domain's idle state. >>> >>> Let's prepare the PSCI driver to deal with this, via introducing a per CPU >>> variable called domain_state and by adding internal helpers to read/write >>> the value of the variable. >> >> What are the domain states ? What values can they have ? > > The existing psci_power_state, also defined as a per cpu variable, > contains fixed values reflecting the corresponding > arm,psci-suspend-param for the idle state in question. > > This isn't sufficient, when using the hierarchical CPU topology in DT > and when OSI mode is supported, because of the way we vote with the > PSCI CPU suspend parameter. Parts of this parameter shall inform about > what state to allow for the cluster, while other parts tells the state > for the CPU. > > The new "domain states" per CPU variable, gets dynamically changed > when actively used by following patches that implements the PSCI PM > domain support. Depending on what state the PM domain picks, the genpd > ->power_off() callback sets a new "domain states" value, reflecting > the state for the cluster. > > Does it makes sense? If you like, I can try to update the changelog to > clarify this? Yes, it makes sense. May be give a pointer or an information about the parameter encoding in addition to the description above can help. >>> Cc: Lina Iyer <ilina@codeaurora.org> >>> Co-developed-by: Lina Iyer <lina.iyer@linaro.org> >>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >>> --- >>> >>> Changes in v10: >>> - Use __this_cpu_read|write() rather than this_cpu_read|write(). >>> >>> --- >>> drivers/firmware/psci/psci.c | 26 ++++++++++++++++++++++---- >>> 1 file changed, 22 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c >>> index 4f0cbc95e41b..8dbcdecc2ae4 100644 >>> --- a/drivers/firmware/psci/psci.c >>> +++ b/drivers/firmware/psci/psci.c >>> @@ -87,8 +87,19 @@ static u32 psci_function_id[PSCI_FN_MAX]; >>> (PSCI_1_0_EXT_POWER_STATE_ID_MASK | \ >>> PSCI_1_0_EXT_POWER_STATE_TYPE_MASK) >>> >>> +static DEFINE_PER_CPU(u32, domain_state); >>> static u32 psci_cpu_suspend_feature; >>> >>> +static inline u32 psci_get_domain_state(void) >>> +{ >>> + return __this_cpu_read(domain_state); >>> +} >>> + >>> +static inline void psci_set_domain_state(u32 state) >>> +{ >>> + __this_cpu_write(domain_state, state); >>> +} >>> + >>> static inline bool psci_has_ext_power_state(void) >>> { >>> return psci_cpu_suspend_feature & >>> @@ -187,6 +198,8 @@ static int psci_cpu_on(unsigned long cpuid, unsigned long entry_point) >>> >>> fn = psci_function_id[PSCI_FN_CPU_ON]; >>> err = invoke_psci_fn(fn, cpuid, entry_point, 0); >>> + /* Clear the domain state to start fresh. */ >>> + psci_set_domain_state(0); >>> return psci_to_linux_errno(err); >> >> I think this change is ambiguous: >> >> - if it is a change of the state because of the cpu_on, then I was >> expecting a similar change in cpu_off and the change only if >> invoke_psci_fn() succeeds. > > You are right. This rather belongs to patch 24, as its intent is to > deal with CPU hotplug. > >> >> - if it is a change to take opportunity of the code path to initialize >> the domain state, I suggest to remove it from there and make it very >> explicit with static DEFINE_PER_CPU(u32, domain_state) = { 0 }; > > We shouldn't need to explicitly set static variables to zero, as that > should be managed by the compiler. Yeah, that was the purpose of the *very explicit* words, that is tell the reader, the initialization relies on the static variables being set to zero. > Let me simply remove the call to psci_set_domain_state(0) and instead > consider it for patch 24. Yes, sure. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Linux PM <linux-pm@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Kevin Hilman <khilman@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Lina Iyer <ilina@codeaurora.org>, Tony Lindgren <tony@atomide.com>, Sudeep Holla <sudeep.holla@arm.com>, "Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v10 16/27] drivers: firmware: psci: Prepare to use OS initiated suspend mode Date: Thu, 20 Dec 2018 18:16:43 +0100 [thread overview] Message-ID: <fe405425-9d94-9f14-b599-63a709e004cf@linaro.org> (raw) In-Reply-To: <CAPDyKFqwB0X6DwamGqYgYKsGRcZRzStT=o_AL2wGExuOkQ2rgw@mail.gmail.com> On 20/12/2018 16:41, Ulf Hansson wrote: > On Thu, 20 Dec 2018 at 15:09, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> >> On 29/11/2018 18:46, Ulf Hansson wrote: >>> To enable the OS initiated mode, the CPU topology needs to be described >>> using the hierarchical model in DT. When used, the idle state bits for the >>> CPU are created by ORing the bits for PM domain's idle state. >>> >>> Let's prepare the PSCI driver to deal with this, via introducing a per CPU >>> variable called domain_state and by adding internal helpers to read/write >>> the value of the variable. >> >> What are the domain states ? What values can they have ? > > The existing psci_power_state, also defined as a per cpu variable, > contains fixed values reflecting the corresponding > arm,psci-suspend-param for the idle state in question. > > This isn't sufficient, when using the hierarchical CPU topology in DT > and when OSI mode is supported, because of the way we vote with the > PSCI CPU suspend parameter. Parts of this parameter shall inform about > what state to allow for the cluster, while other parts tells the state > for the CPU. > > The new "domain states" per CPU variable, gets dynamically changed > when actively used by following patches that implements the PSCI PM > domain support. Depending on what state the PM domain picks, the genpd > ->power_off() callback sets a new "domain states" value, reflecting > the state for the cluster. > > Does it makes sense? If you like, I can try to update the changelog to > clarify this? Yes, it makes sense. May be give a pointer or an information about the parameter encoding in addition to the description above can help. >>> Cc: Lina Iyer <ilina@codeaurora.org> >>> Co-developed-by: Lina Iyer <lina.iyer@linaro.org> >>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >>> --- >>> >>> Changes in v10: >>> - Use __this_cpu_read|write() rather than this_cpu_read|write(). >>> >>> --- >>> drivers/firmware/psci/psci.c | 26 ++++++++++++++++++++++---- >>> 1 file changed, 22 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c >>> index 4f0cbc95e41b..8dbcdecc2ae4 100644 >>> --- a/drivers/firmware/psci/psci.c >>> +++ b/drivers/firmware/psci/psci.c >>> @@ -87,8 +87,19 @@ static u32 psci_function_id[PSCI_FN_MAX]; >>> (PSCI_1_0_EXT_POWER_STATE_ID_MASK | \ >>> PSCI_1_0_EXT_POWER_STATE_TYPE_MASK) >>> >>> +static DEFINE_PER_CPU(u32, domain_state); >>> static u32 psci_cpu_suspend_feature; >>> >>> +static inline u32 psci_get_domain_state(void) >>> +{ >>> + return __this_cpu_read(domain_state); >>> +} >>> + >>> +static inline void psci_set_domain_state(u32 state) >>> +{ >>> + __this_cpu_write(domain_state, state); >>> +} >>> + >>> static inline bool psci_has_ext_power_state(void) >>> { >>> return psci_cpu_suspend_feature & >>> @@ -187,6 +198,8 @@ static int psci_cpu_on(unsigned long cpuid, unsigned long entry_point) >>> >>> fn = psci_function_id[PSCI_FN_CPU_ON]; >>> err = invoke_psci_fn(fn, cpuid, entry_point, 0); >>> + /* Clear the domain state to start fresh. */ >>> + psci_set_domain_state(0); >>> return psci_to_linux_errno(err); >> >> I think this change is ambiguous: >> >> - if it is a change of the state because of the cpu_on, then I was >> expecting a similar change in cpu_off and the change only if >> invoke_psci_fn() succeeds. > > You are right. This rather belongs to patch 24, as its intent is to > deal with CPU hotplug. > >> >> - if it is a change to take opportunity of the code path to initialize >> the domain state, I suggest to remove it from there and make it very >> explicit with static DEFINE_PER_CPU(u32, domain_state) = { 0 }; > > We shouldn't need to explicitly set static variables to zero, as that > should be managed by the compiler. Yeah, that was the purpose of the *very explicit* words, that is tell the reader, the initialization relies on the static variables being set to zero. > Let me simply remove the call to psci_set_domain_state(0) and instead > consider it for patch 24. Yes, sure. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-20 17:16 UTC|newest] Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 17:46 [PATCH v10 00/27] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 01/27] PM / Domains: Add generic data pointer to genpd_power_state struct Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-18 10:39 ` Daniel Lezcano 2018-12-18 10:39 ` Daniel Lezcano 2018-12-18 11:53 ` Ulf Hansson 2018-12-18 11:53 ` Ulf Hansson 2019-01-11 10:52 ` Rafael J. Wysocki 2019-01-11 10:52 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 02/27] PM / Domains: Add support for CPU devices to genpd Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 9:53 ` Daniel Lezcano 2018-12-19 9:53 ` Daniel Lezcano 2018-12-19 10:02 ` Ulf Hansson 2018-12-19 10:02 ` Ulf Hansson 2019-01-11 10:54 ` Rafael J. Wysocki 2019-01-11 10:54 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 03/27] timer: Export next wakeup time of a CPU Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-11 11:06 ` Rafael J. Wysocki 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 7:57 ` Ulf Hansson 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 10:59 ` Rafael J. Wysocki 2019-01-16 12:00 ` Ulf Hansson 2019-01-16 12:00 ` Ulf Hansson 2019-01-16 12:00 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:04 ` Ulf Hansson 2019-01-25 10:18 ` Rafael J. Wysocki 2019-01-25 10:18 ` Rafael J. Wysocki 2019-01-25 10:18 ` Rafael J. Wysocki 2018-11-29 17:46 ` [PATCH v10 04/27] PM / Domains: Add genpd governor for CPUs Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 9:54 ` Daniel Lezcano 2018-12-19 9:54 ` Daniel Lezcano 2018-12-19 10:09 ` Ulf Hansson 2018-12-19 10:09 ` Ulf Hansson 2018-12-19 10:09 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 05/27] dt: psci: Update DT bindings to support hierarchical PSCI states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 06/27] of: base: Add of_get_cpu_state_node() to get idle states for a CPU node Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 11:05 ` Daniel Lezcano 2018-12-19 11:05 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 07/27] cpuidle: dt: Support hierarchical CPU idle states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 11:20 ` Daniel Lezcano 2018-12-19 11:20 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 08/27] ARM/ARM64: cpuidle: Let back-end init ops take the driver as input Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 09/27] drivers: firmware: psci: Move psci to separate directory Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 10/27] MAINTAINERS: Update files for PSCI Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 11/27] drivers: firmware: psci: Split psci_dt_cpu_init_idle() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 12/27] drivers: firmware: psci: Simplify state node parsing Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 13/27] drivers: firmware: psci: Support hierarchical CPU idle states Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 12:11 ` Daniel Lezcano 2018-12-19 12:11 ` Daniel Lezcano 2018-12-19 12:53 ` Ulf Hansson 2018-12-19 12:53 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 14/27] drivers: firmware: psci: Simplify error path of psci_dt_init() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-19 12:08 ` Daniel Lezcano 2018-12-19 12:08 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 15/27] drivers: firmware: psci: Announce support for OS initiated suspend mode Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 13:11 ` Daniel Lezcano 2018-12-20 13:11 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 16/27] drivers: firmware: psci: Prepare to use " Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 14:08 ` Daniel Lezcano 2018-12-20 14:08 ` Daniel Lezcano 2018-12-20 15:41 ` Ulf Hansson 2018-12-20 15:41 ` Ulf Hansson 2018-12-20 17:16 ` Daniel Lezcano [this message] 2018-12-20 17:16 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 17/27] drivers: firmware: psci: Prepare to support PM domains Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-20 14:19 ` Daniel Lezcano 2018-12-20 14:19 ` Daniel Lezcano 2018-12-20 15:49 ` Ulf Hansson 2018-12-20 15:49 ` Ulf Hansson 2018-12-20 18:06 ` Daniel Lezcano 2018-12-20 18:06 ` Daniel Lezcano 2018-12-20 21:37 ` Ulf Hansson 2018-12-20 21:37 ` Ulf Hansson 2018-12-21 7:15 ` Daniel Lezcano 2018-12-21 7:15 ` Daniel Lezcano 2018-11-29 17:46 ` [PATCH v10 18/27] drivers: firmware: psci: Add support for PM domains using genpd Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-03 16:37 ` Lina Iyer 2018-12-03 16:37 ` Lina Iyer 2018-12-03 20:03 ` Ulf Hansson 2018-12-03 20:03 ` Ulf Hansson 2018-12-20 14:35 ` Daniel Lezcano 2018-12-20 14:35 ` Daniel Lezcano 2018-12-20 21:09 ` Ulf Hansson 2018-12-20 21:09 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 19/27] drivers: firmware: psci: Add hierarchical domain idle states converter Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 20/27] drivers: firmware: psci: Introduce psci_dt_topology_init() Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 21/27] drivers: firmware: psci: Add a helper to attach a CPU to its PM domain Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-12-04 18:45 ` Lina Iyer 2018-12-04 18:45 ` Lina Iyer 2018-12-06 9:15 ` Ulf Hansson 2018-12-06 9:15 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 22/27] drivers: firmware: psci: Attach the CPU's device " Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 23/27] drivers: firmware: psci: Manage runtime PM in the idle path for CPUs Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 24/27] drivers: firmware: psci: Support CPU hotplug for the hierarchical model Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 22:31 ` Lina Iyer 2018-11-29 22:31 ` Lina Iyer 2018-11-30 8:25 ` Ulf Hansson 2018-11-30 8:25 ` Ulf Hansson 2018-11-30 20:57 ` Lina Iyer 2018-11-30 20:57 ` Lina Iyer 2018-12-19 11:17 ` Lorenzo Pieralisi 2018-12-19 11:17 ` Lorenzo Pieralisi 2018-12-19 11:47 ` Ulf Hansson 2018-12-19 11:47 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 25/27] arm64: kernel: Respect the hierarchical CPU topology in DT for PSCI Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:46 ` [PATCH v10 26/27] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Ulf Hansson 2018-11-29 17:46 ` Ulf Hansson 2018-11-29 17:47 ` [PATCH v10 27/27] arm64: dts: hikey: Convert to the hierarchical CPU topology layout Ulf Hansson 2018-11-29 17:47 ` Ulf Hansson 2018-12-17 16:12 ` [PATCH v10 00/27] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) Ulf Hansson 2018-12-17 16:12 ` Ulf Hansson 2019-01-11 11:08 ` Rafael J. Wysocki 2019-01-11 11:08 ` Rafael J. Wysocki 2019-01-03 12:06 ` Sudeep Holla 2019-01-03 12:06 ` Sudeep Holla 2019-01-03 12:06 ` Sudeep Holla 2019-01-16 9:10 ` Ulf Hansson 2019-01-16 9:10 ` Ulf Hansson 2019-01-17 17:44 ` Sudeep Holla 2019-01-17 17:44 ` Sudeep Holla 2019-01-17 17:44 ` Sudeep Holla 2019-01-18 11:56 ` Ulf Hansson 2019-01-18 11:56 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fe405425-9d94-9f14-b599-63a709e004cf@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=geert+renesas@glider.be \ --cc=ilina@codeaurora.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rjw@rjwysocki.net \ --cc=rplsssn@codeaurora.org \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.