From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/16] debug_vm_pgtable/ppc64: Avoid setting top bits in radom value
Date: Wed, 12 Aug 2020 13:55:35 +0530 [thread overview]
Message-ID: <b92fea41-ce31-4915-fdc6-56631222df18@linux.ibm.com> (raw)
In-Reply-To: <fcb44f1d-4131-9135-512e-11a5c00abcd9@arm.com>
On 8/12/20 1:42 PM, Anshuman Khandual wrote:
>
>
> On 08/12/2020 12:03 PM, Aneesh Kumar K.V wrote:
>> ppc64 use bit 62 to indicate a pte entry (_PAGE_PTE). Avoid setting that bit in
>> random value.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> ---
>> mm/debug_vm_pgtable.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
>> index 086309fb9b6f..4c32063a8acf 100644
>> --- a/mm/debug_vm_pgtable.c
>> +++ b/mm/debug_vm_pgtable.c
>> @@ -45,9 +45,12 @@
>> * pxx_clear() because of how dynamic page table folding works on s390. So
>> * while loading up the entries do not change the lower 4 bits. It does not
>> * have affect any other platform.
>> + *
>> + * Also avoid the 62nd bit on ppc64 that is used to mark a pte entry.
>> */
>
> Please move and fold the above line with the existing paragraph.
>
>> #define S390_MASK_BITS 4
>> -#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)
>> +#define PPC_MASK_BITS 2
>
> s/PPC/PPC64/
>
>> +#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1 - PPC_MASK_BITS, S390_MASK_BITS)
>> #define RANDOM_NZVALUE GENMASK(7, 0)
>>
>> static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
>>
>
> With this change, RANDOM_ORVALUE will be (0x3ffffffffffffff0) which discards
> both bit 63 and 62. If only bit 62 is to be avoided for ppc64 the mask should
> be (0xbffffffffffffff0) instead. The following change on this patch should do
> the trick.
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index eb059fef89c2..1499181fb0e9 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -45,13 +45,13 @@
> * entry type. But these bits might affect the ability to clear entries with
> * pxx_clear() because of how dynamic page table folding works on s390. So
> * while loading up the entries do not change the lower 4 bits. It does not
> - * have affect any other platform.
> - *
> - * Also avoid the 62nd bit on ppc64 that is used to mark a pte entry.
> + * have affect any other platform. Also avoid the 62nd bit on ppc64 that is
> + * used to mark a pte entry.
> */
> -#define S390_MASK_BITS 4
> -#define PPC_MASK_BITS 2
> -#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1 - PPC_MASK_BITS, S390_MASK_BITS)
> +#define S390_SKIP_MASK GENMASK(3, 0)
> +#define PPC64_SKIP_MASK GENMASK(62, 62)
> +#define ARCH_SKIP_MASK (S390_SKIP_MASK | PPC64_SKIP_MASK)
> +#define RANDOM_ORVALUE (GENMASK(BITS_PER_LONG - 1, 0) & ~ARCH_SKIP_MASK)
> #define RANDOM_NZVALUE GENMASK(7, 0)
>
> static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
>
I will switch to this.
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/16] debug_vm_pgtable/ppc64: Avoid setting top bits in radom value
Date: Wed, 12 Aug 2020 13:55:35 +0530 [thread overview]
Message-ID: <b92fea41-ce31-4915-fdc6-56631222df18@linux.ibm.com> (raw)
In-Reply-To: <fcb44f1d-4131-9135-512e-11a5c00abcd9@arm.com>
On 8/12/20 1:42 PM, Anshuman Khandual wrote:
>
>
> On 08/12/2020 12:03 PM, Aneesh Kumar K.V wrote:
>> ppc64 use bit 62 to indicate a pte entry (_PAGE_PTE). Avoid setting that bit in
>> random value.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> ---
>> mm/debug_vm_pgtable.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
>> index 086309fb9b6f..4c32063a8acf 100644
>> --- a/mm/debug_vm_pgtable.c
>> +++ b/mm/debug_vm_pgtable.c
>> @@ -45,9 +45,12 @@
>> * pxx_clear() because of how dynamic page table folding works on s390. So
>> * while loading up the entries do not change the lower 4 bits. It does not
>> * have affect any other platform.
>> + *
>> + * Also avoid the 62nd bit on ppc64 that is used to mark a pte entry.
>> */
>
> Please move and fold the above line with the existing paragraph.
>
>> #define S390_MASK_BITS 4
>> -#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1, S390_MASK_BITS)
>> +#define PPC_MASK_BITS 2
>
> s/PPC/PPC64/
>
>> +#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1 - PPC_MASK_BITS, S390_MASK_BITS)
>> #define RANDOM_NZVALUE GENMASK(7, 0)
>>
>> static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
>>
>
> With this change, RANDOM_ORVALUE will be (0x3ffffffffffffff0) which discards
> both bit 63 and 62. If only bit 62 is to be avoided for ppc64 the mask should
> be (0xbffffffffffffff0) instead. The following change on this patch should do
> the trick.
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index eb059fef89c2..1499181fb0e9 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -45,13 +45,13 @@
> * entry type. But these bits might affect the ability to clear entries with
> * pxx_clear() because of how dynamic page table folding works on s390. So
> * while loading up the entries do not change the lower 4 bits. It does not
> - * have affect any other platform.
> - *
> - * Also avoid the 62nd bit on ppc64 that is used to mark a pte entry.
> + * have affect any other platform. Also avoid the 62nd bit on ppc64 that is
> + * used to mark a pte entry.
> */
> -#define S390_MASK_BITS 4
> -#define PPC_MASK_BITS 2
> -#define RANDOM_ORVALUE GENMASK(BITS_PER_LONG - 1 - PPC_MASK_BITS, S390_MASK_BITS)
> +#define S390_SKIP_MASK GENMASK(3, 0)
> +#define PPC64_SKIP_MASK GENMASK(62, 62)
> +#define ARCH_SKIP_MASK (S390_SKIP_MASK | PPC64_SKIP_MASK)
> +#define RANDOM_ORVALUE (GENMASK(BITS_PER_LONG - 1, 0) & ~ARCH_SKIP_MASK)
> #define RANDOM_NZVALUE GENMASK(7, 0)
>
> static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
>
I will switch to this.
-aneesh
next prev parent reply other threads:[~2020-08-12 8:25 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 6:33 [PATCH 01/16] powerpc/mm: Add DEBUG_VM WARN for pmd_clear Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 02/16] debug_vm_pgtable/ppc64: Avoid setting top bits in radom value Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 6:40 ` Christophe Leroy
2020-08-12 6:43 ` Aneesh Kumar K.V
2020-08-12 8:12 ` Anshuman Khandual
2020-08-12 8:12 ` Anshuman Khandual
2020-08-12 8:25 ` Aneesh Kumar K.V [this message]
2020-08-12 8:25 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 03/16] debug_vm_pgtable/set_pte: Don't use set_pte_at to update an existing pte entry Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 9:12 ` Anshuman Khandual
2020-08-12 9:12 ` Anshuman Khandual
2020-08-12 9:22 ` Aneesh Kumar K.V
2020-08-12 9:22 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 04/16] debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 10:30 ` Anshuman Khandual
2020-08-12 10:30 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 05/16] debug_vm_pgtable/savedwrite: Enable savedwrite test with CONFIG_NUMA_BALANCING Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 11:24 ` Anshuman Khandual
2020-08-12 11:24 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 06/16] debug_vm_pgtable/THP: Mark the pte entry huge before using set_pmd_at Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 07/16] debug_vm_pgtable/THP: Mark the pte entry huge before using set_pud_at Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 11:49 ` Anshuman Khandual
2020-08-12 11:49 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 08/16] debug_vm_pgtable/set_pmd: Don't use set_pmd_at to update an existing pmd entry Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 12:46 ` Anshuman Khandual
2020-08-12 12:46 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 09/16] debug_vm_pgtable/set_pud: Don't use set_pud_at to update an existing pud entry Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 12:46 ` Anshuman Khandual
2020-08-12 12:46 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 10/16] debug_vm_pgtable/thp: Use page table depost/withdraw with THP Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-13 5:25 ` Anshuman Khandual
2020-08-13 5:25 ` Anshuman Khandual
2020-08-13 6:38 ` Aneesh Kumar K.V
2020-08-13 6:38 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 11/16] debug_vm_pgtable/locks: Move non page table modifying test together Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 12/16] debug_vm_pgtable/locks: Take correct page table lock Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 13/16] debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entries Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-13 5:27 ` Anshuman Khandual
2020-08-13 5:27 ` Anshuman Khandual
2020-08-13 8:45 ` Aneesh Kumar K.V
2020-08-13 8:45 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 14/16] debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 13:03 ` Anshuman Khandual
2020-08-12 13:03 ` Anshuman Khandual
2020-08-12 13:16 ` Aneesh Kumar K.V
2020-08-12 13:16 ` Aneesh Kumar K.V
2020-08-12 13:34 ` Anshuman Khandual
2020-08-12 13:34 ` Anshuman Khandual
2020-08-12 13:52 ` Aneesh Kumar K.V
2020-08-12 13:52 ` Aneesh Kumar K.V
2020-08-14 8:43 ` Anshuman Khandual
2020-08-14 8:43 ` Anshuman Khandual
2020-08-19 6:54 ` Aneesh Kumar K.V
2020-08-19 6:54 ` Aneesh Kumar K.V
2020-08-12 6:33 ` [PATCH 15/16] debug_vm_pgtable/savedwrite: Use savedwrite test with protnone ptes Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-12 13:06 ` Anshuman Khandual
2020-08-12 13:06 ` Anshuman Khandual
2020-08-12 6:33 ` [PATCH 16/16] debug_vm_pgtable/ppc64: Add a variant of pfn_pte/pmd Aneesh Kumar K.V
2020-08-12 6:33 ` Aneesh Kumar K.V
2020-08-13 5:30 ` Anshuman Khandual
2020-08-13 5:30 ` Anshuman Khandual
2020-08-13 6:37 ` Aneesh Kumar K.V
2020-08-13 6:37 ` Aneesh Kumar K.V
2020-08-14 8:29 ` Anshuman Khandual
2020-08-14 8:29 ` Anshuman Khandual
2020-08-12 7:46 ` [PATCH 01/16] powerpc/mm: Add DEBUG_VM WARN for pmd_clear Anshuman Khandual
2020-08-12 7:46 ` Anshuman Khandual
2020-08-12 8:27 ` Aneesh Kumar K.V
2020-08-12 8:27 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92fea41-ce31-4915-fdc6-56631222df18@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.