From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver
Date: Wed, 24 Jan 2024 02:24:35 +0200 [thread overview]
Message-ID: <ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com> (raw)
In-Reply-To: <298b7a10-2acb-4297-92cd-2ee4d890bfb2@rock-chips.com>
Hi Andy,
On 1/22/24 12:17, Andy Yan wrote:
> Hi Cristian:
>
> On 1/20/24 03:38, Cristian Ciocaltea wrote:
>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.
[...]
>> +static int rockchip_hdptx_phy_power_on(struct phy *phy)
>> +{
>> + struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy);
>> + int bus_width = phy_get_bus_width(hdptx->phy);
>> + int bit_rate = bus_width & DATA_RATE_MASK;
>> + int ret;
>> +
>> + dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n",
>> + __func__, bus_width, bit_rate);
>> +
>> + ret = pm_runtime_resume_and_get(hdptx->dev);
>> + if (ret) {
>> + dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + if (bus_width & HDMI_EARC_MASK)
>> + hdptx->earc_en = true;
>> + else
>> + hdptx->earc_en = false;
>> +
>> + if (bus_width & HDMI_MODE_MASK) {
>
> Here use phy->attrs.bus_width to indicate different work mode,
> we also use the same in our bsp, but not sure if it is the appropriate way.
Unfortunately the PHY API doesn't seem to provide a clean way to pass
arbitrary data. Probably for the initial support we could simply drop
the 10-bit color depth, FRL and EARC features.
Thanks,
Cristian
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver
Date: Wed, 24 Jan 2024 02:24:35 +0200 [thread overview]
Message-ID: <ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com> (raw)
In-Reply-To: <298b7a10-2acb-4297-92cd-2ee4d890bfb2@rock-chips.com>
Hi Andy,
On 1/22/24 12:17, Andy Yan wrote:
> Hi Cristian:
>
> On 1/20/24 03:38, Cristian Ciocaltea wrote:
>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.
[...]
>> +static int rockchip_hdptx_phy_power_on(struct phy *phy)
>> +{
>> + struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy);
>> + int bus_width = phy_get_bus_width(hdptx->phy);
>> + int bit_rate = bus_width & DATA_RATE_MASK;
>> + int ret;
>> +
>> + dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n",
>> + __func__, bus_width, bit_rate);
>> +
>> + ret = pm_runtime_resume_and_get(hdptx->dev);
>> + if (ret) {
>> + dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + if (bus_width & HDMI_EARC_MASK)
>> + hdptx->earc_en = true;
>> + else
>> + hdptx->earc_en = false;
>> +
>> + if (bus_width & HDMI_MODE_MASK) {
>
> Here use phy->attrs.bus_width to indicate different work mode,
> we also use the same in our bsp, but not sure if it is the appropriate way.
Unfortunately the PHY API doesn't seem to provide a clean way to pass
arbitrary data. Probably for the initial support we could simply drop
the 10-bit color depth, FRL and EARC features.
Thanks,
Cristian
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver
Date: Wed, 24 Jan 2024 02:24:35 +0200 [thread overview]
Message-ID: <ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com> (raw)
In-Reply-To: <298b7a10-2acb-4297-92cd-2ee4d890bfb2@rock-chips.com>
Hi Andy,
On 1/22/24 12:17, Andy Yan wrote:
> Hi Cristian:
>
> On 1/20/24 03:38, Cristian Ciocaltea wrote:
>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.
[...]
>> +static int rockchip_hdptx_phy_power_on(struct phy *phy)
>> +{
>> + struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy);
>> + int bus_width = phy_get_bus_width(hdptx->phy);
>> + int bit_rate = bus_width & DATA_RATE_MASK;
>> + int ret;
>> +
>> + dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n",
>> + __func__, bus_width, bit_rate);
>> +
>> + ret = pm_runtime_resume_and_get(hdptx->dev);
>> + if (ret) {
>> + dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + if (bus_width & HDMI_EARC_MASK)
>> + hdptx->earc_en = true;
>> + else
>> + hdptx->earc_en = false;
>> +
>> + if (bus_width & HDMI_MODE_MASK) {
>
> Here use phy->attrs.bus_width to indicate different work mode,
> we also use the same in our bsp, but not sure if it is the appropriate way.
Unfortunately the PHY API doesn't seem to provide a clean way to pass
arbitrary data. Probably for the initial support we could simply drop
the 10-bit color depth, FRL and EARC features.
Thanks,
Cristian
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Andy Yan <andy.yan@rock-chips.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Algea Cao <algea.cao@rock-chips.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver
Date: Wed, 24 Jan 2024 02:24:35 +0200 [thread overview]
Message-ID: <ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com> (raw)
In-Reply-To: <298b7a10-2acb-4297-92cd-2ee4d890bfb2@rock-chips.com>
Hi Andy,
On 1/22/24 12:17, Andy Yan wrote:
> Hi Cristian:
>
> On 1/20/24 03:38, Cristian Ciocaltea wrote:
>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.
[...]
>> +static int rockchip_hdptx_phy_power_on(struct phy *phy)
>> +{
>> + struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy);
>> + int bus_width = phy_get_bus_width(hdptx->phy);
>> + int bit_rate = bus_width & DATA_RATE_MASK;
>> + int ret;
>> +
>> + dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n",
>> + __func__, bus_width, bit_rate);
>> +
>> + ret = pm_runtime_resume_and_get(hdptx->dev);
>> + if (ret) {
>> + dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + if (bus_width & HDMI_EARC_MASK)
>> + hdptx->earc_en = true;
>> + else
>> + hdptx->earc_en = false;
>> +
>> + if (bus_width & HDMI_MODE_MASK) {
>
> Here use phy->attrs.bus_width to indicate different work mode,
> we also use the same in our bsp, but not sure if it is the appropriate way.
Unfortunately the PHY API doesn't seem to provide a clean way to pass
arbitrary data. Probably for the initial support we could simply drop
the 10-bit color depth, FRL and EARC features.
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-24 0:24 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 19:38 [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` [PATCH 1/3] dt-bindings: soc: rockchip: Add rk3588 hdptxphy syscon Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-25 9:10 ` Krzysztof Kozlowski
2024-01-25 9:10 ` Krzysztof Kozlowski
2024-01-25 9:10 ` Krzysztof Kozlowski
2024-01-25 9:10 ` Krzysztof Kozlowski
2024-01-19 19:38 ` [PATCH 2/3] dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY schema Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-25 9:11 ` Krzysztof Kozlowski
2024-01-25 9:11 ` Krzysztof Kozlowski
2024-01-25 9:11 ` Krzysztof Kozlowski
2024-01-25 9:11 ` Krzysztof Kozlowski
2024-01-25 9:39 ` Cristian Ciocaltea
2024-01-25 9:39 ` Cristian Ciocaltea
2024-01-25 9:39 ` Cristian Ciocaltea
2024-01-25 9:39 ` Cristian Ciocaltea
2024-01-19 19:38 ` [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 19:38 ` Cristian Ciocaltea
2024-01-19 22:47 ` Sebastian Reichel
2024-01-19 22:47 ` Sebastian Reichel
2024-01-19 22:47 ` Sebastian Reichel
2024-01-19 22:47 ` Sebastian Reichel
2024-01-19 23:22 ` Cristian Ciocaltea
2024-01-19 23:22 ` Cristian Ciocaltea
2024-01-19 23:22 ` Cristian Ciocaltea
2024-01-19 23:22 ` Cristian Ciocaltea
2024-01-20 16:00 ` Alex Bee
2024-01-20 16:00 ` Alex Bee
2024-01-20 16:00 ` Alex Bee
2024-01-20 16:00 ` Alex Bee
2024-01-22 10:17 ` Andy Yan
2024-01-22 10:17 ` Andy Yan
2024-01-22 10:17 ` Andy Yan
2024-01-22 10:17 ` Andy Yan
2024-01-24 0:24 ` Cristian Ciocaltea [this message]
2024-01-24 0:24 ` Cristian Ciocaltea
2024-01-24 0:24 ` Cristian Ciocaltea
2024-01-24 0:24 ` Cristian Ciocaltea
2024-01-22 12:14 ` Sascha Hauer
2024-01-22 12:14 ` Sascha Hauer
2024-01-22 12:14 ` Sascha Hauer
2024-01-22 12:14 ` Sascha Hauer
2024-01-24 0:58 ` Cristian Ciocaltea
2024-01-24 0:58 ` Cristian Ciocaltea
2024-01-24 0:58 ` Cristian Ciocaltea
2024-01-24 0:58 ` Cristian Ciocaltea
2024-01-24 2:42 ` Andy Yan
2024-01-24 2:42 ` Andy Yan
2024-01-24 2:42 ` Andy Yan
2024-01-24 2:42 ` Andy Yan
2024-01-24 7:30 ` Andy Yan
2024-01-24 7:30 ` Andy Yan
2024-01-24 7:30 ` Andy Yan
2024-01-24 7:30 ` Andy Yan
2024-01-24 9:16 ` Jonas Karlman
2024-01-24 9:16 ` Jonas Karlman
2024-01-24 9:16 ` Jonas Karlman
2024-01-24 9:16 ` Jonas Karlman
2024-01-24 23:08 ` Cristian Ciocaltea
2024-01-24 23:08 ` Cristian Ciocaltea
2024-01-24 23:08 ` Cristian Ciocaltea
2024-01-24 23:08 ` Cristian Ciocaltea
2024-01-19 23:41 ` [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY Cristian Ciocaltea
2024-01-19 23:41 ` Cristian Ciocaltea
2024-01-19 23:41 ` Cristian Ciocaltea
2024-01-19 23:41 ` Cristian Ciocaltea
2024-01-22 10:10 ` Andy Yan
2024-01-22 10:10 ` Andy Yan
2024-01-22 10:10 ` Andy Yan
2024-01-22 10:10 ` Andy Yan
2024-01-24 1:03 ` Cristian Ciocaltea
2024-01-24 1:03 ` Cristian Ciocaltea
2024-01-24 1:03 ` Cristian Ciocaltea
2024-01-24 1:03 ` Cristian Ciocaltea
2024-01-25 19:56 ` (subset) " Heiko Stuebner
2024-01-25 19:56 ` Heiko Stuebner
2024-01-25 19:56 ` Heiko Stuebner
2024-01-25 19:56 ` Heiko Stuebner
2024-01-25 20:00 ` Cristian Ciocaltea
2024-01-25 20:00 ` Cristian Ciocaltea
2024-01-25 20:00 ` Cristian Ciocaltea
2024-01-25 20:00 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=algea.cao@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.