[B.A.T.M.A.N.] Patchwork on open-mesh.org

[B.A.T.M.A.N.] Patchwork on open-mesh.org

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 2648 bytes --]

Hi,

I've used my free time in the last week to look over the 5246 patches which 
were sent to the B.A.T.M.A.N. mailing list. These patches were categorized as

 * Accepted:
   committed to the respective repository at git.open-mesh.org
 * Rejected:
   Either rejected by the Maintainer(s) or withdrawn by the Author because
   they turned out to be a bad idea
 * RFC
   patches which were just posted to get comments
 * Not applicable
   patches which were not really for a repository at git.open-mesh.org
   (for example patches which are forwarded to net-next.git/net.git)
 * Changes requested
   Patch had flaws but these could be fixed but the author of the patch hasn't
   sent a new version of the patch
 * Superseded
   New version of the patch(set) was sent which makes the old version obsolete

The result can now be found at https://patchwork.open-mesh.org/

You may wonder why are there patches with the state "New" + "Delegate" set to 
some person. These are the patches which have not yet been applied in their 
respective repository at git.open-mesh.org, not yet rejected and not yet 
replaced by a different patch. Ok, these are most likely not all still waiting 
to be applied but I just didn't know their state and thus the maintainer(s) 
have to look over the remaining patches and change their state. Until then, 
these are added to the TODO list of the maintainer [1].

Patchwork is currently configured to read the mails which are sent to 
b.a.t.m.a.n@lists.open-mesh.org and add each patch + its comments to the 
patchwork database. Maintainers can then update their state, download the 
patches and bundle them (which then can be downloaded again). A heuristic was 
installed in the post-receive hook that tries to find the correct commit for a 
newly applied patch in the master branch and automatically mark them as 
Accepted.

The author of an patch will be automatically informed about changes to the 
state of his patch.

I have already started to assign the patches with the state "New" to the 
maintainers. This is also the reason why Marek, Simon and Elektra will not be 
able to create their own account and instead will receive a mail from me with 
their account data.

But also other people can help here. They can register to set the state of 
their own patches. This is for example helpful when they've just submitted a 
new patchset and want to mark the old patchset as superseded. But they can of 
course also disable the notification mails.

I hope this helps to better keep track on the incoming patches and make it 
harder to forget one.

Kind regards,
	Sven

[1] https://patchwork.open-mesh.org/user/todo/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[B.A.T.M.A.N.] [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED

[Sven Eckelmann]

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
Antonio, please add this to your tree for net-next.git

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b49fac7..d667d73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2187,6 +2187,7 @@ M:	Simon Wunderlich <sw@simonwunderlich.de>
 M:	Antonio Quartulli <a@unstable.cc>
 L:	b.a.t.m.a.n@lists.open-mesh.org
 W:	https://www.open-mesh.org/
+Q:	https://patchwork.open-mesh.org/project/batman/list/
 S:	Maintained
 F:	net/batman-adv/
 

Re: [B.A.T.M.A.N.] [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

On Sun, Feb 21, 2016 at 04:40:55PM +0100, Sven Eckelmann wrote:
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Antonio, please add this to your tree for net-next.git

Applied to my tree and ready to land in net-next.

Thanks !

-- 
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] Patchwork on open-mesh.org

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

On Sunday, February 21, 2016 16:39:22 Sven Eckelmann wrote:
> I've used my free time in the last week to look over the 5246 patches which 
> were sent to the B.A.T.M.A.N. mailing list. These patches were categorized
> as
> 
>  * Accepted:
>    committed to the respective repository at git.open-mesh.org
>  * Rejected:
>    Either rejected by the Maintainer(s) or withdrawn by the Author because
>    they turned out to be a bad idea
>  * RFC
>    patches which were just posted to get comments
>  * Not applicable
>    patches which were not really for a repository at git.open-mesh.org
>    (for example patches which are forwarded to net-next.git/net.git)
>  * Changes requested
>    Patch had flaws but these could be fixed but the author of the patch
> hasn't sent a new version of the patch
>  * Superseded
>    New version of the patch(set) was sent which makes the old version
> obsolete
> 
> The result can now be found at https://patchwork.open-mesh.org/

Thanks a lot for doing all this cleanup work! I doubt any mere mortal could 
have reviewed the state for 5000+ patches on a rainy weekend ..  :-)

A few questions as to how this works:

* [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED
 -> Manually marked as 'accepted' as it won't be easily detectable as merged. 
Correct ?

 * [B.A.T.M.A.N.,2/2] batman-adv: Split batadv_iv_ogm_orig_del_if function
 -> Merged patch today but still shows up in patchwork. Should we wait for the 
auto-detection or did I do something wrong ?

 * [B.A.T.M.A.N.] batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq
 -> Marked as opened but has been superseded by '[B.A.T.M.A.N.] [PATCH] 
batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq' that was merged 
today ? Shall I mark as 'accepted' ?

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [B.A.T.M.A.N.] Patchwork on open-mesh.org

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

On Sunday 28 February 2016 12:43:27 Marek Lindner wrote:
[...]
> A few questions as to how this works:
> 
> * [PATCH] MAINTAINERS: Add patchwork URL for BATMAN ADVANCED
>  -> Manually marked as 'accepted' as it won't be easily detectable as
> merged. Correct ?

Correct.

>  * [B.A.T.M.A.N.,2/2] batman-adv: Split batadv_iv_ogm_orig_del_if function
>  -> Merged patch today but still shows up in patchwork. Should we wait for
> the auto-detection or did I do something wrong ?

I've created this patch in a way that it was better readable for you but not 
detectable by the heuristic, So I've expected it to not be detected.

Marked it manually as accepted

>  * [B.A.T.M.A.N.] batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq
>  -> Marked as opened but has been superseded by '[B.A.T.M.A.N.] [PATCH]
> batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq' that was merged
> today ? Shall I mark as 'accepted' ?

I would have hoped that the heuristic gets this one but it didn't. Most likely 
because the position changed to much (but this is just a wild guess). I've 
marked it as accepted.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]