From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received
Date: Wed, 09 May 2018 22:08:56 +0800 [thread overview]
Message-ID: <2420912.gZVJyty8xz@lafayette> (raw)
In-Reply-To: <20180506195559.32602-1-me@irrelefant.net>
[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]
On Monday, May 7, 2018 3:55:59 AM HKT Leonardo Mörlein wrote:
> - if (!vlan)
> - return false;
> + if (!vlan) {
> + /* Due to a bug, some originators send TT
> + * announcements for empty vlans. As the receiving
> + * nodes will ignore those empty vlans (they do not
> + * add a batadv_orig_node_vlan into the transglobal
> + * for the originating node), crc check will fail
> + * here. To circumvent this issue, we skip the
> + * verification for the vlan if the crc is
> + * equal to 0x00000000.
> + */
> + if (tt_vlan_tmp->crc == 0x00000000)
> + continue;
> + else
> + return false;
> + }
There are some issues with this approach:
* As you might be aware, a CRC of 0x00000000 is not an invalid or
uninitialized CRC. That means it is conceivable the CRC over the translation
table entries and flags results in a CRC of 0x00000000 without any bugs being
present. Applying this patch would lead to introducing a bug in these
conditions.
* The second concern is about how to deal with 'the bug' (referring to your
patch comment above). In your case 'the bug' results in missing TT entries
for a given VLAN plus a CRC of 0x00000000. What if the CRC was 0x00000001 due
to some other bug ? Then you're check would totally miss the mark and we're
back at the beginning.
If we wish to deal with such misbehavior on a scale where we assume the code
should be able to deal with garbage values in some or all fields a different
approach is needed. Relying on a magic number (CRC 0x00000000) is as bad as
the current behavior (assuming each VLAN has an entry).
Shortly, I will send a patch to prevent sending an empty VLAN around. Please
note that this patch still is more of a band-aid. We still don't know how the
empty VLAN came into being in the first place. Plus, that patch won't protect
against garbage packets which certainly requires more effort.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-09 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:55 [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received Leonardo Mörlein
2018-05-07 6:32 ` Sven Eckelmann
2018-05-07 8:06 ` me
2018-05-07 10:23 ` Sven Eckelmann
2018-05-08 8:45 ` Sven Eckelmann
2018-05-09 14:08 ` Marek Lindner [this message]
2018-05-09 16:06 ` [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs Marek Lindner
2018-05-09 17:21 ` Sven Eckelmann
2018-05-09 18:20 ` Sven Eckelmann
2018-05-09 20:38 ` Sven Eckelmann
2018-05-09 21:34 ` lemoer
2018-05-10 9:12 ` Antonio Quartulli
2018-05-10 10:28 ` Marek Lindner
2018-05-10 14:41 ` [B.A.T.M.A.N.] [RFC v2] " Marek Lindner
2018-05-10 15:50 ` Sven Eckelmann
2018-05-11 15:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2420912.gZVJyty8xz@lafayette \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).