From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Sven Eckelmann <sven@narfation.org>
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs
Date: Thu, 10 May 2018 17:12:56 +0800 [thread overview]
Message-ID: <e46dacd0-0b26-3d5a-3fc4-f15bec1da336@unstable.cc> (raw)
In-Reply-To: <2913969.huEjgAY5Wz@sven-edge>
[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]
On 10/05/18 04:38, Sven Eckelmann wrote:
>> Let me rephrase that: Are we sure that this is from intermediate nodes or is
>> there still the possibility that it is from the actual originator? Regarding
>> the latter: Should batadv_tt_prepare_tvlv_local_data be modified or will you
>> wait for Leonardo to debug why it happens in the first place?
>
> Wait. When it is a problem of an intermediate node that doesn't have (for
> whatever reason) not a valid copy of the entries, shouldn't the intermediate
> node just ignore the request and not answer it? Otherwise the next OGM with
> the data from batadv_tt_prepare_tvlv_local_data from the actual node will
> just trigger the next request by the receiver.
>
> And the next thing is that your commit message is talking about OGMs all the
> time. But the OGM TVLV are not filled by the
> batadv_tt_prepare_tvlv_global_data but by the
> batadv_tt_prepare_tvlv_local_data. I am unable to find out what you actually
> doing here and why you do it.
I believe batadv_tt_prepare_tvlv_local_data() was the actual function
that Marek wanted to modify. But we probably spent too much time digging
into translation-table.c these days and I managed to confuse him enough.
Thanks for pointing this out, Sven!
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-10 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:55 [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received Leonardo Mörlein
2018-05-07 6:32 ` Sven Eckelmann
2018-05-07 8:06 ` me
2018-05-07 10:23 ` Sven Eckelmann
2018-05-08 8:45 ` Sven Eckelmann
2018-05-09 14:08 ` Marek Lindner
2018-05-09 16:06 ` [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs Marek Lindner
2018-05-09 17:21 ` Sven Eckelmann
2018-05-09 18:20 ` Sven Eckelmann
2018-05-09 20:38 ` Sven Eckelmann
2018-05-09 21:34 ` lemoer
2018-05-10 9:12 ` Antonio Quartulli [this message]
2018-05-10 10:28 ` Marek Lindner
2018-05-10 14:41 ` [B.A.T.M.A.N.] [RFC v2] " Marek Lindner
2018-05-10 15:50 ` Sven Eckelmann
2018-05-11 15:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46dacd0-0b26-3d5a-3fc4-f15bec1da336@unstable.cc \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).