Re: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical

From: "André Draszik" <andre.draszik@linaro.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: peter.griffin@linaro.org, robh+dt@kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	 linux-kernel@vger.kernel.org, kernel-team@android.com,
	tudor.ambarus@linaro.org,  willmcvicker@google.com,
	alim.akhtar@samsung.com, s.nawrocki@samsung.com,
	 tomasz.figa@gmail.com, cw00.choi@samsung.com,
	mturquette@baylibre.com,  sboyd@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical
Date: Tue, 30 Jan 2024 09:31:22 +0000	[thread overview]
Message-ID: <bbaab3addf958bc1f484a20ee0bdb65af05cf5da.camel@linaro.org> (raw)
In-Reply-To: <CAPLW+4kSka+twSoZmQeMsh3RWermrGG-wyENrr14AmX3zZ2eqA@mail.gmail.com>

On Mon, 2024-01-29 at 13:16 -0600, Sam Protsenko wrote:
> That sounds reasonable. But I wonder if that bit (about making this
> clock CLK_IS_CRITICAL to make earlycon functional) can be documented
> somewhere. Perhaps in the serial driver (earlycon function), or
> somewhere in device tree bindings? Because otherwise it might remain
> an arcane knowledge and people won't be able to use earlycon later.
> Anyways, for this patch:
> 
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> 
> and if you think it makes sense to document the bit above, please do.

Will do on top of
https://lore.kernel.org/all/20240119104526.1221243-6-tudor.ambarus@linaro.org/
once that is in.

Cheers,
Andre'