From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property
Date: Wed, 30 Nov 2022 09:35:04 +0100 [thread overview]
Message-ID: <bc356f96-600a-64df-c0fe-00c807fa605c@linaro.org> (raw)
In-Reply-To: <741d7ce16df25450b08c92e508190bc7c91fc8d9.camel@mediatek.com>
On 30/11/2022 09:18, Xiangsheng Hou (侯祥胜) wrote:
> Hi Krzysztof,
>
> On Tue, 2022-11-29 at 08:47 +0100, Krzysztof Kozlowski wrote:
>> On 29/11/2022 03:50, Xiangsheng Hou (侯祥胜) wrote:
>>
>>>>> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> @@ -55,6 +55,22 @@ properties:
>>>>> description: device-tree node of the accompanying ECC
>>>>> engine.
>>>>> $ref: /schemas/types.yaml#/definitions/phandle
>>>>>
>>>>> + rx-sample-delay:
>>>>
>>>> No, use existing property, don't invent your own stuff - missing
>>>> unit
>>>> suffix. See spi-peripheral-props.yaml.
>>>
>>> Will change to other private property. The read sample delay with
>>> MediaTek SPI NAND controller can be set with values from 0 to 47.
>>> However, it`s difficult to say the unit of each vaule, because the
>>> unit
>>> value will be difference with different chip process or different
>>> corner IC.
>>
>> Why you cannot use same formula as other SPI drivers for sample-
>> delay?
>> And divide/multiple by some factor specific to SoC, which is taken
>> from
>> driver_data?
>
> Even for specific SoC, the unit of sample delay may be various with
> different corner IC.
Which is easy to achieve with driver_data as I said.
> Besides, whether it`s acceptable by change the property rx-sample-delay
> and rx-latch-latency to mediatek,rx-sample-delay and mediatek,rx-latch-
> latency?
Not for sample delay, because you should use existing properties. Your
driver implementation is not usually argument to duplicate properties in
the bindings.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property
Date: Wed, 30 Nov 2022 09:35:04 +0100 [thread overview]
Message-ID: <bc356f96-600a-64df-c0fe-00c807fa605c@linaro.org> (raw)
In-Reply-To: <741d7ce16df25450b08c92e508190bc7c91fc8d9.camel@mediatek.com>
On 30/11/2022 09:18, Xiangsheng Hou (侯祥胜) wrote:
> Hi Krzysztof,
>
> On Tue, 2022-11-29 at 08:47 +0100, Krzysztof Kozlowski wrote:
>> On 29/11/2022 03:50, Xiangsheng Hou (侯祥胜) wrote:
>>
>>>>> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> @@ -55,6 +55,22 @@ properties:
>>>>> description: device-tree node of the accompanying ECC
>>>>> engine.
>>>>> $ref: /schemas/types.yaml#/definitions/phandle
>>>>>
>>>>> + rx-sample-delay:
>>>>
>>>> No, use existing property, don't invent your own stuff - missing
>>>> unit
>>>> suffix. See spi-peripheral-props.yaml.
>>>
>>> Will change to other private property. The read sample delay with
>>> MediaTek SPI NAND controller can be set with values from 0 to 47.
>>> However, it`s difficult to say the unit of each vaule, because the
>>> unit
>>> value will be difference with different chip process or different
>>> corner IC.
>>
>> Why you cannot use same formula as other SPI drivers for sample-
>> delay?
>> And divide/multiple by some factor specific to SoC, which is taken
>> from
>> driver_data?
>
> Even for specific SoC, the unit of sample delay may be various with
> different corner IC.
Which is easy to achieve with driver_data as I said.
> Besides, whether it`s acceptable by change the property rx-sample-delay
> and rx-latch-latency to mediatek,rx-sample-delay and mediatek,rx-latch-
> latency?
Not for sample delay, because you should use existing properties. Your
driver implementation is not usually argument to duplicate properties in
the bindings.
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property
Date: Wed, 30 Nov 2022 09:35:04 +0100 [thread overview]
Message-ID: <bc356f96-600a-64df-c0fe-00c807fa605c@linaro.org> (raw)
In-Reply-To: <741d7ce16df25450b08c92e508190bc7c91fc8d9.camel@mediatek.com>
On 30/11/2022 09:18, Xiangsheng Hou (侯祥胜) wrote:
> Hi Krzysztof,
>
> On Tue, 2022-11-29 at 08:47 +0100, Krzysztof Kozlowski wrote:
>> On 29/11/2022 03:50, Xiangsheng Hou (侯祥胜) wrote:
>>
>>>>> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
>>>>> snfi.yaml
>>>>> @@ -55,6 +55,22 @@ properties:
>>>>> description: device-tree node of the accompanying ECC
>>>>> engine.
>>>>> $ref: /schemas/types.yaml#/definitions/phandle
>>>>>
>>>>> + rx-sample-delay:
>>>>
>>>> No, use existing property, don't invent your own stuff - missing
>>>> unit
>>>> suffix. See spi-peripheral-props.yaml.
>>>
>>> Will change to other private property. The read sample delay with
>>> MediaTek SPI NAND controller can be set with values from 0 to 47.
>>> However, it`s difficult to say the unit of each vaule, because the
>>> unit
>>> value will be difference with different chip process or different
>>> corner IC.
>>
>> Why you cannot use same formula as other SPI drivers for sample-
>> delay?
>> And divide/multiple by some factor specific to SoC, which is taken
>> from
>> driver_data?
>
> Even for specific SoC, the unit of sample delay may be various with
> different corner IC.
Which is easy to achieve with driver_data as I said.
> Besides, whether it`s acceptable by change the property rx-sample-delay
> and rx-latch-latency to mediatek,rx-sample-delay and mediatek,rx-latch-
> latency?
Not for sample delay, because you should use existing properties. Your
driver implementation is not usually argument to duplicate properties in
the bindings.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-30 8:35 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:06 [PATCH 0/9] Add MediaTek MT7986 SPI NAND and ECC support Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 1/9] spi: mtk-snfi: add snfi support for mt7986 IC Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 2/9] spi: mtk-snfi: change default page format to setup default setting Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 3/9] spi: mtk-snfi: add optional nfi_hclk which needed for mt7986 Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 4/9] mtd: nand: ecc-mtk: add ecc support fot mt7986 IC Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 9:00 ` Krzysztof Kozlowski
2022-11-28 9:00 ` Krzysztof Kozlowski
2022-11-28 9:00 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:33 ` Krzysztof Kozlowski
2022-11-30 8:33 ` Krzysztof Kozlowski
2022-11-30 8:33 ` Krzysztof Kozlowski
2022-11-28 2:06 ` [PATCH 6/9] spi: mtk-snfi: add snfi sample delay and read latency adjustment Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 9:04 ` Krzysztof Kozlowski
2022-11-28 9:04 ` Krzysztof Kozlowski
2022-11-28 9:04 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:35 ` Krzysztof Kozlowski [this message]
2022-11-30 8:35 ` Krzysztof Kozlowski
2022-11-30 8:35 ` Krzysztof Kozlowski
2022-11-30 9:08 ` Chuanhong Guo
2022-11-30 9:08 ` Chuanhong Guo
2022-11-30 9:08 ` Chuanhong Guo
2022-11-28 12:20 ` Rob Herring
2022-11-28 12:20 ` Rob Herring
2022-11-28 12:20 ` Rob Herring
2022-11-28 2:06 ` [PATCH 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 9:13 ` Krzysztof Kozlowski
2022-11-28 9:13 ` Krzysztof Kozlowski
2022-11-28 9:13 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-28 12:20 ` Rob Herring
2022-11-28 12:20 ` Rob Herring
2022-11-28 12:20 ` Rob Herring
2022-12-01 5:24 ` kernel test robot
2022-12-01 5:24 ` kernel test robot
2022-12-01 5:24 ` kernel test robot
2022-11-28 2:06 ` [PATCH 9/9] dt-bindings: mtd: ecc-mtk: add mt7986 IC ecc bindings Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 2:06 ` Xiangsheng Hou
2022-11-28 9:14 ` Krzysztof Kozlowski
2022-11-28 9:14 ` Krzysztof Kozlowski
2022-11-28 9:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc356f96-600a-64df-c0fe-00c807fa605c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Benliang.Zhao@mediatek.com \
--cc=Xiangsheng.Hou@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.